Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread Bart via fpc-devel
On Fri, Jan 3, 2020 at 11:30 AM J. Gareth Moreton wrote: > Oh right, okay. That explains things then. I would have thought though > that it would have been test-compiled before being pushed to the main > repository. No, the fpc devels are not responsible for Lazarus. The adding of TStrings.Opt

Re: [fpc-devel] TEncoding.Default and default encoding for TStrings.LoadFrom*()

2020-01-03 Thread Ondrej Pokorny
On 03.01.2020 11:09, Michael Van Canneyt wrote: I also think it is very hypothetical, and not a problem unless you want to use the same stream in Delphi and FPC. Well, you have my blessing for the soPreserveBOM :) Added in r43848. I'll check how the FPC documentation works and try to add it

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread J. Gareth Moreton
Sorry, and I'm also misunderstanding that the class belongs to the RTL, not Lazarus.  Not a good start to the day! Gareth aka. Kit ___ fpc-devel maillist - fpc-devel@lists.freepascal.org https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-deve

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread J. Gareth Moreton
On 03/01/2020 10:19, Ondrej Pokorny wrote: There was no clash before. The Options property was introduced yesterday in r43841. FPC trunk is supported only in Lazarus trunk (and Lazarus stable branch if not forgotten :) ). Ondrej Oh right, okay.  That explains things then.  I would have tho

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread Ondrej Pokorny
On 03.01.2020 11:00, J. Gareth Moreton wrote: This was not a new property or a recent change to the Lazarus sources though. It was a recent change in FPC RTL sources: r43841. I was using an old revision of Lazarus to test optimisations on, and had been doing fine with it until I discovered l

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread Michael Van Canneyt
On Fri, 3 Jan 2020, J. Gareth Moreton wrote: This was not a new property or a recent change to the Lazarus sources though.  I was using an old revision of Lazarus to test optimisations on, and had been doing fine with it until I discovered last night that it would no longer build.  Updating

Re: [fpc-devel] TEncoding.Default and default encoding for TStrings.LoadFrom*()

2020-01-03 Thread Michael Van Canneyt
On Fri, 3 Jan 2020, Ondrej Pokorny wrote: On 03.01.2020 10:14, Michael Van Canneyt wrote: On Fri, 3 Jan 2020, Ondrej Pokorny wrote: On 03.01.2020 00:35, Werner Pamler wrote: Am 02.01.2020 um 20:10 schrieb Ondrej Pokorny: TStrings.SaveTo*() writes BOM by default. Formerly the BOM was not w

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread Sven Barth via fpc-devel
J. Gareth Moreton schrieb am Fr., 3. Jan. 2020, 10:45: > Hi everyone, > > So I reported this morning that Lazarus no longer builds as of r43826. > Ondrej was quick to update the Lazarus sources to allow it to build > again and marking the issue as fixed, but the underlying regression in > the Fre

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread J. Gareth Moreton
This was not a new property or a recent change to the Lazarus sources though.  I was using an old revision of Lazarus to test optimisations on, and had been doing fine with it until I discovered last night that it would no longer build.  Updating to the latest repository didn't change the file

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread Ondrej Pokorny
On 03.01.2020 10:45, J. Gareth Moreton wrote: Given the "illegal qualifier" errors that appeared, I'm guessing the issue is that "Options" is also a property of the THistoryList class as well as a local variable.  Technically speaking though, this is a regression unless it's to be documented (a

Re: [fpc-devel] TEncoding.Default and default encoding for TStrings.LoadFrom*()

2020-01-03 Thread Ondrej Pokorny
On 03.01.2020 10:14, Michael Van Canneyt wrote: On Fri, 3 Jan 2020, Ondrej Pokorny wrote: On 03.01.2020 00:35, Werner Pamler wrote: Am 02.01.2020 um 20:10 schrieb Ondrej Pokorny: TStrings.SaveTo*() writes BOM by default. Formerly the BOM was not written. There is also the problem that curre

Re: [fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread J. Gareth Moreton
P.S. The issue can be found here: https://bugs.freepascal.org/view.php?id=36507 On 03/01/2020 09:45, J. Gareth Moreton wrote: Hi everyone, So I reported this morning that Lazarus no longer builds as of r43826.  Ondrej was quick to update the Lazarus sources to allow it to build again and mar

[fpc-devel] A more fundamental problem Re: i36507

2020-01-03 Thread J. Gareth Moreton
Hi everyone, So I reported this morning that Lazarus no longer builds as of r43826.  Ondrej was quick to update the Lazarus sources to allow it to build again and marking the issue as fixed, but the underlying regression in the Free Pascal Compiler still exists. Basically, the compiler faile

Re: [fpc-devel] TEncoding.Default and default encoding for TStrings.LoadFrom*()

2020-01-03 Thread Michael Van Canneyt
On Fri, 3 Jan 2020, Ondrej Pokorny wrote: On 03.01.2020 00:35, Werner Pamler wrote: Am 02.01.2020 um 20:10 schrieb Ondrej Pokorny: TStrings.SaveTo*() writes BOM by default. Formerly the BOM was not written. There is also the problem that currently it is not possible, without further actio

Re: [fpc-devel] TEncoding.Default and default encoding for TStrings.LoadFrom*()

2020-01-03 Thread Ondrej Pokorny
On 03.01.2020 00:35, Werner Pamler wrote: Am 02.01.2020 um 20:10 schrieb Ondrej Pokorny: TStrings.SaveTo*() writes BOM by default. Formerly the BOM was not written. There is also the problem that currently it is not possible, without further action, to retain the BOM state of a file loaded in

Re: [fpc-devel] Make all fails after revision 43841 (Ondrej)

2020-01-03 Thread Bart via fpc-devel
On Fri, Jan 3, 2020 at 7:47 AM Sven Barth via fpc-devel wrote: >> Isn't make clean or make distclean supposed to take care of that? >> (Neither of them do) > > I think if you call "make clean" or "make distclean" a second time the fpmake > binaries will be cleaned up as well. No, it doesn't (th