Re: [fpc-devel] "inline" issue

2019-04-26 Thread J. Gareth Moreton
Well the issue listed fixes the problems I found in the compiler, RTL and the packages that are built.  Basically anything that returned an error with my modified code (which demanded that "inline" cannot appear in the implementation section by itself, so much more strict) - I'm not sure if the

Re: [fpc-devel] "inline" issue

2019-04-26 Thread Sven Barth via fpc-devel
Am 26.04.2019 um 22:41 schrieb J. Gareth Moreton: On 26/04/2019 21:29, Sven Barth via fpc-devel wrote: ... You did read what Jonas said in the bug report? Adding "inline" in the implementation section for the interface section would need to lead to a change of the interface CRC which is a no-

Re: [fpc-devel] "inline" issue

2019-04-26 Thread J. Gareth Moreton
On 26/04/2019 21:29, Sven Barth via fpc-devel wrote: ... You did read what Jonas said in the bug report? Adding "inline" in the implementation section for the interface section would need to lead to a change of the interface CRC which is a no-go once the interface section has been handled (an

Re: [fpc-devel] "inline" issue

2019-04-26 Thread Sven Barth via fpc-devel
Am 26.04.2019 um 18:29 schrieb J. Gareth Moreton: That's good to know - thanks Sven. This might be a silly question, but what error messages do you get if you put "inline" in a method's implementation etc? I'm wondering if I should develop a patch that ensures the conformance for inline matche

Re: [fpc-devel] "inline" issue

2019-04-26 Thread J. Gareth Moreton
That's good to know - thanks Sven. This might be a silly question, but what error messages do you get if you put "inline" in a method's implementation etc? I'm wondering if I should develop a patch that ensures the conformance for inline matches in {$MODE DELPHI}. For FPC, I would personally

Re: [fpc-devel] "inline" issue

2019-04-26 Thread Sven Barth via fpc-devel
Am 23.04.2019 um 16:33 schrieb Marco van de Voort: Op 4/23/2019 om 4:31 PM schreef J. Gareth Moreton: I should ask actually... what's Delphi's support on 'inline' appearing just in the implementation section? My guess: only inline locally in the implemenation, iow the function is exported

Re: [fpc-devel] "inline" issue

2019-04-23 Thread Marco van de Voort
Op 4/23/2019 om 4:31 PM schreef J. Gareth Moreton: I should ask actually... what's Delphi's support on 'inline' appearing just in the implementation section? My guess: only inline locally in the implemenation, iow the function is exported non-inline. _

Re: [fpc-devel] "inline" issue

2019-04-23 Thread J. Gareth Moreton
I should ask actually... what's Delphi's support on 'inline' appearing just in the implementation section? Given how many units have "inline" in just the implementation section, and how some cross-platform units have "inline" on platforms that benefit from it on their particular implementation

[fpc-devel] "inline" issue

2019-04-22 Thread J. Gareth Moreton
Hi everyone, Jonas and I were talking today through e-mail and he mentioned on #35346 the following interesting point: "An inline directive in the implementation but not in the interface should be rejected by the compiler, because it changes the interface crc. I know it does not do that current