Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Michael Van Canneyt
On Thu, 26 Oct 2006, Graeme Geldenhuys wrote: > Hi > > Thanks for that, I didn't know about that function. Attached is the > patch using the new StringOfChar. > > Incidently the speed increase is not much, but yes it is faster. > Maybe my test cases are just not big enough. ;-) > I did 4 te

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Dean Zobec
Graeme Geldenhuys ha scritto: > Hi > > Thanks for that, I didn't know about that function. Attached is the > patch using the new StringOfChar. > > Incidently the speed increase is not much, but yes it is faster. > Maybe my test cases are just not big enough. ;-) > I did 4 test runs with the ol

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Graeme Geldenhuys
Hi Thanks for that, I didn't know about that function. Attached is the patch using the new StringOfChar. Incidently the speed increase is not much, but yes it is faster. Maybe my test cases are just not big enough. ;-) I did 4 test runs with the old trSpace function and did 4 test runs with t

Re[2]: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Sergei Gorelkin
Thursday, October 26, 2006, 3:47:37 PM, Micha Nelissen wrote: MN> Graeme Geldenhuys wrote: >> +begin >> + sString := ''; >> + for i := 1 to pIntLen do >> +sString := sString + ' '; >> + Result := sString; >> +end; MN> I object to the inefficiency of this implementation. Isn't there a MN>

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Michael Van Canneyt
On Thu, 26 Oct 2006, Darius Blaszijk wrote: > DupeString Far less efficient, because for strings. StringOfChar is optimized for characters. Michael. ___ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listin

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Darius Blaszijk
DupeString - Original Message - From: "Micha Nelissen" <[EMAIL PROTECTED]> To: "FPC developers' list" Sent: Thursday, October 26, 2006 1:47 PM Subject: Re: [fpc-devel] [patch] - fpcUnit testreport.pp Graeme Geldenhuys wrote: +begin + sString :=

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Michael Van Canneyt
On Thu, 26 Oct 2006, Micha Nelissen wrote: > Graeme Geldenhuys wrote: > > +begin > > + sString := ''; > > + for i := 1 to pIntLen do > > +sString := sString + ' '; > > + Result := sString; > > +end; > > I object to the inefficiency of this implementation. Isn't there a routine in > syste

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Micha Nelissen
Graeme Geldenhuys wrote: +begin + sString := ''; + for i := 1 to pIntLen do +sString := sString + ' '; + Result := sString; +end; I object to the inefficiency of this implementation. Isn't there a routine in system to generate a string of X characters ? Micha _

Re: [fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Michael Van Canneyt
On Thu, 26 Oct 2006, Graeme Geldenhuys wrote: > Hi, > > Attached is a patch for testreport.pp (part of fpcUnit) that corrects > indentation of XML output listing all available test casses. > > Patch needs to be applied from the root FPC 2.1.1 directory. Thank you, applied the patch. Michael.

[fpc-devel] [patch] - fpcUnit testreport.pp

2006-10-26 Thread Graeme Geldenhuys
Hi, Attached is a patch for testreport.pp (part of fpcUnit) that corrects indentation of XML output listing all available test casses. Patch needs to be applied from the root FPC 2.1.1 directory. Regards, - Graeme - -- There's no place like 127.0.0.1 Index: fcl/fpcunit/testreport.pp