Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-30 Thread Martin Schreiber
On Sunday 30 April 2006 13.20, Joost van der Sluis wrote: > > Inserted records are displayed *after* the current record if the current > > record is at end of buffer! > > I think i've fixed this in revision 3381. But this influences all > TDataset descendents. Can you have a look at it? > It seems

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-30 Thread Joost van der Sluis
On Thu, 2006-04-27 at 17:18 +0200, Martin Schreiber wrote: > On Wednesday 26 April 2006 00.43, Joost van der Sluis wrote: > > Keep me informed. > > Ik you find something that doesn't sound logical to you, just say so. > dataset.inc: > > Procedure TDataset.DoInsertAppend(DoAppend : Boolean); > p

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-29 Thread Joost van der Sluis
On Thu, 2006-04-27 at 12:57 +0200, Martin Schreiber wrote: > On Wednesday 26 April 2006 00.43, Joost van der Sluis wrote: > > > > Keep me informed. > > Ik you find something that doesn't sound logical to you, just say so. > > > One problem is in internalfirst. > > Old: > procedure TBufDataset.Inte

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-27 Thread Martin Schreiber
On Wednesday 26 April 2006 00.43, Joost van der Sluis wrote: > Keep me informed. > Ik you find something that doesn't sound logical to you, just say so. dataset.inc: Procedure TDataset.DoInsertAppend(DoAppend : Boolean); procedure DoInsert; [...] if FActiveRecord < FRecordCount-1 then <<

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-27 Thread Martin Schreiber
On Wednesday 26 April 2006 00.43, Joost van der Sluis wrote: > > Keep me informed. > Ik you find something that doesn't sound logical to you, just say so. > One problem is in internalfirst. Old: procedure TBufDataset.InternalFirst; begin FBCurrentRecord := -1; FIsEOF := false; end; New: proce

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-25 Thread Joost van der Sluis
On Tue, 2006-04-25 at 18:45 +0200, Martin Schreiber wrote: > On Tuesday 25 April 2006 17.20, Michael Van Canneyt wrote: > > On Tue, 25 Apr 2006, Martin Schreiber wrote: > > > More exact formulation: > > > > > > TSQLQuery.Last; > > > TSQLQuery.Insert; > > > TSQLQuery.Post; > > > > > > The new record

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-25 Thread Martin Schreiber
On Tuesday 25 April 2006 17.20, Michael Van Canneyt wrote: > On Tue, 25 Apr 2006, Martin Schreiber wrote: > > More exact formulation: > > > > TSQLQuery.Last; > > TSQLQuery.Insert; > > TSQLQuery.Post; > > > > The new record is not the last record. > > That is correct. It should be the last-but-one.

Re: [fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-25 Thread Michael Van Canneyt
On Tue, 25 Apr 2006, Martin Schreiber wrote: More exact formulation: TSQLQuery.Last; TSQLQuery.Insert; TSQLQuery.Post; The new record is not the last record. That is correct. It should be the last-but-one. Michael. ___ fpc-devel maillist - fpc

[fpc-devel] Bug 5049: Record insert at eof in TSQLQuery

2006-04-25 Thread Martin Schreiber
More exact formulation: TSQLQuery.Last; TSQLQuery.Insert; TSQLQuery.Post; The new record is not the last record. It is at the same position as if TSQLQuery.Last; TSQLQuery.Prior; TSQLQuery.Insert; TSQLQuery.Post; Martin ___ fpc-devel maillist - fpc-