Re: [fpc-devel] DOM patch

2009-08-28 Thread Dariusz Mazur
Michael Van Canneyt pisze: On Thu, 27 Aug 2009, Michael Van Canneyt wrote: On Thu, 27 Aug 2009, Dariusz Mazur wrote: Hi I use DOM from fcl-xml both for Delphi and FPC development. I work with older version, till I notice serious bugs. Today i've upgrade it from current svn. And

Re: [fpc-devel] DOM patch

2009-08-28 Thread Dariusz Mazur
- Using PtrInt for doing pointer math is discouraged in favor of PtrUInt; I've changed PtrInt do PtrUInt, but its not possible in each place how to resolve tClass= tClass(PtrUInt +ptrInt) FPC claim: combined unsigned and signed make result 64bit, which is incompatible with pointer

Re: [fpc-devel] DOM patch

2009-08-28 Thread Jonas Maebe
On 28 Aug 2009, at 13:10, Dariusz Mazur wrote: - Using PtrInt for doing pointer math is discouraged in favor of PtrUInt; I've changed PtrInt do PtrUInt, but its not possible in each place how to resolve tClass= tClass(PtrUInt +ptrInt) FPC claim: combined unsigned and signed make result

Re: [fpc-devel] DOM patch

2009-08-28 Thread Dariusz Mazur
Jonas Maebe pisze: On 28 Aug 2009, at 13:10, Dariusz Mazur wrote: - Using PtrInt for doing pointer math is discouraged in favor of PtrUInt; I've changed PtrInt do PtrUInt, but its not possible in each place how to resolve tClass= tClass(PtrUInt +ptrInt) FPC claim: combined unsigned and

Re: [fpc-devel] DOM patch

2009-08-28 Thread Sergei Gorelkin
Dariusz Mazur wrote: Michael Van Canneyt pisze: On Thu, 27 Aug 2009, Michael Van Canneyt wrote: On Thu, 27 Aug 2009, Dariusz Mazur wrote: Hi I use DOM from fcl-xml both for Delphi and FPC development. I work with older version, till I notice serious bugs. Today i've upgrade it from

[fpc-devel] DOM patch

2009-08-27 Thread Dariusz Mazur
Hi I use DOM from fcl-xml both for Delphi and FPC development. I work with older version, till I notice serious bugs. Today i've upgrade it from current svn. And problem: Delphi don't compile I've made several changes in dom, xmlutil. Diff attached. As i expect, bugs in new version

Re: [fpc-devel] DOM patch

2009-08-27 Thread Michael Van Canneyt
On Thu, 27 Aug 2009, Dariusz Mazur wrote: Hi I use DOM from fcl-xml both for Delphi and FPC development. I work with older version, till I notice serious bugs. Today i've upgrade it from current svn. And problem: Delphi don't compile I've made several changes in dom, xmlutil. Diff

Re: [fpc-devel] DOM patch

2009-08-27 Thread Marco van de Voort
In our previous episode, Michael Van Canneyt said: As i expect, bugs in new version disappear. It's not change much. Can someone review it? Reviewed and applied. Thanks ! I also use parts of fcl-xml under Delphi, and also some fpimage parts. Since D2009, a lot less patches are

Re: [fpc-devel] DOM patch

2009-08-27 Thread Michael Van Canneyt
On Thu, 27 Aug 2009, Michael Van Canneyt wrote: On Thu, 27 Aug 2009, Dariusz Mazur wrote: Hi I use DOM from fcl-xml both for Delphi and FPC development. I work with older version, till I notice serious bugs. Today i've upgrade it from current svn. And problem: Delphi don't compile

Re: [fpc-devel] DOM patch

2009-08-27 Thread Sergei Gorelkin
Michael Van Canneyt wrote: Hm. Something strange with compilation. I reversed the patch, because xmlutils.pp does not compile with the patch. Strange that I didn't notice the first time I called make ? Could you look at FPC compilation and make a new patch ? To my knowledge, - To make it