Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-11 Thread Marco van de Voort
In our previous episode, Sergei Gorelkin said: Vincent, what command(s) did you use to get that log? What options were used when compiling the packages? ... forget that. The bug hunted down and fixed in r13824. It was indeed uninitialized memory, but something bad could happen only

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-09 Thread Sergei Gorelkin
Sergei Gorelkin wrote: Sergei Gorelkin wrote: Vincent Snijders wrote: I admit these are mere hints at a possible bug, but if I were maintainer of that code, I would take another look at it. I will :-) Vincent, what command(s) did you use to get that log? What options were used when

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-08 Thread Vincent Snijders
Vincent Snijders schreef: Vincent Snijders schreef: While running valgrind on fpcdoc, I got a warning in Maybe you are interested in the valgind output. See attachment. Another problem, that was also in the valgrind output (reading uninitialized memory): EAccessViolation : Access

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-08 Thread Marco van de Voort
In our previous episode, Vincent Snijders said: Vincent Snijders schreef: While running valgrind on fpcdoc, I got a warning in Maybe you are interested in the valgind output. See attachment. Another problem, that was also in the valgrind output (reading uninitialized memory):

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-08 Thread Vincent Snijders
Marco van de Voort schreef: In our previous episode, Vincent Snijders said: Vincent Snijders schreef: While running valgrind on fpcdoc, I got a warning in Maybe you are interested in the valgind output. See attachment. Another problem, that was also in the valgrind output (reading

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-08 Thread Sergei Gorelkin
Vincent Snijders wrote: I admit these are mere hints at a possible bug, but if I were maintainer of that code, I would take another look at it. I will :-) Sergei ___ fpc-devel maillist - fpc-devel@lists.freepascal.org

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-08 Thread Sergei Gorelkin
Sergei Gorelkin wrote: Vincent Snijders wrote: I admit these are mere hints at a possible bug, but if I were maintainer of that code, I would take another look at it. I will :-) Vincent, what command(s) did you use to get that log? What options were used when compiling the packages?

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-07 Thread Vincent Snijders
Sergei Gorelkin schreef: Vincent Snijders wrote: Vincent Snijders schreef: While running valgrind on fpcdoc, I got a warning in Maybe you are interested in the valgind output. See attachment. That check should be removed altogether, in both WideString and UnicodeString routines. I just

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-07 Thread Thaddy
About the naughty naughts: This is also the cause of many problems and the main cause of the ssl certificate hack: www.paypal.com\0filtyhacker.cr see ASN.1 and X509. PASCAL strings (with length before string) are for good reason part of many a specification... C strings are convienient, but

[fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-06 Thread Vincent Snijders
While running valgrind on fpcdoc, I got a warning in Procedure SetString (Out S : UnicodeString; Buf : PUnicodeChar; Len : SizeInt); It assumes that the Buf is null terminated, and tries to use that information to truncate the length. The ansistring version: Procedure SetString (Out S :

Re: [fpc-devel] SetString difference between Ansistring and UnicodeString

2009-10-06 Thread Sergei Gorelkin
Vincent Snijders wrote: Vincent Snijders schreef: While running valgrind on fpcdoc, I got a warning in Maybe you are interested in the valgind output. See attachment. That check should be removed altogether, in both WideString and UnicodeString routines. I just checked with Delphi, it