On Feb 10, 2009, at 6:55 AM, Calvin Hendryx-Parker wrote:
Hi Team,
hi calvin,
I just committed my revisions based on the initial review of PLIP 234.
thanks!
I believe I have addressed all of the concerns brought up by the
reviewers.
unfortunately i won't have enough time left to look
On Feb 12, 2009, at 1:05 PM, Andreas Zeidler wrote:
[...] i did notice that test (which is why i added almost in
almost none of the changes are actually tested ;)), but found that
one was far from enough. anyway, tom will make sure there are
enough now... ;)
that said i couldn't resist
On Feb 12, 2009, at 1:19 PM, Andreas Zeidler wrote:
of course the other case, i.e. having the nav-root _at_ the site
root like it is the default in plone, is already well-tested and not
the scope of this PLIP anyway. but i don't think many people have
actually used this feature before (as
On Feb 12, 2009, at 7:19 AM, Andreas Zeidler wrote:
of course the other case, i.e. having the nav-root _at_ the site
root like it is the default in plone, is already well-tested and not
the scope of this PLIP anyway. but i don't think many people have
actually used this feature before (as
On 12.02.2009, at 13:19, Andreas Zeidler wrote:
On Feb 12, 2009, at 1:05 PM, Andreas Zeidler wrote:
[...] i did notice that test (which is why i added almost in
almost none of the changes are actually tested ;)), but found
that one was far from enough. anyway, tom will make sure there are
On Feb 12, 2009, at 11:24 PM, Tom Lazar wrote:
Can I guarantee that it absolutely won't break anything? No. Am I
convinced that Plone is better
with this PLIP than without it? Yes :-)
:)
andi
--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin -
thanks, calvin!
i'll take a look at it ASAP, which probably will mean saturday,
though...
also thanks for the changeset url, that kind of stuff is really
helpful for reviewers (*hint* *hint* to other list members ;-)
cheers,
tom
On 10.02.2009, at 06:55, Calvin Hendryx-Parker wrote:
On Feb 8, 2009, at 5:17 PM, Tom Lazar wrote:
it would be great, though, if you could deliver the final version
before wednesday, then i could review it on the last day of the
berlinale-sprint here, after that i will be really busy with
catching up on stuff.
+1. i won't be able to review
absolutely fine by me.
it would be great, though, if you could deliver the final version
before wednesday, then i could review it on the last day of the
berlinale-sprint here, after that i will be really busy with catching
up on stuff.
cheers,
tom
On 08.02.2009, at 07:24, Calvin
On Feb 8, 2009, at 7:24 AM, Calvin Hendryx-Parker wrote:
I have addressed most of the issues in the review of my PLIP, but I
have a couple more tests in addition to the ones I have added that
I'd like to include before the final review is made. I'd very much
appreciate it if I could have
Hi All,
I have addressed most of the issues in the review of my PLIP, but I
have a couple more tests in addition to the ones I have added that I'd
like to include before the final review is made. I'd very much
appreciate it if I could have another day to include these so I can be
sure
11 matches
Mail list logo
