On Jan 17, 2009, at 12:04 AM, Andrew Burkhalter wrote:
PLIP 240 (Improve locking configurability) has been implemented. You
can get the review buildout from:
https://svn.plone.org/svn/plone/review/plip240-locking-improvements/
i've added my review notes in http://dev.plone.org/plone/changeset/
Erik Rose wrote:
I actually first implemented it exactly that way (even called it
IRefreshableLockable), then wondered if the complexity was worth it.
I can go either way, but would like to hear some other opinions of
best practice in a case like this.
For what a non-3.x-FWT opinion is worth
Ok, I reviewed this plip and did some tests with ttw locking and
indeed it seems to work. I leave all the technical review stuff to
people with brains.
I have a remark for the help text below "Enable locking for through-
the-web edits" though. I think that the line "Disabling locking here
wi
On Tue, Jan 27, 2009 at 18:12, Erik Rose wrote:
>> I actually first implemented it exactly that way (even called it
>> IRefreshableLockable), then wondered if the complexity was worth it. I can
>> go either way, but would like to hear some other opinions of best practice
>> in a case like this.
>
I actually first implemented it exactly that way (even called it
IRefreshableLockable), then wondered if the complexity was worth
it. I can go either way, but would like to hear some other opinions
of best practice in a case like this.
For what a non-3.x-FWT opinion is worth, I'd rather pr
On Jan 25, 2009, at 4:09 AM, Martijn Pieters wrote:
On Sat, Jan 17, 2009 at 00:04, Andrew Burkhalter
wrote:
PLIP 240 (Improve locking configurability) has been implemented. You
can get the review buildout from:
https://svn.plone.org/svn/plone/review/plip240-locking-improvements/
This PLIP g
On Sat, Jan 17, 2009 at 00:04, Andrew Burkhalter
wrote:
> PLIP 240 (Improve locking configurability) has been implemented. You
> can get the review buildout from:
> https://svn.plone.org/svn/plone/review/plip240-locking-improvements/
This PLIP gets a +1 from me.
I've looked at the code changes
David Glick wrote:
[..]
Hey, just wanted to note that Andrew and I investigated this,
discovered it was due to a previously existing bug in the
unlockOnFormUnload.js script, and implemented a fix in the branch for
PLIP #240. In the process we also discovered a related bug which
results in it
On Jan 16, 2009, at 3:04 PM, Andrew Burkhalter wrote:
Other
-
There is a weird edge case in the following scenario:
1. Manager turns off locking.
2. User A starts editing a document
3. Manager turns locking back on
4. User A clicks the edit tab again
5. User B views the document
The docum
PLIP 240 (Improve locking configurability) has been implemented. You
can get the review buildout from:
https://svn.plone.org/svn/plone/review/plip240-locking-improvements/
I'm going to paste the contents of
https://svn.plone.org/svn/plone/review/plip240-locking-improvements/PLIP_240_README.txt
be
10 matches
Mail list logo
