Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-20 Thread Warner Losh
On Apr 19, 2011, at 2:24 PM, Brandon Gooch wrote: > On Tue, Apr 19, 2011 at 3:02 PM, Warner Losh wrote: >> Having chased boogiemen in this area before, I think this patch makes good >> sense even though it breaks the device model a little. However, the >> hardware in question really is specia

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Jung-uk Kim
On Tuesday 19 April 2011 05:27 pm, Brandon Gooch wrote: > On Tue, Apr 19, 2011 at 4:02 PM, Jung-uk Kim wrote: > > On Tuesday 19 April 2011 04:55 pm, Brandon Gooch wrote: > >> On Tue, Apr 19, 2011 at 3:24 PM, Jung-uk Kim > > > > wrote: > >> > On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote:

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Brandon Gooch
On Tue, Apr 19, 2011 at 4:02 PM, Jung-uk Kim wrote: > On Tuesday 19 April 2011 04:55 pm, Brandon Gooch wrote: >> On Tue, Apr 19, 2011 at 3:24 PM, Jung-uk Kim > wrote: >> > On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote: >> >> Having chased boogiemen in this area before, I think this patch >

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Jung-uk Kim
On Tuesday 19 April 2011 04:55 pm, Brandon Gooch wrote: > On Tue, Apr 19, 2011 at 3:24 PM, Jung-uk Kim wrote: > > On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote: > >> Having chased boogiemen in this area before, I think this patch > >> makes good sense even though it breaks the device model

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Brandon Gooch
On Tue, Apr 19, 2011 at 3:24 PM, Jung-uk Kim wrote: > On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote: >> Having chased boogiemen in this area before, I think this patch >> makes good sense even though it breaks the device model a little. >> However, the hardware in question really is special

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Brandon Gooch
On Tue, Apr 19, 2011 at 3:02 PM, Warner Losh wrote: > Having chased boogiemen in this area before, I think this patch makes good > sense even though it breaks the device model a little.  However, the hardware > in question really is special on x86... > > Warner Sorry Warner, would you mind elab

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Jung-uk Kim
On Tuesday 19 April 2011 04:02 pm, Warner Losh wrote: > Having chased boogiemen in this area before, I think this patch > makes good sense even though it breaks the device model a little. > However, the hardware in question really is special on x86... Actually I was working on a similar patch and

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Warner Losh
Having chased boogiemen in this area before, I think this patch makes good sense even though it breaks the device model a little. However, the hardware in question really is special on x86... Warner On Apr 19, 2011, at 12:48 PM, Brandon Gooch wrote: > On Tue, Apr 19, 2011 at 10:46 AM, Taku Y

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Brandon Gooch
On Tue, Apr 19, 2011 at 10:46 AM, Taku YAMAMOTO wrote: > On Wed, 20 Apr 2011 00:31:33 +0900 > Taku YAMAMOTO wrote: > >> A patch is attached. > Mailman ate it ;) > Here it is. > > -- > -|-__   YAMAMOTO, Taku >  | __ <     > >      - A chicken is an egg's way of producing more eggs. - > Throughou

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Brandon Gooch
On Tue, Apr 19, 2011 at 10:31 AM, Taku YAMAMOTO wrote: > Hi all, > > > Now, thanks to jkim's work, we have power_suspend and power_resume > EVENTHANDLERs since r220647. > I think it's a good time to move scsuspend()/scresume() to that scheme, too. > > That is: >  * We can achieve definitive orderi

Re: [PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Taku YAMAMOTO
On Wed, 20 Apr 2011 00:31:33 +0900 Taku YAMAMOTO wrote: > A patch is attached. Mailman ate it ;) Here it is. -- -|-__ YAMAMOTO, Taku | __ < - A chicken is an egg's way of producing more eggs. - --- sys/dev/syscons/syscons.c.orig 2010-12-08 11:34:37.173729146 +0900 +++ sys/de

[PATCH] Move scsuspend()/scresume() forward to EVENTHANDLERs

2011-04-19 Thread Taku YAMAMOTO
Hi all, Now, thanks to jkim's work, we have power_suspend and power_resume EVENTHANDLERs since r220647. I think it's a good time to move scsuspend()/scresume() to that scheme, too. That is: * We can achieve definitive ordering between vga, drm and so on: no need to depend on scpm hackery wit