on 05/11/2010 05:57 Moore, Robert said the following:
> The problem is stale pointers within the structure, yes?
>
> Cannot copy the structure. I will never do this kind of thing again.
Yes, that was the problem with resource structs that have an
ACPI_RESOURCE_SOURCE field, that field would need
On Fri, 05 Nov 2010 16:14 -0400, "Jung-uk Kim" wrote:
> On Tuesday 12 October 2010 06:09 am, Hans Petter Selasky wrote:
> > Hi,
> >
> > My MacBookPro 5,1 does not boot using -current because memory
> > inside the ACPI kernel module is used after free.
On Friday 05 November 2010 04:14 pm, Jung-uk Kim wrote:
> On Tuesday 12 October 2010 06:09 am, Hans Petter Selasky wrote:
> > Hi,
> >
> > My MacBookPro 5,1 does not boot using -current because memory
> > inside the ACPI kernel module is used after free.
> >
On Tuesday 12 October 2010 06:09 am, Hans Petter Selasky wrote:
> Hi,
>
> My MacBookPro 5,1 does not boot using -current because memory
> inside the ACPI kernel module is used after free.
>
> The following patch temporily mitigates the problem:
>
> /usr/src/sys/dev/acpica/
gt;To: 'Hans Petter Selasky'; Jung-uk Kim; freebsd-acpi@freebsd.org
>Subject: RE: MacBookPro 5,1
>
>
>You cannot assume that a full memcpy has been performed on the structure
>when you invoke the equals operator.
>
>This is basic C
>
>
>
>
>
>>-
nt: Thursday, November 04, 2010 12:44 AM
>To: Jung-uk Kim; freebsd-acpi@freebsd.org
>Subject: Re: MacBookPro 5,1
>
>On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote:
>> > Hans,
>> >
>> > could you please test the following patch?
>> >
>> &
On Wednesday 03 November 2010 21:25:28 Jung-uk Kim wrote:
> On Wednesday 03 November 2010 01:51 pm, Jung-uk Kim wrote:
> > On Wednesday 03 November 2010 12:47 pm, John Baldwin wrote:
> > > On Wednesday, November 03, 2010 12:25:37 pm Jung-uk Kim wrote:
> > > > On Wednesday 03 November 2010 08:28 am,
On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote:
> > Hans,
> >
> > could you please test the following patch?
> >
> > diff --git a/sys/dev/acpica/acpi_pci_link.c
> > b/sys/dev/acpica/acpi_pci_link.c index dcf101d..e842635 100644
> > --- a/sys/dev/acpica/acpi_pci_link.c
> > +++ b/sys/dev/ac
ginal Message-
>From: owner-freebsd-a...@freebsd.org [mailto:owner-freebsd-
>a...@freebsd.org] On Behalf Of Jung-uk Kim
>Sent: Wednesday, November 03, 2010 1:50 PM
>To: freebsd-acpi@FreeBSD.org
>Cc: Andriy Gapon; Lin, Ming M; Moore, Robert
>Subject: Re: MacBookPro 5,1
>
>On Wedn
on 03/11/2010 22:49 Jung-uk Kim said the following:
> On Wednesday 03 November 2010 04:25 pm, Jung-uk Kim wrote:
>> Note I had to adjust resource length to prevent reading/writing
>> beyond buffer size. It should work okay for
>> acpi_pci_link_srs_from_links() case, I believe. It's a hack
>> anyw
On Wednesday 03 November 2010 04:25 pm, Jung-uk Kim wrote:
> Note I had to adjust resource length to prevent reading/writing
> beyond buffer size. It should work okay for
> acpi_pci_link_srs_from_links() case, I believe. It's a hack
> anyway. ;-)
I realized two MPASS() checks were removed accide
On Wednesday 03 November 2010 01:51 pm, Jung-uk Kim wrote:
> On Wednesday 03 November 2010 12:47 pm, John Baldwin wrote:
> > On Wednesday, November 03, 2010 12:25:37 pm Jung-uk Kim wrote:
> > > On Wednesday 03 November 2010 08:28 am, John Baldwin wrote:
> > > > On Tuesday, November 02, 2010 6:32:12
On Wednesday 03 November 2010 12:47 pm, John Baldwin wrote:
> On Wednesday, November 03, 2010 12:25:37 pm Jung-uk Kim wrote:
> > On Wednesday 03 November 2010 08:28 am, John Baldwin wrote:
> > > On Tuesday, November 02, 2010 6:32:12 pm Jung-uk Kim wrote:
> > > > On Tuesday 02 November 2010 05:26 pm
On Wednesday, November 03, 2010 12:25:37 pm Jung-uk Kim wrote:
> On Wednesday 03 November 2010 08:28 am, John Baldwin wrote:
> > On Tuesday, November 02, 2010 6:32:12 pm Jung-uk Kim wrote:
> > > On Tuesday 02 November 2010 05:26 pm, John Baldwin wrote:
> > > > On Tuesday, November 02, 2010 4:50:18
On Wednesday 03 November 2010 08:28 am, John Baldwin wrote:
> On Tuesday, November 02, 2010 6:32:12 pm Jung-uk Kim wrote:
> > On Tuesday 02 November 2010 05:26 pm, John Baldwin wrote:
> > > On Tuesday, November 02, 2010 4:50:18 pm Jung-uk Kim wrote:
> > > > On Tuesday 02 November 2010 04:24 pm, Joh
On Tuesday, November 02, 2010 6:32:12 pm Jung-uk Kim wrote:
> On Tuesday 02 November 2010 05:26 pm, John Baldwin wrote:
> > On Tuesday, November 02, 2010 4:50:18 pm Jung-uk Kim wrote:
> > > On Tuesday 02 November 2010 04:24 pm, John Baldwin wrote:
> > > > On Tuesday, November 02, 2010 4:14:05 pm Ju
On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote:
> On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > on 29/10/2010 08:51 Andriy Gapon said the following:
> > > I guess that a general problem here is that it is incorrect to
> > > merely use memcpy/bcopy to create a copy of a resou
On Tuesday 02 November 2010 05:50 pm, Andriy Gapon wrote:
> on 02/11/2010 22:50 Jung-uk Kim said the following:
> > Yes, I understand. However, ACPICA is expecting the same size of
> > buffer *including* the optional parts if I am reading the code
> > right.
>
> Hmm, where is ACPICA doing that?
I
On Tuesday 02 November 2010 05:26 pm, John Baldwin wrote:
> On Tuesday, November 02, 2010 4:50:18 pm Jung-uk Kim wrote:
> > On Tuesday 02 November 2010 04:24 pm, John Baldwin wrote:
> > > On Tuesday, November 02, 2010 4:14:05 pm Jung-uk Kim wrote:
> > > > On Tuesday 02 November 2010 03:41 pm, John
on 02/11/2010 22:50 Jung-uk Kim said the following:
> Yes, I understand. However, ACPICA is expecting the same size of
> buffer *including* the optional parts if I am reading the code right.
Hmm, where is ACPICA doing that?
I didn't see any connection between what *ACPICA* can return to OS in
On Tuesday, November 02, 2010 4:50:18 pm Jung-uk Kim wrote:
> On Tuesday 02 November 2010 04:24 pm, John Baldwin wrote:
> > On Tuesday, November 02, 2010 4:14:05 pm Jung-uk Kim wrote:
> > > On Tuesday 02 November 2010 03:41 pm, John Baldwin wrote:
> > > > On Tuesday, November 02, 2010 3:29:01 pm Ju
it.
>-Original Message-
>From: Jung-uk Kim [mailto:j...@freebsd.org]
>Sent: Tuesday, November 02, 2010 1:50 PM
>To: John Baldwin
>Cc: Andriy Gapon; Hans Petter Selasky; Lin, Ming M; Moore, Robert; freebsd-
>a...@freebsd.org
>Subject: Re: MacBookPro 5,1
>
>On Tue
On Tuesday 02 November 2010 04:24 pm, John Baldwin wrote:
> On Tuesday, November 02, 2010 4:14:05 pm Jung-uk Kim wrote:
> > On Tuesday 02 November 2010 03:41 pm, John Baldwin wrote:
> > > On Tuesday, November 02, 2010 3:29:01 pm Jung-uk Kim wrote:
> > > > On Tuesday 02 November 2010 11:29 am, Andri
On Tuesday, November 02, 2010 4:14:05 pm Jung-uk Kim wrote:
> On Tuesday 02 November 2010 03:41 pm, John Baldwin wrote:
> > On Tuesday, November 02, 2010 3:29:01 pm Jung-uk Kim wrote:
> > > On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > > > on 29/10/2010 08:51 Andriy Gapon said the f
On Tuesday 02 November 2010 03:41 pm, John Baldwin wrote:
> On Tuesday, November 02, 2010 3:29:01 pm Jung-uk Kim wrote:
> > On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > > on 29/10/2010 08:51 Andriy Gapon said the following:
> > > > I guess that a general problem here is that it is
On Tuesday, November 02, 2010 3:29:01 pm Jung-uk Kim wrote:
> On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> > on 29/10/2010 08:51 Andriy Gapon said the following:
> > > I guess that a general problem here is that it is incorrect to
> > > merely use memcpy/bcopy to create a copy of a r
On Tuesday 02 November 2010 11:29 am, Andriy Gapon wrote:
> on 29/10/2010 08:51 Andriy Gapon said the following:
> > I guess that a general problem here is that it is incorrect to
> > merely use memcpy/bcopy to create a copy of a resource if the
> > resource has ACPI_RESOURCE_SOURCE field in it.
>
on 29/10/2010 08:51 Andriy Gapon said the following:
> I guess that a general problem here is that it is incorrect to merely use
> memcpy/bcopy to create a copy of a resource if the resource has
> ACPI_RESOURCE_SOURCE field in it.
Hans,
could you please test the following patch?
diff --git a/sys
On Fri, 2010-10-29 at 13:19 +0800, Andriy Gapon wrote:
> on 29/10/2010 03:34 Lin Ming said the following:
> > Hi, guys
> >
> > Hans and I have found the root cause of this bug.
>
> I believe that there could be a root for a root :-)
I will continue to check this bug next Monday.
Hope we can find
on 29/10/2010 08:23 Andriy Gapon said the following:
> on 29/10/2010 08:19 Andriy Gapon said the following:
[snip]
>> l_prs_template is populated in link_add_prs() function, which called to walk
>> over resources returned by _PRS:
>> http://fxr.watson.org/fxr/source/dev/acpica/acpi_pci_link.c#L499
on 29/10/2010 08:19 Andriy Gapon said the following:
> on 29/10/2010 03:34 Lin Ming said the following:
>> Hi, guys
>>
>> Hans and I have found the root cause of this bug.
>
> I believe that there could be a root for a root :-)
>
>> The ResourceSource->StringLength set by up layer driver is wrong
on 29/10/2010 03:34 Lin Ming said the following:
> Hi, guys
>
> Hans and I have found the root cause of this bug.
I believe that there could be a root for a root :-)
> The ResourceSource->StringLength set by up layer driver is wrong, see the
> patch below.
>
> Below patch fixes the bug and on
On Fri, 2010-10-29 at 00:10 +0800, Hans Petter Selasky wrote:
> On Thursday 28 October 2010 17:24:32 Lin Ming wrote:
> > On Thu, 2010-10-28 at 23:05 +0800, Lin Ming wrote:
> > > On Thu, 2010-10-28 at 22:55 +0800, Hans Petter Selasky wrote:
> > > > On Thursday 28 October 2010 16:44:55 Lin Ming wrote
On Friday 22 October 2010 07:19:47 Lin Ming wrote:
> diff --git a/source/components/resources/rsxface.c
> b/source/components/resources/rsxface.c index 2a019d1..17b88e2 100644
> --- a/source/components/resources/rsxface.c
> +++ b/source/components/resources/rsxface.c
> @@ -394,6 +394,7 @@ AcpiSetCu
On Friday 22 October 2010 07:19:47 Lin Ming wrote:
> On Fri, 2010-10-22 at 10:39 +0800, Lin Ming wrote:
> > On Fri, 2010-10-22 at 04:57 +0800, Hans Petter Selasky wrote:
> > > Here is the relevant output. First note, the buffer length is 512 and
> > > (uint8_t)512 = 0, so I modified the code to pri
On Fri, 2010-10-22 at 10:39 +0800, Lin Ming wrote:
> On Fri, 2010-10-22 at 04:57 +0800, Hans Petter Selasky wrote:
> > Here is the relevant output. First note, the buffer length is 512 and
> > (uint8_t)512 = 0, so I modified the code to print out the 512 bytes.
> >
> >
> > Passed in resource bu
On Fri, 2010-10-22 at 04:57 +0800, Hans Petter Selasky wrote:
> On Thursday 21 October 2010 09:12:27 Lin Ming wrote:
> > On Thu, 2010-10-21 at 11:39 +0800, Lin Ming wrote:
> > > On Wed, 2010-10-20 at 16:06 +0800, Hans Petter Selasky wrote:
> > > > On Wednesday 20 October 2010 08:36:31 Lin Ming wrot
On Thursday 21 October 2010 09:12:27 Lin Ming wrote:
> On Thu, 2010-10-21 at 11:39 +0800, Lin Ming wrote:
> > On Wed, 2010-10-20 at 16:06 +0800, Hans Petter Selasky wrote:
> > > On Wednesday 20 October 2010 08:36:31 Lin Ming wrote:
> > > > On Wed, 2010-10-20 at 14:34 +0800, Hans Petter Selasky wrot
Hi,
I will get you the debug output from this patch in about 8 hours.
--HPS
On Thursday 21 October 2010 09:12:27 Lin Ming wrote:
>
> Hi,
>
> Could you apply below debug patch and attach the output?
> I'll try to reproduce this bug with the output.
>
> It will print something like below,
>
>
On Thu, 2010-10-21 at 11:39 +0800, Lin Ming wrote:
> On Wed, 2010-10-20 at 16:06 +0800, Hans Petter Selasky wrote:
> > On Wednesday 20 October 2010 08:36:31 Lin Ming wrote:
> > > On Wed, 2010-10-20 at 14:34 +0800, Hans Petter Selasky wrote:
> > > > On Tuesday 19 October 2010 07:47:02 Lin Ming wrote
On Wed, 2010-10-20 at 16:06 +0800, Hans Petter Selasky wrote:
> On Wednesday 20 October 2010 08:36:31 Lin Ming wrote:
> > On Wed, 2010-10-20 at 14:34 +0800, Hans Petter Selasky wrote:
> > > On Tuesday 19 October 2010 07:47:02 Lin Ming wrote:
> > > > On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Se
on 20/10/2010 11:06 Hans Petter Selasky said the following:
> During the function call that overwrites it's buffer, there are no more debug
> prints than shown in the code, even with all debug prints on. Where should I
> add more debug prints?
Maybe there are some useful messages right before th
On Wednesday 20 October 2010 08:36:31 Lin Ming wrote:
> On Wed, 2010-10-20 at 14:34 +0800, Hans Petter Selasky wrote:
> > On Tuesday 19 October 2010 07:47:02 Lin Ming wrote:
> > > On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
> > > > On Monday 18 October 2010 02:01:09 Moore, Robert
On Wednesday 20 October 2010 08:55:09 Andriy Gapon wrote:
> on 20/10/2010 09:34 Hans Petter Selasky said the following:
> > On Tuesday 19 October 2010 07:47:02 Lin Ming wrote:
> >> On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
> >>> On Monday 18 October 2010 02:01:09 Moore, Robert w
on 20/10/2010 09:34 Hans Petter Selasky said the following:
> On Tuesday 19 October 2010 07:47:02 Lin Ming wrote:
>> On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
>>> On Monday 18 October 2010 02:01:09 Moore, Robert wrote:
Can you send us the acpidump for the machine?
On Wed, 2010-10-20 at 14:34 +0800, Hans Petter Selasky wrote:
> On Tuesday 19 October 2010 07:47:02 Lin Ming wrote:
> > On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
> > > On Monday 18 October 2010 02:01:09 Moore, Robert wrote:
> > > > Can you send us the acpidump for the machine?
>
On Tuesday 19 October 2010 07:47:02 Lin Ming wrote:
> On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
> > On Monday 18 October 2010 02:01:09 Moore, Robert wrote:
> > > Can you send us the acpidump for the machine?
> > >
> > > Also, tell us which control method is failing.
> > >
> >
Just subscribed to list, so pardon my screwing up msg threading.
I would like to install FreeBSD on my MacBook Pro 5,5.
Attempting to install from DVD isos of -CURRENT and -STABLE snapshots
results in panic right after the initial menu. (I believe these
snapshots are 14 Oct or thereabouts - sorr
on 19/10/2010 08:47 Lin Ming said the following:
> On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
>> On Monday 18 October 2010 02:01:09 Moore, Robert wrote:
>>> Can you send us the acpidump for the machine?
>>>
>>> Also, tell us which control method is failing.
>>>
>>> Thanks
>>
>> H
on 18/10/2010 23:21 Hans Petter Selasky said the following:
> On Monday 18 October 2010 02:01:09 Moore, Robert wrote:
>> Can you send us the acpidump for the machine?
>>
>> Also, tell us which control method is failing.
>>
>> Thanks
>
> Hi,
>
> Please find attached dump of ACPI tables.
>
> It is
On Tue, 2010-10-19 at 04:21 +0800, Hans Petter Selasky wrote:
> On Monday 18 October 2010 02:01:09 Moore, Robert wrote:
> > Can you send us the acpidump for the machine?
> >
> > Also, tell us which control method is failing.
> >
> > Thanks
>
> Hi,
>
> Please find attached dump of ACPI tables.
>
>To: freebsd-acpi@freebsd.org
>Cc: linux-a...@vger.kernel.org
>Subject: Re: MacBookPro 5,1
>
>Hi,
>
>CC'ing the Linux guys, hence I belive you are using the same ACPI code like
>in
>FreeBSD.
>
>It appears that when a string is present in the extended interrupt
&g
ng to AML, is incorrect and that data
is written beyond the destination buffer!
The error is catched on a MacBookPro 5,1 and is visible if you zero-pad all
ACPI allocations to 4096 bytes, and verify that the freed buffer is not
written beyond the allocation. Also the Extended interrupt descriptor
Hi,
Some more debugging reveals that:
The Resource type is 15, which is:
ACPI_RSCONVERT_INFO AcpiRsConvertExtIrq[9] =
And that it fails on:
ACPI_RSC_SOURCEX
That means it writes beyond the 11 bytes reserved for this element!
During sub-routines of AcpiRsCreateAmlResources().
--HPS
On
Hi,
After debugging for some time now I've found the issue.
1) I extended all allocations from ACPI to PAGE_SIZE.
2) Then I filled the extra area with zero.
3) Then at free I checked if some buffers were overwritten, and indeed I got
bingo this time. The printout has the format:
printf("Dirty f
On Tuesday 12 October 2010 06:09 am, Hans Petter Selasky wrote:
> Hi,
>
> My MacBookPro 5,1 does not boot using -current because memory
> inside the ACPI kernel module is used after free.
>
> The following patch temporily mitigates the problem:
>
> /usr/src/sys/dev/acpica/
9 Hans Petter Selasky said the following:
>>>>> Hi,
>>>>>
>>>>> My MacBookPro 5,1 does not boot using -current because memory inside
>>>>> the ACPI kernel module is used after free.
>>>>>
>>>>> The following patc
On Tuesday 12 October 2010 22:43:46 Andriy Gapon wrote:
> on 12/10/2010 15:25 Hans Petter Selasky said the following:
> > On Tuesday 12 October 2010 13:15:26 Andriy Gapon wrote:
> >> on 12/10/2010 13:09 Hans Petter Selasky said the following:
> >>> Hi,
> >>&
on 12/10/2010 15:25 Hans Petter Selasky said the following:
> On Tuesday 12 October 2010 13:15:26 Andriy Gapon wrote:
>> on 12/10/2010 13:09 Hans Petter Selasky said the following:
>>> Hi,
>>>
>>> My MacBookPro 5,1 does not boot using -current because memory
On Tuesday 12 October 2010 13:15:26 Andriy Gapon wrote:
> on 12/10/2010 13:09 Hans Petter Selasky said the following:
> > Hi,
> >
> > My MacBookPro 5,1 does not boot using -current because memory inside the
> > ACPI kernel module is used after free.
> >
on 12/10/2010 13:09 Hans Petter Selasky said the following:
> Hi,
>
> My MacBookPro 5,1 does not boot using -current because memory inside the ACPI
> kernel module is used after free.
>
> The following patch temporily mitigates the problem:
>
> /usr/src/sys/dev/acpica/O
Hi,
My MacBookPro 5,1 does not boot using -current because memory inside the ACPI
kernel module is used after free.
The following patch temporily mitigates the problem:
/usr/src/sys/dev/acpica/Osd/OsdMemory.c
void
AcpiOsFree(void *Memory)
{
+ if (cold == 0)
free(Memory, M_ACPICA);
}
Is
62 matches
Mail list logo
