https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #12 from Jose Luis Duran ---
The patch has been committed upstream.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #11 from Jose Luis Duran ---
I decided to propose this patch upstream:
https://github.com/zoulasc/blocklist/pull/8
More than committing the patch itself, I'm interested to hear the comments from
the author.
Thank you!
--
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
Jose Luis Duran changed:
What|Removed |Added
CC||jldu...@gmail.com
--- Comment
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #9 from Conrad Meyer ---
Should be fixed, not just documented. :-(
If you have any other examples you know of, we can do small one-off fixes for
these and then later think about a rearchitected config layer.
--
You are
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #8 from Helge Oldach ---
(In reply to Conrad Meyer from comment #7)
> I'm also not exactly in love with the custom file format (with ad-hoc
> C parser and no formal grammar)
Yes, and there are also potential bugs in that
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #7 from Conrad Meyer ---
(In reply to Helge Oldach from comment #6)
Thanks for testing it out.
> So it's not a documentation error as I was thinking but indeed a bug.
Yep. Nice find!
> What I still don't understand however
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #6 from Helge Oldach ---
(In reply to Conrad Meyer from comment #4)
> Helge, does this fix the issue?
Yes it does; we are now seeing a mismatch in case the source and [remote]
addresses are different:
Jan 8 06:06:57 latitude
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #5 from Helge Oldach ---
(In reply to Conrad Meyer from comment #3)
> // Above is definitely wrong, only compares the first 1/4 of the address
> // bytes. Maybe that's what we're seeing?
Indeed. That matches with a real-life
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #4 from Conrad Meyer ---
Helge, does this fix the issue?
--- a/contrib/blacklist/bin/conf.c
+++ b/contrib/blacklist/bin/conf.c
@@ -466,7 +466,6 @@ conf_amask_eq(const void *v1, const void *v2, size_t len,
int mask)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #3 from Conrad Meyer ---
Ah. I wonder if this is it?
459 #define MASK(m) ((uint32_t)~((1 << (32 - (m))) - 1))
460
461 static int
462 conf_amask_eq(const void *v1, const void *v2, size_t len, int mask)
463 {
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
Conrad Meyer changed:
What|Removed |Added
CC||c...@freebsd.org
--- Comment #2
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
--- Comment #1 from Ed Maste ---
(In reply to Helge Oldach from comment #0)
Indeed, the changes in D22259 are quite minor and I wouldn't expect to see a
difference here. Will try to take a look.
--
You are receiving this mail because:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
Bug ID: 243164
Summary: blacklistd not handling masks correctly
Product: Base System
Version: 12.1-STABLE
Hardware: Any
OS: Any
Status: New
13 matches
Mail list logo
