On Wed, 31 Jul 2024 at 21:52, Kyle Evans <kev...@freebsd.org> wrote: > On 7/31/24 14:31, Gleb Smirnoff wrote: > > On Tue, Jul 30, 2024 at 05:05:33PM -0500, Kyle Evans wrote: > > K> > > commit ce220b82ad546d3518a805750e5ee6add73f1fbf > > K> > > Author: Alfonso Siciliano <alf.sicili...@gmail.com> > > K> > > Date: Sat May 25 02:42:46 2024 +0200 > > K> > > > > K> > > change: --form and --mixedgauge do not print field input to > output if <fi > > K> > > eldlen> <= 0 > > K> > > > > K> > > > > K> > > That means if you have any scripting using 'bsddialog --form' > with readonly > > K> > > values, you would need to adjust your scripts, otherwise your > variables would > > K> > > be messed up, leading to any possible kind of bugs. > > K> > > > K> > I can't find this revision. > > K> > > > K> > slippy$ git log ce220b82ad546d3518a805750e5ee6add73f1fbf > > K> > fatal: bad object ce220b82ad546d3518a805750e5ee6add73f1fbf > > K> > slippy$ > > K> > > > K> > To verify that my repo wasn't damaged in any way I cloned a fresh > new repo > > K> > from git.freebsd.org. I still can't list that revision. > > K> > > > K> > > K> It's a bsddialog commit, since the full history isn't preserved in > vendor > > K> imports for bsddialog > > K> > > K> > https://gitlab.com/alfix/bsddialog/-/commit/ce220b82ad546d3518a805750e5ee6add73f1fbf > > > > btw, I'd suggest to switch to subtree merges for future bsddialog > imports, so > > that full commit history is preserved. I can help with that, if needed. > > > > Sorry, to be a bit pedantic: the way it's managed now is still a subtree > merge, the difference is what's in the vendor branch that's merged in > (full history vs. release diffs). > > > Can you please ack that POLA breakage will be noted in the Release Notes > of > > 15.0 and won't be merged to 14.x? > > > I don't maintain bsddialog imports, just the one that fixed an immediate > issue for the work I was doing, but Alfonso noted in response to a > private e-mail thread you started that he'll do both. He hasn't yet > responded to current@ as stated in that e-mail, though, AFAICT. > >
Thank you for the testing and the report, Of course I' ll add an entry to src/RELNOTES, new bsddialog shall not be merged to 14.0. Anyway, this change is not related to bsddialog 1.0.4 and to the recent kevans' import. I changed --form outputs in bsddialog 1.0.2 and 1.0.3, imported in CURRENT May 2024. I changed to restore the "old" (LGPL) dialog(1) behavior to avoid bsdinstall-networking-scripts faults (we have a discussion in current@ "bsdinstall wifi setup is broken on CURRENT" and some review). It is not a "full history" but I wrote rationale and FreeBSD notes in the commit messages: https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.3 https://cgit.freebsd.org/src/tag/?h=vendor/bsddialog/1.0.2 Also I maintain a CHANGELOG, src/contrib/bsddialog/CHANGELOG. Alfonso
