Re: FYI: ^T use during poudriere bulk vs. /bin/sh operation: I got a "Unsafe ckmalloc() call" Abort trap that left a mess

2023-09-05 Thread Jilles Tjoelker
l use, so it must be something special in some way. -- Jilles Tjoelker

Re: should a copy_file_range(2) syscall be interrupted via a signal

2019-07-05 Thread Jilles Tjoelker
his to 0. With this, the system call can be restarted automatically after a signal. In any case, [EINTR] and the internal ERESTART must not be returned unless it is safe to repeat the call with the same (direct) arguments. -- Jilles Tjoelker _

Re: A reliable port cross-build failure (hangup) in my context (amd64->armv7 cross build, with native-tool speedup involved)

2019-01-05 Thread Jilles Tjoelker
es, this is the extreme > error prone approach. We should convert this to script generated code, > including guest syscalls definition. Definitions of system calls are in syscalls.master and should be automatically processable; definitions of types are in header files and cannot really b

Re: FYI: devel/kyua 14 failures for head -r338518M based build in a Pine64+ 2GB (aarch64 / cortexA53 / A64) context

2018-09-16 Thread Jilles Tjoelker
On Sun, Sep 16, 2018 at 01:21:33PM -0700, Mark Millard wrote: > On 2018-Sep-16, at 10:50 AM, Jilles Tjoelker wrote: > > On another note, the comment just below that, > >/* But we need to zero-extend (char is unsigned) the value and then > > perform a sign

Re: FYI: devel/kyua 14 failures for head -r338518M based build in a Pine64+ 2GB (aarch64 / cortexA53 / A64) context

2018-09-16 Thread Jilles Tjoelker
rong reason for doing the right thing since memcmp (as well as strcmp and strncmp) are defined to compare based on unsigned chars, regardless of the signedness of char. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd

Re: Getting PID of socket client

2017-07-09 Thread Jilles Tjoelker
e implementation of the future more secure world would be per-application UIDs a la Android. Another one would be Capsicum-sandboxed applications where applications receive their Wayland sockets pre-connected by code that tells the Wayland server the application identity. -- Jilles Tjoelker __

Re: Getting PID of socket client

2017-07-09 Thread Jilles Tjoelker
ser to hold onto process slots for RLIMIT_NPROC. The only solution would be to add variants of the necessary calls that take a process descriptor instead of a process ID. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/

Re: 64-bit inodes (ino64) Status Update and Call for Testing

2017-05-21 Thread Jilles Tjoelker
On Sun, May 21, 2017 at 05:25:35PM +0300, Konstantin Belousov wrote: > On Sun, May 21, 2017 at 04:03:55PM +0200, Jilles Tjoelker wrote: > > On Sun, May 21, 2017 at 03:31:18PM +0300, Konstantin Belousov wrote: > > > On Sun, May 21, 2017 at 02:14:56PM +0200, Jilles Tjoelker wrot

Re: 64-bit inodes (ino64) Status Update and Call for Testing

2017-05-21 Thread Jilles Tjoelker
On Sun, May 21, 2017 at 03:31:18PM +0300, Konstantin Belousov wrote: > On Sun, May 21, 2017 at 02:14:56PM +0200, Jilles Tjoelker wrote: > > We have another type in this area which is too small in some situations: > > uint8_t for struct dirent.d_namlen. For filesystems that store f

Re: 64-bit inodes (ino64) Status Update and Call for Testing

2017-05-21 Thread Jilles Tjoelker
plications using the deprecated readdir_r() will not be able to read such long names, since the API does not allow specifying that a larger buffer has been provided. (This could be avoided by making struct dirent.d_name 766 bytes long instead of 256.) Unfortunately, the existence of read

Re: r314708: panic: tdsendsignal: ksi on queue

2017-03-09 Thread Jilles Tjoelker
depending on how many signals are pending) in this situation and document that reapers must use WAIT_ANY or P_ALL. (However, compared to the pre-r309886 situation they can still use SIGCHLD to get notified when to call waitpid() or similar.) -- Jilles Tjoelker

Re: Fix /etc/rc.d/random umask handling (/entropy permissions)

2017-01-23 Thread Jilles Tjoelker
On Mon, Jan 23, 2017 at 10:52:21AM -0800, Simon J. Gerraty wrote: > Jilles Tjoelker wrote: > > Index: etc/rc.d/random > > === > > --- etc/rc.d/random (revision 311446) > > +++ etc/rc.d/random (working

Re: Fix /etc/rc.d/random umask handling (/entropy permissions)

2017-01-22 Thread Jilles Tjoelker
On Sun, Jan 22, 2017 at 01:22:07AM +, Lu Tung-Pin wrote: > On 2017-01-21 22:01, Jilles Tjoelker wrote: > > [Adding Cc: Dag-Erling Smørgrav who committed r273957 which seems to > > have introduced this] > > On Sat, Jan 21, 2017 at 01:21:42AM +, Lu Tung-Pin wrote: >

Re: Fix /etc/rc.d/random umask handling (/entropy permissions)

2017-01-21 Thread Jilles Tjoelker
l - fi + debug "saving entropy to $f" + dd if=/dev/random of="$f" bs=4096 count=1 status=none && + chmod 600 "$f" done + umask ${oumask} } feed_dev_random() -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: copyinstr and ENAMETOOLONG

2016-12-02 Thread Jilles Tjoelker
On Fri, Dec 02, 2016 at 10:20:32AM -0600, Eric van Gyzen wrote: > On 11/02/2016 15:33, Jilles Tjoelker wrote: > > On Wed, Nov 02, 2016 at 02:24:43PM -0500, Eric van Gyzen wrote: > >> Does copyinstr guarantee that it has filled the output buffer when it > >> returns ENAM

Re: copyinstr and ENAMETOOLONG

2016-11-02 Thread Jilles Tjoelker
design, it makes more sense to set error = 0 if a truncated name is being set anyway. This preserves the property that the name remains unchanged if the call fails. A change to the man page thr_set_name(2) is needed in any case. -- Jilles Tjoelker ___ f

Re: Weirdness in TTY & VT

2016-09-08 Thread Jilles Tjoelker
BSD. A (userland) dev_t is an opaque identifier. The direct equivalent is devname_r() or fdevname_r() followed by parsing the resulting string. There is also a VT_GETINDEX ioctl but I don't know whether it works. -- Jilles Tjoelker ___ freebsd-curr

Re: PostgreSQL performance on FreeBSD

2016-06-23 Thread Jilles Tjoelker
and uses less memory. It has been supported for a long time, at least since FreeBSD 9.0. Process-shared mutexes, condition variables, reader/writer locks, etc. are available in FreeBSD 11 but use more memory (a 1-page object per synchronization object), somewhat like named semapho

Re: thread suspension when dumping core

2016-06-12 Thread Jilles Tjoelker
On Thu, Jun 09, 2016 at 07:34:55AM +0300, Konstantin Belousov wrote: > On Wed, Jun 08, 2016 at 11:17:44PM +0200, Jilles Tjoelker wrote: > > On Wed, Jun 08, 2016 at 04:56:35PM +0300, Konstantin Belousov wrote: > > > On Wed, Jun 08, 2016 at 06:35:08AM -0700, Mark Johnston wrote: &

Re: thread suspension when dumping core

2016-06-08 Thread Jilles Tjoelker
On Wed, Jun 08, 2016 at 04:56:35PM +0300, Konstantin Belousov wrote: > On Wed, Jun 08, 2016 at 06:35:08AM -0700, Mark Johnston wrote: > > On Wed, Jun 08, 2016 at 07:30:55AM +0300, Konstantin Belousov wrote: > > > On Tue, Jun 07, 2016 at 11:19:19PM +0200, Jilles Tjoelker wro

Re: thread suspension when dumping core

2016-06-07 Thread Jilles Tjoelker
On Tue, Jun 07, 2016 at 07:01:55PM +0300, Konstantin Belousov wrote: > On Tue, Jun 07, 2016 at 04:24:53PM +0200, Jilles Tjoelker wrote: > > On Tue, Jun 07, 2016 at 07:29:56AM +0300, Konstantin Belousov wrote: > > > This looks as if we should not ignore susp

Re: thread suspension when dumping core

2016-06-07 Thread Jilles Tjoelker
new kind of sleep would fail with [ERESTART] only for stops, since [EINTR] should only be returned if a signal handler was called. There cannot be a signal handler since a SIGTSTP/SIGTTIN/SIGTTOU signal with a handler does not stop the process. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: sdhci_pci.ko fails to load

2016-03-20 Thread Jilles Tjoelker
compiler in the module? > I suspect this is caused by my r292180 back in December. I'm trying to > figure out if that's the case and if so, how to fix it. I think this is caused by the missing MODULE_DEPEND. The kernel linker only looks for symbols in the ELF objec

Re: Possible problem with the ${name}_chdir variable behaviour in /etc/c.subr

2016-03-20 Thread Jilles Tjoelker
and allow getting rid of sh -c, but would change the directory as root so permission problems with NAME_user would be detected later. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-

Re: buffer overflow warning in /bin/sh

2016-02-28 Thread Jilles Tjoelker
: fd > Stack left redzone: f1 > Stack mid redzone: f2 > Stack right redzone: f3 > Stack partial redzone: f4 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order:

Re: Can't run `make universe` on universe11a.freebsd.org and ref11-amd64.freebsd.org (anymore); [shell] globbing is broken [there]

2016-01-05 Thread Jilles Tjoelker
people expect. Alternatively, the pattern could be rewritten to be locale-sensitive: [[:upper:][:digit:]]*[[:upper:][:digit:]] -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: /bin/ls formatting broken for non-C(?) locales

2015-11-20 Thread Jilles Tjoelker
tly better: it calculates the maximum width of the abbreviated month names and pads to that (with a maximum of 5). In particular, this ensures that the output does not change for locales that have 3-character abbreviations, such as the POSIX locale. I think

Re: futimens and utimensat vs birthtime

2015-08-16 Thread Jilles Tjoelker
disappointed that setting birthtimes apparently wasn't needed when I added futimens and utimensat. However, they are not part of any release yet, so it may be possible to remove them at some point. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: futimens and utimensat vs birthtime

2015-08-14 Thread Jilles Tjoelker
ts. Whether you want to do this instead of adding two more system calls is a different question. Also note that, in some sense, the inability to set the birthtime forward is a feature. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list

Re: FreeBSD_HEAD-tests - Build #1262 - Still Unstable

2015-08-09 Thread Jilles Tjoelker
ber 2003), UTF-8 has been restricted to code points up to 0x10 (inclusive). The higher sequences should be removed from the tests (or, even better, be expected to cause [EILSEQ]). I can provide a patch, but thought I'd explain the problem first. -- Jilles Tjoelker

Re: seekdir/readdir patch .. Call for Review.

2015-05-03 Thread Jilles Tjoelker
cessive with the current libc implementation), you could store at telldir() time the offset of the current block returned by getdirentries() and the d_fileno of all entries already returned in the current block. The D2410 patch can conceptually work for what Samba needs, stepping back one directory

Re: mergemaster failing with read-only /usr/src

2015-05-03 Thread Jilles Tjoelker
er make buildworld. Then mergemaster will work, even with a read-only /usr/obj. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: readdir/telldir/seekdir problem (i think)

2015-04-24 Thread Jilles Tjoelker
e start of the buffer if not found (and possibly return some entries again that should not be returned, but Samba copes with that). -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: SSE in libthr

2015-03-27 Thread Jilles Tjoelker
ow byte-at-a-time implementations. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: r279278 failed to build (yacc: maximum table size exceeded)

2015-02-27 Thread Jilles Tjoelker
For example, utilities like cp and touch currently use utimensat/futimens without #ifdef mess or extra code in libegacy. The strict BOOTSTRAPPING conditionals allow removing bootstrap tools eventually, when building from such old versions as to need them is n

Re: svn commit: r267977 - head/bin/mv

2014-07-01 Thread Jilles Tjoelker
On Fri, Jun 27, 2014 at 04:06:53PM -0700, Xin Li wrote: > [moving discussion to freebsd-current@] > On 06/27/14 15:23, Jilles Tjoelker wrote: > > On Fri, Jun 27, 2014 at 07:57:54PM +, Xin LI wrote: > >> Author: delphij > >> Date: Fri Jun 27 19:57:54 2014 >

Re: Turning TESTS on by default

2014-06-06 Thread Jilles Tjoelker
NFS) /usr/obj first. I reported this a while ago in http://lists.freebsd.org/pipermail/freebsd-testing/2014-May/000384.html "build Kyuafile.auto during buildworld, not installworld". This message includes patches, although they are a bit ugly. -- Jilles Tjoelker _

Re: another Make (maybe) problem

2014-04-05 Thread Jilles Tjoelker
118 > lines/388 words/3377 characters.) These messages are harmless, but are fixed by r264167. The cause is pretty much expected: libnv was listed in SUBDIR twice. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Hello fdclose

2014-03-18 Thread Jilles Tjoelker
needs to be different so it can report a write error but still return a file descriptor. One way to do this is to return the file descriptor by reference. Another is to expect the application to call fileno() and not return the descriptor from the new function. -- Jilles Tjoelker _

Re: r263096 sparc64: casperd: Unable to receive message from client: Cannot allocate memory.

2014-03-14 Thread Jilles Tjoelker
libnv/nv.3 (revision 262358) +++ lib/libnv/nv.3 (working copy) @@ -310,7 +310,9 @@ The .Fn nvlist_send function sends the given nvlist over the socket given by the .Fa sock -argument. +argument, +without generating +.Dv SIGPIPE . Note that nvlist that contains file d

Re: Import of DragonFly Mail Agent

2014-02-25 Thread Jilles Tjoelker
On Tue, Feb 25, 2014 at 11:30:56AM +0100, Baptiste Daroussin wrote: > On Mon, Feb 24, 2014 at 11:50:10PM +0100, Jilles Tjoelker wrote: > > On Mon, Feb 24, 2014 at 07:01:54PM +0400, Slawa Olhovchenkov wrote: > > > On Mon, Feb 24, 2014 at 03:30:14PM +0100, Baptiste Daroussin wrot

Re: Import of DragonFly Mail Agent

2014-02-24 Thread Jilles Tjoelker
tors, send signals, etc), I think it is better to implement trusted submission differently. A privileged daemon (not necessarily running as root) can listen on a Unix domain socket and use getpeereid(3) to verify the credentials of the client. Note that the largest gain with s

Re: [CFT] bsdinstall and zfsboot enhancements

2014-01-08 Thread Jilles Tjoelker
On Sun, Jan 05, 2014 at 04:04:03PM -0500, Nathan Whitehorn wrote: > On 12/01/13 07:34, Jilles Tjoelker wrote: > > On Sat, Nov 30, 2013 at 04:36:18PM -0600, Nathan Whitehorn wrote: > >> This took much longer than I'd anticipated, but the patch to init is > >> a

Re: [CFT] bsdinstall and zfsboot enhancements

2013-12-01 Thread Jilles Tjoelker
hich is irrelevant with utmpx. This noise warning would also appear in most cases when changing from a "fake" console entry to a real line in /etc/ttys. Also, if you do decide to fake ttys entries in init rather than libc, the patch to init will be simpler. -- Jilles Tjoelker __

Re: [PATCH] contrib/groff Queisce -Wdangling else

2013-10-26 Thread Jilles Tjoelker
>There is no(intended) functional change. This part indeed looks wrong. The while loop was not under the if (rem > H0) but now is. The closing brace should be added before instead of after the while loop. Also, putting braces around out->right(re

Re: [Heads Up] RCS removed from base

2013-10-07 Thread Jilles Tjoelker
trol systems and not provided separately. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: installworld broken - osreldate.h: permission denied

2013-09-30 Thread Jilles Tjoelker
+++ include/mk-osreldate.sh (working copy) @@ -48,4 +48,5 @@ #define __FreeBSD_version $RELDATE #endif EOF +chmod 644 $tmpfile mv $tmpfile osreldate.h -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: restarting SYSCALL system call on amd64 loses arguments

2013-09-24 Thread Jilles Tjoelker
On Tue, Sep 24, 2013 at 10:29:09PM +0300, Konstantin Belousov wrote: > On Tue, Sep 24, 2013 at 09:19:49PM +0200, Jilles Tjoelker wrote: > > On Tue, Sep 24, 2013 at 12:37:30AM +0300, Konstantin Belousov wrote: > > > On Mon, Sep 23, 2013 at 10:26:13PM +0200, Tijl Coosemans wrote:

Re: restarting SYSCALL system call on amd64 loses arguments

2013-09-24 Thread Jilles Tjoelker
local system by racing signal delivery via handler with acceptance in sigtimedwait(). -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: I386 jail on amd64 CURRENT core dump in libc?

2013-09-04 Thread Jilles Tjoelker
freebsd32_cap_enter(void); } 517AUE_CAP_GETMODE NOPROTO { int cap_getmode(u_int *modep); } 518AUE_PDFORK NOPROTO { int pdfork(int *fdp, int flags); } 519AUE_PDKILL NOPROTO { int pdkill(int fd, int signum); } -- Jilles Tjoelker ___ f

Re: Ports with daemons on uninstall...

2013-07-14 Thread Jilles Tjoelker
idea. Apart from the annoyance of the restarts, automatic stopping and starting is probably the best policy for having things "just work". Some daemons will crash or otherwise stop being useful when their files have been deleted or replaced, an

Re: rebuilding world fail

2013-06-04 Thread Jilles Tjoelker
e better part of a year. Note that fdlopen() (possibly used by PAM) has depended on F_DUPFD_CLOEXEC for longer. You can try booting the new kernel manually or getting a /bin/sh binary from before svn r250267 from somewhere. -- Jilles Tjoelker ___ freebsd

Re: FreeBSD-HEAD gets stuck on vnode operations

2013-05-26 Thread Jilles Tjoelker
On Sun, May 26, 2013 at 10:52:07PM +0200, Roger Pau Monné wrote: > On 26/05/13 22:20, Jilles Tjoelker wrote: > > Instead of a pause() that may be too short or too long, how about > > waiting for the necessary lock? In other words, replace the kern_yield() > > call with VI_L

Re: FreeBSD-HEAD gets stuck on vnode operations

2013-05-26 Thread Jilles Tjoelker
s(+), 1 deletions(-) > > diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c > index 0da6764..597f4b7 100644 > --- a/sys/kern/vfs_subr.c > +++ b/sys/kern/vfs_subr.c > @@ -4703,7 +4703,15 @@ restart: > if (mp_ncpus == 1 || should_yi

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread Jilles Tjoelker
d mentioned this possibility on IRC, but this feature is specific to Almquist-derived shells (ash) and so something more portable was selected. (It's still not standard because POSIX does not specify "local" but it works on most shells in use.) -- Jilles Tjoelker

Re: r247839: broken pipe - for top, sudo and ports

2013-03-10 Thread Jilles Tjoelker
On Sun, Mar 10, 2013 at 08:26:03PM -0200, Jan Beich wrote: > Jilles Tjoelker writes: > > On Thu, Mar 07, 2013 at 04:54:01AM -0100, Jan Beich wrote: > >> Jilles Tjoelker writes: > >> > On Tue, Mar 05, 2013 at 08:59:09PM +0100, Hartmann, O. wrote: > >> &g

Re: r247839: broken pipe - for top, sudo and ports

2013-03-10 Thread Jilles Tjoelker
On Thu, Mar 07, 2013 at 04:54:01AM -0100, Jan Beich wrote: > Jilles Tjoelker writes: > > On Tue, Mar 05, 2013 at 08:59:09PM +0100, Hartmann, O. wrote: > >> A "truss top" reveals this, is this of help? > >> [...] > >> stat("/etc/nsswitch.c

Re: r247839: broken pipe - for top, sudo and ports

2013-03-06 Thread Jilles Tjoelker
ockfd, &cred_hdr, 0) == -1) ? - -1 : 0; + result = (_sendmsg(connection->sockfd, &cred_hdr, + MSG_NOSIGNAL) == -1) ? -1 : 0; EV_SET(&eventlist, connection->sockfd, EVFILT_WRITE, EV_ADD,

Re: [PATCH] open_memstream() and open_wmemstream()

2013-02-15 Thread Jilles Tjoelker
On Wed, Feb 13, 2013 at 11:44:19AM -0500, John Baldwin wrote: > On Thursday, February 07, 2013 4:12:22 pm Jilles Tjoelker wrote: > > On Tue, Feb 05, 2013 at 03:46:43PM -0500, John Baldwin wrote: > > > I've written an implementation of open_memstream() and > > > op

Re: [PATCH] open_memstream() and open_wmemstream()

2013-02-07 Thread Jilles Tjoelker
n to bytes and back probably makes open_wmemstream() quite slow but I don't think that is very important. > http://www.FreeBSD.org/~jhb/patches/open_memstream.patch The seek functions should check for overflow in the addition (for SEEK_CUR and SE

Re: ktrace -d broken on current/stable-9

2013-01-15 Thread Jilles Tjoelker
ocesses of ktrace (at a time just before it executes the utility) should be traced as well. This is almost always an empty set, unless you do things like cmd1 & ktrace -d cmd2 which will trace cmd2 and part of cmd1. You probably want ktrace -i. -- Jilles Tjoelker

Re: API explosion (Re: [RFC/RFT] calloutng)

2012-12-22 Thread Jilles Tjoelker
t this right, callouts from device drivers will just "DTRT", > if you get it wrong, all device drivers will need boilerplate code > to handle S/R Userland could get access to this via CLOCK_REALTIME vs CLOCK_MONOTONIC vs CLOCK_UPTIME. -- Jilles Tjoelker __

Re: ipv6_addrs_IF aliases in rc.conf(5)

2012-12-20 Thread Jilles Tjoelker
n you can use; in older versions you can use hexdigit and hexprint from network.subr. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "fr

Re: rev 244030 route command is not working

2012-12-12 Thread Jilles Tjoelker
saved and restored around that to avoid setting errno to 0 as a side effect of the function. The empty string needs a specific check. I don't insist on this being fixed but it shows that strtol() is too hard to use correctly. The non-standard strtonum() looks easier but has other problems (su

Re: RFC: sysctl -f filename

2012-12-02 Thread Jilles Tjoelker
is incomplete%s", > + string, line); > + return (1); > case ENOMEM: > - errx(1, "%s: type is unknown to this program", > - string);

Re: clang and static linking?

2012-11-10 Thread Jilles Tjoelker
; +#undef isnan > int > isnan(double d) > { > @@ -40,7 +41,7 @@ isnan(double d) > u.d = d; > return (u.bits.exp == 2047 && (u.bits.manl != 0 || u.bits.manh != 0)); > } > -#endif > +#endif /* !PIC */ > > int > __isnanf(float f) -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: pkgng suggestion: renaming /usr/sbin/pkg to /usr/sbin/pkg-bootstrap

2012-09-01 Thread Jilles Tjoelker
> makes perfect sense to me that tools for dealing with the ports should > follow changes to ports rather than changes to the base. Yes. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [PATCH] Add a "-h" flag to mv

2012-08-29 Thread Jilles Tjoelker
On Wed, Aug 29, 2012 at 08:09:20AM -0400, John Baldwin wrote: > On Wednesday, August 29, 2012 6:02:47 am Jilles Tjoelker wrote: > > GNU coreutils mv (and also cp/install/ln) appears to use > > -T/--no-target-directory for a similar purpose: -T prevents the target > > being t

Re: [PATCH] Add a "-h" flag to mv

2012-08-29 Thread Jilles Tjoelker
y. I > could not find any other mv commands that have adopted a -h (or a different > flag that accomplishes the same task). Given that it functions identically > to the -h flag for ln, -h seemed the "logical" choice. Any objections? GNU coreutils mv (and also cp/install/l

Re: pkgng suggestion: renaming /usr/sbin/pkg to /usr/sbin/pkg-bootstrap

2012-08-26 Thread Jilles Tjoelker
e to be distributed with base (like the public keys for freebsd-update and portsnap). -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: pkgng default schedule... registering a few reasons for rethinking the final implementation...

2012-08-23 Thread Jilles Tjoelker
*) echo no ;; esac done This does assume that the list does not change during the loop. Also, instead of pName=`echo $pkg | rev | cut -d "-" -f 2-25 | rev` try pName=${pkg%-*} and use arithmetic expansion ($((...))) instead of invoking expr where possible. --

Re: PAM passwdqc, strict aliasing, and WARNS

2012-07-14 Thread Jilles Tjoelker
esentation. The conversion might be non-trivial and a "type-pun" may not work properly. However, in almost all real machines the conversion is trivial. Some compilers may still consider the union approach a strict-aliasing violation. In any case, I think it is a

Re: "make delete-old" performance.

2012-05-17 Thread Jilles Tjoelker
one loop. (Note the second "sh" at the end, which serves as a value for $0 so all strings from xargs become positional parameters.) -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Build error in bin/sh/jobs.c if DEBUG=2

2012-04-02 Thread Jilles Tjoelker
arbitrarily chose some information to print, since I do not use -DDEBUG=2 myself. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: Enhancing the user experience with tcsh

2012-02-12 Thread Jilles Tjoelker
think it is not used deliberately by many people but is annoying if you accidentally press it and do not realize. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: stray symbol in hd's output?

2012-01-29 Thread Jilles Tjoelker
bytes/sec) > 00|.| > n0001 Yes, this was broken by r229794 (Jan 7) and repaired again by r230649 (yesterday). http://www.freebsd.org/cgi/query-pr.cgi?pr=144722 -- Jilles Tjoelker ___ freebsd-curren

Re: i18n and shell scripts

2012-01-22 Thread Jilles Tjoelker
c character sets. The base catgets(3) facility does not provide a utility for use from shell scripts, and is also harder to use than gettext. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/fre

Re: HEADS UP: set_rcvar() removed from rc.subr

2012-01-14 Thread Jilles Tjoelker
On Sat, Jan 14, 2012 at 01:05:59AM -0800, Doug Barton wrote: > Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr. > The concept of set_rcvar() was nice in theory, but the forks it creates > are a drag on the startup process, which is especially noticeable on > slower systems, s

Re: add 'ldd' to cross-tools ?

2012-01-04 Thread Jilles Tjoelker
work as a cross tool. Upsides are that it is simple and it shows exactly what rtld would do (because it is rtld), handling things like /var/run/ld-elf.so.hints, LD_LIBRARY_PATH and pathnames hardcoded into objects. You will have to run objdump (or readelf) recursively. (Note that there are also use cas

Re: r228700 can't dhclient em0

2011-12-21 Thread Jilles Tjoelker
ewhat). Another consideration is compatibility for 32-bit applications on 64-bit kernels; a good ABI design will minimize the amount of code needed to support that. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/ma

Re: SCHED_ULE should not be the default

2011-12-13 Thread Jilles Tjoelker
if (--ts->ts_slice > 0) > - return; > - /* >* We're out of time, force a requeue at userret(). >*/ > ts->ts_slice = sched_slice; > and refusal to use options FULL_PREEMPTION > But no one has unsubscribed

Re: WITHOUT_PROFILE=yes by default

2011-11-29 Thread Jilles Tjoelker
es are pmcstat and callgrind/cachegrind. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: possible array out of bounds access in sys/netinet/sctp_output.c

2011-11-27 Thread Jilles Tjoelker
tations. C99 recognized this need and created a way to do it, which looks like uint16_t addr_type[];. This adds any necessary padding and allows access to however many elements have been allocated. Also, if it is not at the end of a struct it is an error. Using this new construct requires cod

Re: crash in sb-concurrency tests after r216641 on x86-64/freebsd9/sb-thread

2011-11-19 Thread Jilles Tjoelker
till cause erratic undefined behaviour. Therefore, it may not be desirable to do this. An alternative is to use pthread_suspend_np(). This function will wait for the thread to stop before returning, although it may stop almost anywhere. I have not tried this but calling it on a thread in pthr

Re: [Freebsd 9] [amd64] [USB] [HPLIP] what's the (new) right way to manage hplip usb-plugged printers, running Freebsd 9

2011-10-29 Thread Jilles Tjoelker
ils) use something like devfs_set_rulesets="/usr/jails/jail1/dev=devfsrules_jail1 /usr/jails/jail2/dev=devfsrules_jail2" -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-curr

Re: Not setting TERM explicitly wraps commands at 80 columns with nested shells in xterms using sh + bash?

2011-10-21 Thread Jilles Tjoelker
environment variables) when it receives SIGWINCH, so only if bash is in the foreground when the change happens. You can do shopt -s checkwinsize to make it check more often. libedit (as used in sh) is different; it appears to check the size before reading each line. -- Jilles Tjoelker

Re: portsnap5 problem, portsnap error handling

2011-10-04 Thread Jilles Tjoelker
c snap/${F} | ${SHA256} -q` != ${F} ]; then + if [ "`gunzip -c snap/${F} | ${SHA256} -q`" != ${F} ]; then echo "snapshot corrupt." return 1 fi -- Jilles Tjoelker ___ freebsd-c

Re: cvsup broken on amd64?

2011-10-03 Thread Jilles Tjoelker
is because a thread awakened by pthread_cond_signal() (or any other event) is not guaranteed to start running immediately and pthread_cond_signal() does nothing if there is no thread to wake up. If there is no second CPU core available to run the detailer thread,

Re: Segfault in libthr.so on 9.0-BETA2 (with stunnel FWIW)

2011-09-18 Thread Jilles Tjoelker
> + } > + if ((strlen(p) + 1 + strlen(name) + 1) >= sizeof > fullname) { This sizeof is now the sizeof of a pointer. The comparison should be against FILENAME_MAX + 1 instead. Alternatively, the name could be created using asprintf(). -- Jill

Re: Serial Port Configuration does not work

2011-09-11 Thread Jilles Tjoelker
0644 --- a/sys/kern/tty.c +++ b/sys/kern/tty.c @@ -777,6 +777,7 @@ ttyil_ioctl(struct cdev *dev, u_long cmd, caddr_t data, int fflag, error = ttydevsw_cioctl(tp, dev2unit(dev), cmd, data, td); if (error != ENOIOCTL) goto done; + e

Re: any place to look at for PCI-express performance issues ?

2011-06-11 Thread Jilles Tjoelker
oblem that they are laid out in such a way that they cannot be cached efficiently. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [RFC] rcexecr: rcorder in parallel

2011-06-04 Thread Jilles Tjoelker
n. To avoid this, use waitpid(-1, ...) and maintain more tracking for processes that have already terminated. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: CFR: importing openresolv

2011-02-23 Thread Jilles Tjoelker
ansion changes, required for the line: iface="${line#\# resolv.conf from *}" This can be avoided by changing that line to: iface=${line#\# resolv.conf from *} -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Re: [head tinderbox] failure on ia64/ia64

2011-02-01 Thread Jilles Tjoelker
uct cmsghdr *)(cmsg))->cmsg_len)) Although there is no alignment problem (assuming cmsg is properly aligned and _ALIGN is correct), this violates -Wcast-align. Therefore I think an intermediate cast to void * would be appropriate here. -- Jilles Tjoelker _

Re: unbounded sleep on [fifoow] while open a named pipe: is it a feature?

2011-01-28 Thread Jilles Tjoelker
ot;$LOG_TOPIC_ERR" <"$fifo2" & exec >"$fifo1" 2>"$fifo2" rm -rf "$tempdir" Once the fifos have been opened for writing, the readers must have already opened too, therefore it is safe to unlink them. If you have a secure directory you may c

Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/

2011-01-08 Thread Jilles Tjoelker
On Wed, Jan 05, 2011 at 10:30:43PM +0100, Ulrich Spörlein wrote: > On Wed, 05.01.2011 at 20:36:53 +0100, Jilles Tjoelker wrote: > > On Wed, Jan 05, 2011 at 05:55:45PM +0100, Ulrich Spörlein wrote: > > > *But*, it should grok that for err(3) and exit(3). Now there are some >

Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/

2011-01-05 Thread Jilles Tjoelker
eordering the functions in the file does not help to make gcc see that the functions do not return. > - come up with a way to mark the false positives (kinda impossible with > the way scan-build currently works) -- Jilles Tjoelker ___ freebs

Re: head/bin/sh/output.h r215303

2010-11-14 Thread Jilles Tjoelker
and stddef.h resulting in 'offsetof' being redefined. This problem was introduced by r213775 include changes, which you have merged yourself. I had already noticed this myself in head and fixed it in r213925. I have now MFCed r213775 and r213925 so your problem should be solved

Re: Files under src/ not used for building world

2010-11-07 Thread Jilles Tjoelker
differently. This should not have been allowed to happen, but now we are stuck with it. I suppose bin/sh/bltin/echo.1 can go away. -- Jilles Tjoelker ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-c

Re: [PATCH] fix shell bug in ${var%pattern} expansion

2010-10-13 Thread Jilles Tjoelker
$FreeBSD$ v1=/homes/SOME_USER v2= v3=C123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789 while [ ${#v2} -lt 2000 ]; do v4="${v2} ${v1%/*} $v3" if [ ${#v4} -ne $((${#v2} + ${#v3} + 8)) ]; then echo bad: ${#v4} -ne $((${#v2} + ${#v3} + 8)) fi v

  1   2   >