Re: sysctl add macros

2013-11-25 Thread Matthew Fleming
On Mon, Nov 25, 2013 at 3:35 AM, Venkata Duvvuru < venkatkumar.duvv...@emulex.com> wrote: > Hi, > I'm unable to figure out how to add an unsigned short or an unsigned char > values to a sysctl node. > SYSCTL_ADD_INT, SYSCTL_ADD_UINT, etc., are present but to add a char or a > short values I couldn

Re: RFC: support for "first boot" rc.d scripts

2013-10-15 Thread Matthew Fleming
On Sun, Oct 13, 2013 at 3:58 PM, Colin Percival wrote: > Hi all, > > I've attached a very simple patch which makes /etc/rc: > > 1. Skip any rc.d scripts with the "firstboot" keyword if /var/db/firstboot > does not exist, > > 2. If /var/db/firstboot and /var/db/firstboot-reboot exist after running

Re: lock order reversals on 10.0-ALPHA4

2013-10-06 Thread Matthew Fleming
On Sun, Oct 6, 2013 at 6:44 AM, Julian H. Stacey wrote: > With: > FreeBSD lapr.js.berklix.net 10.0-ALPHA4 FreeBSD 10.0-ALPHA4 #0 > r255933: Sun Sep 29 02:50:54 UTC 2013 > r...@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 > > At boot dmesg shows several lock order reversals, eg > > --

Re: -ffunction-sections, -fdata-sections and -Wl,--gc-sections

2013-09-15 Thread Matthew Fleming
On Sun, Sep 15, 2013 at 2:24 PM, Ed Schouten wrote: > Hi all, > > Today I did a tiny experiment and I am not entirely sure what to do. > Throw away the patch or eventually push it into the tree. > > GCC and Clang support the -ffunction-sections and -fdata-sections > flags. Essentially, these flag

Re: GCC withdraw

2013-08-30 Thread Matthew Fleming
On Fri, Aug 30, 2013 at 6:47 AM, Ian Lepore wrote: > On Fri, 2013-08-30 at 07:39 -0600, Warner Losh wrote: > > I had a long, rambling reply to this that corrected many of the factual > errors made in it. But why bother. You have your world view, it doesn't > match what people are doing today and

Build error on CURRENT

2012-07-08 Thread Matthew Fleming
I'm getting a compile error during buildworld here: ===> libexec/atrun (all) cc -g -DATJOB_DIR=\"/var/at/jobs/\" -DLFILE=\"/var/at/jobs/.lockfile\" -DLOADAVG_MX=1.5 -DATSPOOL_DIR=\"/var/at/spool\" -DVERSION=\"2.9\" -DDAEMON_UID=1 -DDAEMON_GID=1 -DDEFAULT_BATCH_QUEUE=\'E\' -DDEFAULT_AT_QUEUE

Adding bool, true, and false to the kernel

2011-12-08 Thread Matthew Fleming
Hello -current! Recently on -arch@, we discussed adding the C99 keywords bool, true, and false to the kernel. I now have patches to do this as well as fix up some build issues. The original thread was here: http://lists.freebsd.org/pipermail/freebsd-arch/2011-November/011937.html I split the p

Re: [TESTING]: one more boot2 shrinking patch

2011-03-10 Thread Matthew Fleming
On Thu, Mar 10, 2011 at 8:37 AM, Roman Divacky wrote: > On Thu, Mar 10, 2011 at 09:20:58AM -0500, John Baldwin wrote: >> On Wednesday, March 09, 2011 6:24:36 pm Dimitry Andric wrote: >> > On 2011-03-09 14:23, John Baldwin wrote: >> > >> gcc nor clang emits any code to initialize static type foo =

Re: acpi_resource bug?

2011-02-14 Thread Matthew Fleming
On Mon, Feb 14, 2011 at 10:37 AM, John Baldwin wrote: > On Monday, February 14, 2011 1:30:18 pm Jung-uk Kim wrote: >> On Monday 14 February 2011 10:29 am, Matthew Fleming wrote: >> > On Mon, Feb 14, 2011 at 6:24 AM, John Baldwin >> wrote: >> > > On Sunday,

Re: acpi_resource bug?

2011-02-14 Thread Matthew Fleming
On Mon, Feb 14, 2011 at 6:24 AM, John Baldwin wrote: > On Sunday, February 13, 2011 2:46:07 pm Matthew Fleming wrote: >> I'm not very familiar with the acpi code, but we have seen an >> intermittent issue on boot: >> >> 1) should the length of the bcopy() be

acpi_resource bug?

2011-02-13 Thread Matthew Fleming
I'm not very familiar with the acpi code, but we have seen an intermittent issue on boot: Panic occurred in module kernel loaded at 0x8010: Stack: -- kernel:trap_fatal+0xac kernel:trap_pfault+0x24c kernel:trap+0x42e kernel:bcopy+0x16 ker

Re: amd64 build fails within ESXi guest

2011-01-24 Thread Matthew Fleming
On Mon, Jan 24, 2011 at 8:25 AM, Eric Crist wrote: > I'm trying to build HEAD within an ESXi guest system, and the build errors > while building the boot code.  I've attached the tail end of the log.  The > host is a Dell Vostro 230 with CPU: Intel(R) Core(TM)2 Quad CPU    Q8400  @ > 2.66GHz (2

Re: [head tinderbox] failure on amd64/amd64

2011-01-20 Thread Matthew Fleming
As far as I can tell this is another cvsup / tinderbox bug. Both sysctl.h and tsc.c were modified in r217616 but somehow tsc.c is seeing the old version of sysctl.h. This happened on another of my commits a few weeks ago. Hmm, does bumping __FreeBSD_version have anything to do with this? I bela

Re: [head tinderbox] failure on arm/arm

2011-01-12 Thread Matthew Fleming
This is me, but I'm rather puzzled why it's failing. SYSCTL_UQUAD is in the sys/sysctl.h for the image we're building. And why is there a file with SYSCTL_FOO being built as a library? Any help? Thanks, matthew On Wed, Jan 12, 2011 at 2:20 PM, FreeBSD Tinderbox wrote: > TB --- 2011-01-12 22:0

Re: [head tinderbox] failure on powerpc64/powerpc

2010-12-21 Thread Matthew Fleming
On Tue, Dec 21, 2010 at 2:37 PM, FreeBSD Tinderbox wrote: > TB --- 2010-12-21 20:56:55 - tinderbox 2.6 running on > freebsd-current.sentex.ca > TB --- 2010-12-21 20:56:55 - starting HEAD tinderbox run for powerpc64/powerpc > TB --- 2010-12-21 20:56:55 - cleaning the object tree > TB --- 2010-12-2

Re: [head tinderbox] failure on ia64/ia64

2010-12-21 Thread Matthew Fleming
This one has me puzzled. The line numbers don't match up with the current version of the code, so it may be from in between my two drops today. I will start a make universe on my test box meanwhile. Thanks, matthew On Tue, Dec 21, 2010 at 12:45 PM, FreeBSD Tinderbox wrote: > TB --- 2010-12-21

Re: Lock order reversal .

2010-12-07 Thread Matthew Fleming
On Tue, Dec 7, 2010 at 9:18 AM, Julian Elischer wrote: > On 12/7/10 3:41 AM, Attilio Rao wrote: >> >> 2010/12/7 Erik Cederstrand: >>> >>> Den 07/12/2010 kl. 10.20 skrev Garrett Cooper: >>> On Dec 7, 2010, at 12:26 AM, Mehmet Erol Sanliturk  wrote: > A Dmesg.TXT is attached havin

Re: kern_sysctl.c compilation failure

2010-11-29 Thread Matthew Fleming
On Mon, Nov 29, 2010 at 12:07 PM, Michael Butler wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Seems that 'treat warnings as errors' snags on this .. patch attached, Which compiler are you using? I didn't have any trouble with this file on a make universe last night... There's no

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-08 Thread Matthew Fleming
On Mon, Nov 8, 2010 at 10:24 AM, John Baldwin wrote: > On Monday, November 08, 2010 11:46:58 am Matthew Fleming wrote: >> On Mon, Nov 8, 2010 at 8:42 AM, John Baldwin wrote: >> > On Monday, November 08, 2010 10:34:33 am Matthew Fleming wrote: >> >> On Mon, Nov 8,

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-08 Thread Matthew Fleming
On Mon, Nov 8, 2010 at 8:46 AM, Matthew Fleming wrote: > On Mon, Nov 8, 2010 at 8:42 AM, John Baldwin wrote: >> On Monday, November 08, 2010 10:34:33 am Matthew Fleming wrote: >>> On Mon, Nov 8, 2010 at 6:47 AM, John Baldwin wrote: >>> > On Saturday, November 06, 2

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-08 Thread Matthew Fleming
On Mon, Nov 8, 2010 at 8:42 AM, John Baldwin wrote: > On Monday, November 08, 2010 10:34:33 am Matthew Fleming wrote: >> On Mon, Nov 8, 2010 at 6:47 AM, John Baldwin wrote: >> > On Saturday, November 06, 2010 4:33:17 pm Matthew Fleming wrote: >> >> On Sat, Nov 6

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-08 Thread Matthew Fleming
On Mon, Nov 8, 2010 at 6:47 AM, John Baldwin wrote: > On Saturday, November 06, 2010 4:33:17 pm Matthew Fleming wrote: >> On Sat, Nov 6, 2010 at 7:22 AM, Hans Petter Selasky wrote: >> > Hi, >> > >> > On Saturday 06 November 2010 14:57:50 Matthew Flemi

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-06 Thread Matthew Fleming
On Sat, Nov 6, 2010 at 7:22 AM, Hans Petter Selasky wrote: > Hi, > > On Saturday 06 November 2010 14:57:50 Matthew Fleming wrote: >> >> I think you're misunderstanding the existing taskqueue(9) implementation. >> >> As long as TQ_LOCK is held, the state of ta

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-06 Thread Matthew Fleming
On Sat, Nov 6, 2010 at 1:37 AM, Hans Petter Selasky wrote: > On Friday 05 November 2010 20:06:12 John Baldwin wrote: >> On Friday, November 05, 2010 3:00:37 pm Hans Petter Selasky wrote: >> > On Friday 05 November 2010 19:48:05 Matthew Fleming wrote: >> > > On Fri,

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-05 Thread Matthew Fleming
On Fri, Nov 5, 2010 at 11:45 AM, Hans Petter Selasky wrote: > On Friday 05 November 2010 19:39:45 Matthew Fleming wrote: >> True, but no taskqueue(9) code can handle that.  Only the caller can >> prevent a task from becoming enqueued again.  The same issue exists >> with tas

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-05 Thread Matthew Fleming
On Fri, Nov 5, 2010 at 11:35 AM, Hans Petter Selasky wrote: > On Friday 05 November 2010 19:13:08 Matthew Fleming wrote: >> On Fri, Nov 5, 2010 at 10:36 AM, Hans Petter Selasky > wrote: >> > On Friday 05 November 2010 18:15:01 Matthew Fleming wrote: >> >> On

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-05 Thread Matthew Fleming
On Fri, Nov 5, 2010 at 10:36 AM, Hans Petter Selasky wrote: > On Friday 05 November 2010 18:15:01 Matthew Fleming wrote: >> On Fri, Nov 5, 2010 at 7:18 AM, John Baldwin wrote: >> > On Friday, November 05, 2010 9:50:10 am Matthew Fleming wrote: >> >> On Fri, Nov 5,

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-05 Thread Matthew Fleming
On Fri, Nov 5, 2010 at 7:18 AM, John Baldwin wrote: > On Friday, November 05, 2010 9:50:10 am Matthew Fleming wrote: >> On Fri, Nov 5, 2010 at 5:58 AM, John Baldwin wrote: >> > On Thursday, November 04, 2010 5:49:22 pm Matthew Fleming wrote: >> >> On Thu, Nov 4,

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-05 Thread Matthew Fleming
On Fri, Nov 5, 2010 at 5:58 AM, John Baldwin wrote: > On Thursday, November 04, 2010 5:49:22 pm Matthew Fleming wrote: >> On Thu, Nov 4, 2010 at 2:22 PM, John Baldwin wrote: >> > On Thursday, November 04, 2010 4:15:16 pm Hans Petter Selasky wrote: >> >> I thi

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-04 Thread Matthew Fleming
On Thu, Nov 4, 2010 at 2:22 PM, John Baldwin wrote: > On Thursday, November 04, 2010 4:15:16 pm Hans Petter Selasky wrote: >> I think that if a task is currently executing, then there should be a drain >> method for that. I.E. two methods: One to stop and one to cancel/drain. Can >> you implement

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-04 Thread Matthew Fleming
On Thu, Nov 4, 2010 at 12:11 PM, Hans Petter Selasky wrote: > On Thursday 04 November 2010 20:01:57 Matthew Fleming wrote: >> On Thu, Nov 4, 2010 at 11:41 AM, Hans Petter Selasky > wrote: >> > On Thursday 04 November 2010 15:29:51 John Baldwin wrote: >> >>  (a

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-04 Thread Matthew Fleming
On Thu, Nov 4, 2010 at 11:41 AM, Hans Petter Selasky wrote: > On Thursday 04 November 2010 15:29:51 John Baldwin wrote: >>  (and there is in Jeff's OFED branch) > > Is there a link to this branch? I would certainly have a look at his work and > re-base my patch. It's on svn.freebsd.org: http://s

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-04 Thread Matthew Fleming
On Mon, Nov 1, 2010 at 1:15 PM, Hans Petter Selasky wrote: > On Monday 01 November 2010 21:07:29 Matthew Fleming wrote: >> On Mon, Nov 1, 2010 at 12:54 PM, Hans Petter Selasky > wrote: >> > Hi! >> > >> > I've wrapped up an outline patch for what needs

Re: [RFC] Outline of USB process integration in the kernel taskqueue system

2010-11-01 Thread Matthew Fleming
On Mon, Nov 1, 2010 at 12:54 PM, Hans Petter Selasky wrote: > Hi! > > I've wrapped up an outline patch for what needs to be done to integrate the > USB process framework into the kernel taskqueue system in a more direct way > that to wrap it. > > The limitation of the existing taskqueue system is

Re: intr_event_destroy(9)

2010-10-26 Thread Matthew Fleming
On Tue, Oct 26, 2010 at 9:46 AM, John Baldwin wrote: > On Tuesday, October 26, 2010 11:55:10 am Matthew Fleming wrote: >> It looks like a bug in intr_event_destroy(9): I'm trying to unload a >> new driver being developed internally for NVRAM, and I get this >>

intr_event_destroy(9)

2010-10-26 Thread Matthew Fleming
It looks like a bug in intr_event_destroy(9): I'm trying to unload a new driver being developed internally for NVRAM, and I get this WITNESS warning and hang: # kldunload rnv Sleeping on "ithdty" with the following non-sleepable locks held: exclusive sleep mutex intr event list (intr event list)

Re: [zfs] Mounting from (...) failed with error 19

2010-10-20 Thread Matthew Fleming
On Wed, Oct 20, 2010 at 1:39 PM, Garrett Cooper wrote: > On Wed, Oct 20, 2010 at 12:45 PM, Peter Jeremy wrote: >> On 2010-Oct-20 10:50:38 +0400, KOT MATPOCKuH wrote: I fixed it with attached patch. >>>Omg... Why You are using strcmp, but not strncmp(fs, "zfs", strlen("zfs"))? >> >> Can you

Re: dmesg mangled by acd0 probe

2010-10-03 Thread Matthew Fleming
On Sun, Oct 3, 2010 at 7:16 PM, Steve Kargl wrote: > I suspect that 517 ( are not expected during boot. > > > acd0: FAILURE - INQUIRY ILLEGAL REQUEST asc=0x24 ascq=0x00 > (((

Re: CACHE_LINE_SIZE too small, so struct vpglocks size alignment doesn't work

2010-10-01 Thread Matthew Fleming
On Fri, Oct 1, 2010 at 1:00 PM, Svatopluk Kraus wrote: > Hallo, > >  a size of 'struct vpglocks' is padded to CACHE_LINE_SIZE size in > 'sys/vm/vm_page.h' > header file. I work on a 'coldfire' port where CACHE_LINE_SIZE is 16 bytes and > sizeof(struct mtx) is 20 bytes thus size alignment doesn't w

Re: Examining the VM splay tree effectiveness

2010-09-30 Thread Matthew Fleming
On Thu, Sep 30, 2010 at 9:37 AM, Andre Oppermann wrote: > Just for the kick of it I decided to take a closer look at the use of > splay trees (inherited from Mach if I read the history correctly) in > the FreeBSD VM system suspecting an interesting journey. > > The VM system has two major structur

Re: MAXCPU preparations

2010-09-29 Thread Matthew Fleming
On Wed, Sep 29, 2010 at 1:54 PM, Robert N. M. Watson wrote: > > On 29 Sep 2010, at 12:49, John Baldwin wrote: > >> On Tuesday, September 28, 2010 6:24:32 pm Robert N. M. Watson wrote: >>> >>> On 28 Sep 2010, at 19:40, Sean Bruno wrote: >>> > If you go fully dynamic you should use mp_maxid + 1

Re: System reboots building mysql51-client with ZFS v28

2010-09-09 Thread Matthew Fleming
On Thu, Sep 9, 2010 at 4:04 PM, Xin LI wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 2010/09/09 15:33, Xin LI wrote: >> On 2010/09/09 15:28, Rob Farmer wrote: >>> On Thu, Sep 9, 2010 at 15:14, Xin LI wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi

Re: LOR on nfs: vfs_vnops.c:301 kern_descrip.c:1580

2010-08-17 Thread Matthew Fleming
On Tue, Aug 17, 2010 at 4:04 PM, Kostik Belousov wrote: > On Tue, Aug 17, 2010 at 07:42:41PM +0400, pluknet wrote: >> 2010/8/16 Kostik Belousov : >> > On Mon, Aug 16, 2010 at 09:07:24PM +0400, pluknet wrote: >> >> On 16 August 2010 21:05, pluknet wrote: >> >> > Hi. >> >> > >> >> > Seeing on mostl

Re: Interrupt Problems

2010-07-28 Thread Matthew Fleming
David Naylor wrote: > I have been having interrupt related problems with various subsystems.  I > suspect this is related to the changes in the event timer infrastructure. > > The subsystems that have experienced interrupt problems: >  - hda: this is the easiest to reproduce and what I used to isol

RE: Crash dump problem - sleeping thread owns a non-sleepable lock during crash dump write

2010-05-14 Thread Matthew Fleming
> As an aside, this is a quad-core in one package CPU (an X3363). On both > this box and a similar one with an X5470, console messages continue to > print out after "the system has been halted - press any key to reboot" - > in particular, the shutdown makes a bunch of the "behind the scenes" man-

sleep bug in taskqueue(9)

2010-04-28 Thread Matthew Fleming
It looks to me like taskqueue_drain(taskqueue_thread, foo) will not correctly detect whether or not a task is currently running. The check is against a field in the taskqueue struct, but for the taskqueue_thread queue with more than one thread, multiple threads can simultaneously be running a task

[PATCH] Fix LOR #185

2010-02-15 Thread Matthew Fleming
We've seen LOR #185 on http://sources.zabbadoz.net/freebsd/lor.html locally on and off since October 2007. This patch has been compiled but I don't have a reliable way to repro the LOR so it's not been properly tested. If someone who has seen this LOR can confirm the patch fixes it, and could com