A minor simplification patch:
Index: sys/arm/allwinner/a10_gpio.c
===
--- sys/arm/allwinner/a10_gpio.c(revision 291978)
+++ sys/arm/allwinner/a10_gpio.c(working copy)
@@ -356,10 +356,7 @@
sc = device_get_softc
Hi Michael,
What would be the advantage of it?
I still prefer explicit than implicit. The current code is much more
readable.
Best,
2015-12-08 11:13 GMT+08:00 Michael McConville :
> A minor simplification patch:
>
>
> Index: sys/arm/allwinner/a10_gpio.c
> ===
2015-12-08 5:40 GMT+01:00 Marcelo Araujo :
> Hi Michael,
>
> What would be the advantage of it?
> I still prefer explicit than implicit. The current code is much more
> readable.
>
> Best,
>
> 2015-12-08 11:13 GMT+08:00 Michael McConville :
>
> > A minor simplification patch:
> >
> >
> > Index: sy
Marcelo Araujo wrote:
> What would be the advantage of it?
Just clarity and readability.
> I still prefer explicit than implicit. The current code is much more
> readable.
I very much disagree. XOR is a basic binary operation, like AND and OR.
I don't understand what's more explicit about using
On 12/08/15 08:57, Ranjan1018 . wrote:
Hi,
I prefer the syntax in the patch:
- the semantic is more clear for me: if you want to flip a bit you should
use xor
- it saves, probably, some bytes of assembly code
Regards
Maurizio
+1
And it is unconditional.
--HPS
___