Re: [PATCH] contrib/groff Queisce -Wdangling else [updated]

2013-10-27 Thread Sean Bruno
On Sat, 2013-10-26 at 11:04 -0400, Sean Bruno wrote: > This adds proper braces to clear Clang warnings about dangling else > statements in groff. There is no(intended) functional change. > > http://people.freebsd.org/~sbruno/groff_dangling_else.txt > > sean I've updated the patch at this link a

Re: [PATCH] contrib/groff Queisce -Wdangling else

2013-10-27 Thread Sean Bruno
On Sat, 2013-10-26 at 20:22 -0400, Eitan Adler wrote: > On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno wrote: > > This adds proper braces to clear Clang warnings about dangling else > > statements in groff. There is no(intended) functional change. > > > For contributed code why not just disable w

Re: [PATCH] contrib/groff Queisce -Wdangling else

2013-10-26 Thread Eitan Adler
On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno wrote: > This adds proper braces to clear Clang warnings about dangling else > statements in groff. There is no(intended) functional change. For contributed code why not just disable warnings? Fixing code is good but doing so in our repository inste

Re: [PATCH] contrib/groff Queisce -Wdangling else

2013-10-26 Thread Jilles Tjoelker
On Sat, Oct 26, 2013 at 11:04:29PM +0200, d...@gmx.com wrote: > Sean Bruno wrote, On 10/26/2013 17:04: > Index: contrib/groff/src/roff/troff/node.cpp > === > --- contrib/groff/src/roff/troff/node.cpp (revision 257159) > +++ contri

Re: [PATCH] contrib/groff Queisce -Wdangling else

2013-10-26 Thread Kimmo Paasiala
On Sun, Oct 27, 2013 at 12:04 AM, wrote: > Sean Bruno wrote, On 10/26/2013 17:04: > > > RED ALERT ! SEAN BRUNO IS A GOVERNMENT SPY 1 > If this is an attempt at humor it's pretty lame one. ___ freebsd-current@freebsd.org mailing list http://lists.f

Re: [PATCH] contrib/groff Queisce -Wdangling else

2013-10-26 Thread dt71
Sean Bruno wrote, On 10/26/2013 17:04: Index: contrib/groff/src/roff/troff/node.cpp === --- contrib/groff/src/roff/troff/node.cpp (revision 257159) +++ contrib/groff/src/roff/troff/node.cpp (working copy) @@ -4600,17 +460

[PATCH] contrib/groff Queisce -Wdangling else

2013-10-26 Thread Sean Bruno
This adds proper braces to clear Clang warnings about dangling else statements in groff. There is no(intended) functional change. http://people.freebsd.org/~sbruno/groff_dangling_else.txt sean signature.asc Description: This is a digitally signed message part