On Sat, Feb 19, 2000 at 06:19:17PM +0900, Yoshinobu Inoue wrote:
EPSV is just enhanced version of PASV, and I think it needs to
check same kind of errors. Maybe same check as getreply() in
ftp/ftp.c will be necessary. About the spec, please check RFC2428.
But the problem is that the error
On Sun, Feb 20, 2000 at 01:37:01PM -0800, Andrey A. Chernov wrote:
I don't look at the code deeply yet, but it looks from
your words that EPSV command must be issued _only_ if ftp called
as pftp or 'passive' command given or FTP_PASIVE_MODE
env. variable is set and must be not issued in
On Sun, Feb 20, 2000 at 01:56:06PM -0800, Andrey A. Chernov wrote:
Sorry, this place (EPSV == PASV) is right excepting proxy mode is not covered by
EPSV (see PASV usage for proxy).
Another error is that
static int try_epsv = 1;
is set globally for all connections made by ftp
instead
Please review this patch. It fix all problems I mention.
--- ftp.c.old Sun Feb 20 23:30:29 2000
+++ ftp.c Mon Feb 21 02:21:01 2000
@@ -1173,8 +1173,6 @@
#endif
if (passivemode) {
- static int try_epsv = 1;
-
data_addr = myctladdr;
Please review this patch. It fix all problems I mention.
Thanks, as far as I reviewed and actually confirmed, your
patches solved every problem. :-)
Yoshinobu Inoue
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
Could you please create the patch which seems to be safely
committed? That will be very much help.
Well, I can try but I need to know most shortest and most trivial EPSV
check sequence from you since can't check it locally and don't know about EPSV.
EPSV is just enhanced version of
On Thu, Feb 17, 2000 at 06:06:22PM +0900, Yoshinobu Inoue wrote:
But maybe it is better to print out the first error, as the fact?
I have nothing against EPSV itself, I am against additional verbosity and
performance degradation since it is tried before _each_ command.
OK I'll change
OK I'll change not to try it once it fails.
It seems your last patch _not_ fix the problem. Now I got:
ftp dir
500 'EPSV': command not understood.
on first 'dir' command issued. This is with wu-ftpd. Remember that different
ftpd's could have slightly different format for response so
But maybe it is better to print out the first error, as the fact?
I have nothing against EPSV itself, I am against additional verbosity and
performance degradation since it is tried before _each_ command.
OK I'll change not to try it once it fails.
But trying to do that I noticed that
Hello,
EPSV and EPRT is new ftp command defind in RFC2428 and it is
used for IPv6 and NAT/firewall friendly IPv4 connection.
Current implementation is,
(1)EPRT is only used if destination is IPv6 host.
(2)EPSV is always tried first, and if server doesn't support it,
then try PASV.
EPRT
10 matches
Mail list logo