CD/DVD ejecting after sysinstall

2010-08-20 Thread Jim Riggs
References: http://www.mail-archive.com/svn-src-...@freebsd.org/msg24380.html http://forums.freebsd.org/showthread.php?t=17126 This commit automatically ejects the CD when sysinstall exits which almost had dire consequences for me this week. As described in the forum post, I keep a LiveFS CD

Re: CD/DVD ejecting after sysinstall

2010-08-20 Thread Rui Paulo
On 20 Aug 2010, at 20:46, Jim Riggs wrote: > References: > > http://www.mail-archive.com/svn-src-...@freebsd.org/msg24380.html > http://forums.freebsd.org/showthread.php?t=17126 > > > This commit automatically ejects the CD when sysinstall exits which almost > had dire consequences for me thi

Re: CD/DVD ejecting after sysinstall

2010-08-21 Thread Randi Harper
On Aug 20, 2010, at 14:21, Rui Paulo wrote: > > On 20 Aug 2010, at 20:46, Jim Riggs wrote: > >> References: >> >> http://www.mail-archive.com/svn-src-...@freebsd.org/msg24380.html >> http://forums.freebsd.org/showthread.php?t=17126 >> >> >> This commit automatically ejects the CD when sysins

Re: CD/DVD ejecting after sysinstall

2010-08-21 Thread Adam Vande More
On Sat, Aug 21, 2010 at 5:24 PM, Randi Harper wrote: > On Aug 20, 2010, at 14:21, Rui Paulo wrote: > > > > You are correct. We should not be ejecting the CD without a prompt. If > the commit is reverted, it should be explicitly noted in the code so that we > don't do this mistake again. > > > >

Re: CD/DVD ejecting after sysinstall

2010-08-22 Thread Dag-Erling Smørgrav
Randi Harper writes: > Rui Paulo writes: > > You are correct. We should not be ejecting the CD without a > > prompt. If the commit is reverted, it should be explicitly noted in > > the code so that we don't do this mistake again. > That's a judgement call, not an absolute. I think what we are doi