Re: CFR: lseek() POSIXed patch

2001-08-18 Thread Andrey A. Chernov
Updated variant: --- vfs_syscalls.c.old Sat Aug 11 02:14:18 2001 +++ vfs_syscalls.c Sun Aug 19 05:01:32 2001 @@ -1614,29 +1614,44 @@ register struct filedesc *fdp = p->p_fd; register struct file *fp; struct vattr vattr; - int error; + struct vnode *vp; +

Re: CFR: lseek() POSIXed patch

2001-08-15 Thread Andrey A. Chernov
On Wed, Aug 15, 2001 at 20:15:21 +1000, Bruce Evans wrote: > Something like: > > #define OFF_T_MAX 0x7FFF /* XXX */ > #define OFF_T_MIN (-0x7FFF - 1) /* XXX */ It seems that this defines often needed in many places. What about

Re: CFR: lseek() POSIXed patch

2001-08-15 Thread Bruce Evans
On Wed, 15 Aug 2001, Andrey A. Chernov wrote: > The patch below adds both cases, i.e. disallow negative seeks for VREG, > VDIR, VBLK and add off_t overflow checks. > > I plan to commit this, please review. > > --- vfs_syscalls.c.oldWed Aug 15 04:45:30 2001 > +++ vfs_syscalls.cWed Aug

CFR: lseek() POSIXed patch

2001-08-15 Thread Andrey A. Chernov
Here it is what POSIX says about lseek(): [EINVAL] The whence argument is not a proper value, or the resulting file offset would be negative for a regular file, block special file, or directory. [EOVERFLOW] The resulting file offset would be a value which cannot be represented correctly i