Re: PAM & OpenSSH: two incorrect "last login"

2002-04-22 Thread Andrey A. Chernov
On Mon, Apr 22, 2002 at 14:07:50 +0200, Dag-Erling Smorgrav wrote: > Bill Fenner <[EMAIL PROTECTED]> writes: > > You could either pretend that yflag was not set (what ache was > > suggesting) or set yflag if the year of the last login was not > > this year (possibly more useful). > > ...or always

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-22 Thread Bill Fenner
>Might, might not. ISTR strftime() can't correctly emulate ctime(), >but some other format might be preferrable. Do you have a format >string handy? I'd think something like what "last" does would be good. d_first = (*nl_langinfo(D_MD_ORDER) == 'd'); ... (void) strftime(ct,

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-22 Thread Dag-Erling Smorgrav
Bill Fenner <[EMAIL PROTECTED]> writes: > You could either pretend that yflag was not set (what ache was > suggesting) or set yflag if the year of the last login was not > this year (possibly more useful). ...or always print the year. Does anybody have any patches? :) DES -- Dag-Erling Smorgr

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-21 Thread Dag-Erling Smorgrav
Bill Fenner <[EMAIL PROTECTED]> writes: > While you're in here, does it make sense to use strftime() instead of > printing just a portion of what ctime returns? Might, might not. ISTR strftime() can't correctly emulate ctime(), but some other format might be preferrable. Do you have a format st

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-21 Thread Bill Fenner
While you're in here, does it make sense to use strftime() instead of printing just a portion of what ctime returns? This would allow i18n of the time format if desired (and if the locale is set this early -- maybe this is just a can of worms =). Bill To Unsubscribe: send mail to [EMAIL PROT

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-20 Thread Andrey A. Chernov
On Sat, Apr 20, 2002 at 20:20:01 +0400, Andrey A. Chernov wrote: > > Newlines are gone, but see second line from back 1991 (garbadge on the > stack of 'last_login_time' variable). BTW, please notice that printing this line is very conditionalized in OpenSSH: options.print_lastlog command == N

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-20 Thread Andrey A. Chernov
On Sat, Apr 20, 2002 at 18:10:50 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <[EMAIL PROTECTED]> writes: > > I got this TWO last login lines with recent -current SSH+PAM: > > See attached patch. It goes better and worse in the same time :-) Last login: Sat Apr 20 20:16:55 on ttyv4 L

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-20 Thread Dag-Erling Smorgrav
"Andrey A. Chernov" <[EMAIL PROTECTED]> writes: > I got this TWO last login lines with recent -current SSH+PAM: See attached patch. DES -- Dag-Erling Smorgrav - [EMAIL PROTECTED] //depot/user/des/pam/lib/libpam/modules/pam_lastlog/pam_lastlog.c#9 - /usr/src/lib/libpam/modules/pam_lastlo

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-20 Thread Andrey A. Chernov
On Sat, Apr 20, 2002 at 18:01:58 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <[EMAIL PROTECTED]> writes: > > This bug still present too. Please handle it somehow, it is clearly comes > > from PAM. > > Andrey, it's quite possible that you're Superman, but I'm not, so GIVE > ME A BREAK

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-20 Thread Dag-Erling Smorgrav
"Andrey A. Chernov" <[EMAIL PROTECTED]> writes: > This bug still present too. Please handle it somehow, it is clearly comes > from PAM. Andrey, it's quite possible that you're Superman, but I'm not, so GIVE ME A BREAK. I'm doing this one step at a time. It'll happen much faster if you stay off

Re: PAM & OpenSSH: two incorrect "last login"

2002-04-20 Thread Andrey A. Chernov
This bug still present too. Please handle it somehow, it is clearly comes from PAM. On Sat, Apr 20, 2002 at 05:16:35 +0400, Andrey A. Chernov wrote: > I got this TWO last login lines with recent -current SSH+PAM: > > -- > Last login: Sat Apr 20 04:50:45 > from hermes.dia

PAM & OpenSSH: two incorrect "last login"

2002-04-19 Thread Andrey A. Chernov
I got this TWO last login lines with recent -current SSH+PAM: -- Last login: Sat Apr 20 04:50:45 from hermes.dialup.ru Last login: Sat Apr 20 04:56:06 2002 from hermes.dialup.ru Copyright (c) 1980, 1983, 1986, 1988, 1990, 1991, 1993, 1994 ... -- T