Re: PORTS_MODULES fix

2012-06-17 Thread Doug Barton
On 06/09/2012 16:51, Doug Barton wrote: Ok, never mind the last one ... this patch I've actually tested. :) Committed to HEAD and MFC'ed. Thanks everyone for the feedback and help. Doug -- This .signature sanitized for your protection ___

PORTS_MODULES fix

2012-06-09 Thread Doug Barton
I have recently tried the PORTS_MODULES knob, and found a problem. The ports tree searches for some dependencies by finding a binary in PATH, and that fails since by default /usr/local/ isn't there. The attached patch fixes that problem. It would be more robust to use PREFIX there instead of

Re: PORTS_MODULES fix

2012-06-09 Thread Chris Rees
On 9 June 2012 18:15, Doug Barton do...@freebsd.org wrote: I have recently tried the PORTS_MODULES knob, and found a problem. The ports tree searches for some dependencies by finding a binary in PATH, and that fails since by default /usr/local/ isn't there. The attached patch fixes that

Re: PORTS_MODULES fix

2012-06-09 Thread Matthew Seaman
On 09/06/2012 18:26, Chris Rees wrote: On 9 June 2012 18:15, Doug Barton do...@freebsd.org wrote: I have recently tried the PORTS_MODULES knob, and found a problem. The ports tree searches for some dependencies by finding a binary in PATH, and that fails since by default /usr/local/ isn't

Re: PORTS_MODULES fix

2012-06-09 Thread Doug Barton
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On 06/09/2012 10:40, Matthew Seaman wrote: On 09/06/2012 18:26, Chris Rees wrote: On 9 June 2012 18:15, Doug Barton do...@freebsd.org wrote: I have recently tried the PORTS_MODULES knob, and found a problem. The ports tree searches for some

Re: PORTS_MODULES fix

2012-06-09 Thread Garrett Cooper
On Sat, Jun 9, 2012 at 11:06 AM, Doug Barton do...@freebsd.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On 06/09/2012 10:40, Matthew Seaman wrote: On 09/06/2012 18:26, Chris Rees wrote: On 9 June 2012 18:15, Doug Barton do...@freebsd.org wrote: I have recently tried the

Re: PORTS_MODULES fix

2012-06-09 Thread Doug Barton
Ok, after reading your PR and discussion on IRC I have the following which incorporates all the suggestions so far. I haven't actually tested this yet, but if people agree that this is the right direction to go I will before I commit it of course. Doug -- It's always a long day;

Re: PORTS_MODULES fix

2012-06-09 Thread Doug Barton
Ok, never mind the last one ... this patch I've actually tested. :) Doug -- This .signature sanitized for your protection Index: kern.post.mk === --- kern.post.mk(revision 236818) +++ kern.post.mk(working

Re: PORTS_MODULES fix

2012-06-09 Thread Garrett Cooper
On Jun 9, 2012, at 4:51 PM, Doug Barton wrote: Ok, never mind the last one ... this patch I've actually tested. :) This one looks good :) (and fixes the item I briefly mentioned in IRC); I'll test it one out. Thanks! -Garrett___