Re: Panics in recent NFS server

2021-05-31 Thread Rick Macklem
Mateusz Guzik wrote: >I reproduced the panic, things work for me with the patch below. >However, there may be more to it so I'm going to ask Rick to weigh in. >but short version is that length returned by nfsrv_parsename is off by >one compared to copyinstr. Yes, it appears that, now, ni_pathlen in

Re: Panics in recent NFS server

2021-05-31 Thread Dimitry Andric
Yes, this works for me too. I first tried reverting d81aefa8b7dd8cbeffeda541fca9962802404983, but this looked a bit more sane. :) -Dimitry > On 31 May 2021, at 17:03, Mateusz Guzik wrote: > > I reproduced the panic, things work for me with the patch below. > However, there may be more to it so

Re: Panics in recent NFS server

2021-05-31 Thread Rick Macklem
Mateusz Guzik wrote: >On 5/31/21, Mateusz Guzik wrote: >> It's probably my commit d81aefa8b7dd8cbeffeda541fca9962802404983 , >> I'll look at this later. > >Well let me rephrase. While the panic was added in said commit, I >suspect the bug is on nfs side -- it has its own namei variant which I >sus

Re: Panics in recent NFS server

2021-05-31 Thread Mateusz Guzik
I reproduced the panic, things work for me with the patch below. However, there may be more to it so I'm going to ask Rick to weigh in. but short version is that length returned by nfsrv_parsename is off by one compared to copyinstr. diff --git a/sys/fs/nfsserver/nfs_nfsdsubs.c b/sys/fs/nfsserver/

Re: Panics in recent NFS server

2021-05-31 Thread Mateusz Guzik
On 5/31/21, Mateusz Guzik wrote: > It's probably my commit d81aefa8b7dd8cbeffeda541fca9962802404983 , > I'll look at this later. Well let me rephrase. While the panic was added in said commit, I suspect the bug is on nfs side -- it has its own namei variant which I suspect is managing ni_pathlen

Re: Panics in recent NFS server

2021-05-31 Thread Mateusz Guzik
It's probably my commit d81aefa8b7dd8cbeffeda541fca9962802404983 , I'll look at this later. On 5/31/21, Dimitry Andric wrote: > Hi, > > I recently upgraded a -CURRENT NFS server from 2021-05-12 to today > (2021-05-31), and when the first NFS client attempted to connect, I got this > panic: > > pa

Panics in recent NFS server

2021-05-31 Thread Dimitry Andric
Hi, I recently upgraded a -CURRENT NFS server from 2021-05-12 to today (2021-05-31), and when the first NFS client attempted to connect, I got this panic: panic: lookup: expected nul at 0xf800104b3002; string [dim] cpuid = 0 time = 1622463863 KDB: stack backtrace: db_trace_self_wrapper() a