Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Ted Lindgreen
[Quoting Robert Watson, on Jun 9, 0:37, in Re: Re Regression: P ...] So one interesting question would be: if you ktrace on both 4.x and 5.x, do both pass in the bad value to close(), or is there something else in 5.x triggering the use of negative file descriptor numbers? I have no 4.x

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Alexander Leidinger
On Mon, 9 Jun 2003 10:28:33 +0200 [EMAIL PROTECTED] (Ted Lindgreen) wrote: However, I guess that mplayer has had this error already, but that a change in uthread_close.c as of May 31 has caused this problem to show up now. In particular: the unprotected usage of a very large value of fd in

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Ruslan Ermilov
On Mon, Jun 09, 2003 at 11:22:45AM +0200, Alexander Leidinger wrote: On Mon, 9 Jun 2003 10:28:33 +0200 [EMAIL PROTECTED] (Ted Lindgreen) wrote: However, I guess that mplayer has had this error already, but that a change in uthread_close.c as of May 31 has caused this problem to show up

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Ted Lindgreen
[Quoting Alexander Leidinger, on Jun 9, 11:23, in Re: Re Regression: P ...] shouldn't _close in uthread_close.c do some sanity check on fd before using it as an array index? Try the attached patch. + if ((fd 0) || (fd = _thread_dtablesize) || This test looks perfectly

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Alexander Leidinger
On Mon, 9 Jun 2003 14:33:11 +0200 [EMAIL PROTECTED] (Ted Lindgreen) wrote: I've tested it as cleanly as possible (make update, apply patch, make world/kernel, and portupgrade -f multimedia/mplayer). Is works fine and I haven't found any complications. I think it's save to commit. Someone

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Alexander Leidinger
On Mon, 9 Jun 2003 13:54:21 +0300 Ruslan Ermilov [EMAIL PROTECTED] wrote: This patch looks great. Please commit it. Done (rev 1.16). Bye, Alexander. -- Where do you think you're going today? http://www.Leidinger.net Alexander @ Leidinger.net GPG

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-09 Thread Alexander Leidinger
On Mon, 9 Jun 2003 13:07:44 -0500 (CDT) [EMAIL PROTECTED] wrote: I have mplayer in 4.8-STABLE and 5.1-RC1. What specifically would you like? The maintainer of mplayer is already looking into the problem. mplayer tries to close a file description which isn't open... it isn't even in the table of

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-08 Thread Arjan van Leeuwen
Indeed, a very dirty but effective fix. Thank you. I'll forward this to ports@ and lioux@, who has done all the recent updates on mplayer. Arjan On Sunday 08 June 2003 15:06, Ted Lindgreen wrote: Since a short time (don't know exactly when it happened) it's not possible anymore to play

Re: Re Regression: Playing QT files from mplayer stopped working in5.1

2003-06-08 Thread Robert Watson
On Sun, 8 Jun 2003, Arjan van Leeuwen wrote: Indeed, a very dirty but effective fix. Thank you. I'll forward this to ports@ and lioux@, who has done all the recent updates on mplayer. So one interesting question would be: if you ktrace on both 4.x and 5.x, do both pass in the bad value to