Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-12-01 Thread Rick Macklem
urr...@freebsd.org> on behalf of Rick Macklem <rmack...@uoguelph.ca> Sent: Wednesday, November 29, 2017 12:28:05 PM To: Emmanuel Vadot Cc: Konstantin Belousov; FreeBSD Current; freebsd...@freebsd.org Subject: Re: Switch vfs.nfsd.issue_delegations to TUNABLE ? Emmanuel Vadot wrote: [stuff

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-29 Thread Rick Macklem
Emmanuel Vadot wrote: [stuff snipped] > I haven't test by I can say that it will work, I actually wondered at >first doing that. The problem with this patch is what I tried to >describe in my first and following mails, since you can turn on and off >delegation you can still have delegation (so

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-29 Thread Emmanuel Vadot
ovember 28, 2017 6:17:13 PM > To: Emmanuel Vadot > Cc: Konstantin Belousov; FreeBSD Current; freebsd...@freebsd.org; Rick Macklem > Subject: Re: Switch vfs.nfsd.issue_delegations to TUNABLE ? > > I think the attached patch should fix your performance problem. > It simply check

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Rick Macklem
ct: Re: Switch vfs.nfsd.issue_delegations to TUNABLE ? I think the attached patch should fix your performance problem. It simply checks for nfsrv_delegatecnt != 0 before doing all the locking stuff in nfsrv_checkgetattr(). If this fixes your performance problem (with delegations disabled), I'll pr

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Rick Macklem
dot Cc: Konstantin Belousov; FreeBSD Current; freebsd...@freebsd.org; Rick Macklem Subject: Re: Switch vfs.nfsd.issue_delegations to TUNABLE ? Emmanuel Vadot wrote: >I wrote: >> Since it defaults to "disabled", I don't see why a tunable would be >> necessary? >> (

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Rick Macklem
Emmanuel Vadot wrote: >I wrote: >> Since it defaults to "disabled", I don't see why a tunable would be >> necessary? >> (Just do nothing and delegations don't happen. If you want the server >> to issue delegations, then use the sysctl to turn them on. If you want to >> turn >> them off again

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Emmanuel Vadot
On Tue, 28 Nov 2017 14:12:38 + Rick Macklem wrote: > Konstantin Belousov wrote: > >On Tue, Nov 28, 2017 at 02:26:10PM +0100, Emmanuel Vadot wrote: > >> On Tue, 28 Nov 2017 13:04:28 +0200 > >> Konstantin Belousov wrote: > >> > >> > On Tue, Nov 28,

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Emmanuel Vadot
On Tue, 28 Nov 2017 15:40:09 +0200 Konstantin Belousov wrote: > On Tue, Nov 28, 2017 at 02:26:10PM +0100, Emmanuel Vadot wrote: > > On Tue, 28 Nov 2017 13:04:28 +0200 > > Konstantin Belousov wrote: > > > > > On Tue, Nov 28, 2017 at 11:41:36AM +0100,

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Rick Macklem
Konstantin Belousov wrote: >On Tue, Nov 28, 2017 at 02:26:10PM +0100, Emmanuel Vadot wrote: >> On Tue, 28 Nov 2017 13:04:28 +0200 >> Konstantin Belousov wrote: >> >> > On Tue, Nov 28, 2017 at 11:41:36AM +0100, Emmanuel Vadot wrote: >> > > >> > > Hello, >> > > >> > > I would

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Konstantin Belousov
On Tue, Nov 28, 2017 at 02:26:10PM +0100, Emmanuel Vadot wrote: > On Tue, 28 Nov 2017 13:04:28 +0200 > Konstantin Belousov wrote: > > > On Tue, Nov 28, 2017 at 11:41:36AM +0100, Emmanuel Vadot wrote: > > > > > > Hello, > > > > > > I would like to switch the

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Emmanuel Vadot
On Tue, 28 Nov 2017 13:04:28 +0200 Konstantin Belousov wrote: > On Tue, Nov 28, 2017 at 11:41:36AM +0100, Emmanuel Vadot wrote: > > > > Hello, > > > > I would like to switch the vfs.nfsd.issue_delegations sysctl to a > > tunable. > > The reason behind it is recent

Re: Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Konstantin Belousov
On Tue, Nov 28, 2017 at 11:41:36AM +0100, Emmanuel Vadot wrote: > > Hello, > > I would like to switch the vfs.nfsd.issue_delegations sysctl to a > tunable. > The reason behind it is recent problem at work on some on our filer > related to NFS. > We use NFSv4 without delegation as we never

Switch vfs.nfsd.issue_delegations to TUNABLE ?

2017-11-28 Thread Emmanuel Vadot
Hello, I would like to switch the vfs.nfsd.issue_delegations sysctl to a tunable. The reason behind it is recent problem at work on some on our filer related to NFS. We use NFSv4 without delegation as we never been able to have good performance with FreeBSD server and Linux client (we need