Re: Updated if_* attach/detach patches

2003-03-21 Thread Matthew N. Dodd
On Wed, 19 Mar 2003, Nate Lawson wrote: Patches are at: http://www.root.org/~nate/freebsd/if_pci/ I'd like to see calls to mtx_destroy() protected by a test for mtx_initialized(). In most cases this isn't strictly necessary but its not bad practice. -- | Matthew N. Dodd | '78 Datsun

Re: Updated if_* attach/detach patches

2003-03-21 Thread Nate Lawson
On Fri, 21 Mar 2003, Matthew N. Dodd wrote: On Wed, 19 Mar 2003, Nate Lawson wrote: Patches are at: http://www.root.org/~nate/freebsd/if_pci/ I'd like to see calls to mtx_destroy() protected by a test for mtx_initialized(). In most cases this isn't strictly necessary but its not

Re: Updated if_* attach/detach patches

2003-03-21 Thread Matthew N. Dodd
On Fri, 21 Mar 2003, Nate Lawson wrote: Perhaps I should add a comment mentioning my assumption: mtx_init is one of the first things called and since detach unconditionally locks the mtx, it should never be called unless the mutex is initialized. This isn't the case for all drivers and the

Re: Updated if_* attach/detach patches

2003-03-20 Thread Steve Kargl
On Wed, Mar 19, 2003 at 10:37:43AM -0800, Nate Lawson wrote: I have updated my patches for: dc pcn rl sf sis sk ste ti tl vr wb xl They have been compile tested but I only have an rl card so I'd appreciate feedback. - xl: add missed error setting in I/O, memory mapping cases - xl: add

Re: Updated if_* attach/detach patches

2003-03-20 Thread Nate Lawson
On Thu, 20 Mar 2003, Steve Kargl wrote: On Wed, Mar 19, 2003 at 10:37:43AM -0800, Nate Lawson wrote: I have updated my patches for: dc pcn rl sf sis sk ste ti tl vr wb xl They have been compile tested but I only have an rl card so I'd appreciate feedback. - xl: add missed error

Re: Updated if_* attach/detach patches

2003-03-20 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Nate Lawson [EMAIL PROTECTED] writes: : - dc: move interrupt allocation back where it was before. It was unnecessary : to move it Why's that? If dc is on a shared interrupt line, then dc_intr is going to be called, potentially, before the rest of the

Updated if_* attach/detach patches

2003-03-19 Thread Nate Lawson
I have updated my patches for: dc pcn rl sf sis sk ste ti tl vr wb xl They have been compile tested but I only have an rl card so I'd appreciate feedback. Patches are at: http://www.root.org/~nate/freebsd/if_pci/ Clean up locking and resource management for pci/if_* - Remove locking of

Re: Updated if_* attach/detach patches

2003-03-19 Thread Nate Lawson
I had forgotten to cvsup before generating the diff so I have updated them in place after resolving conflicts. Only rl and xl have changed. -Nate To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message

Re: Updated if_* attach/detach patches

2003-03-19 Thread Jake Burkholder
Apparently, On Wed, Mar 19, 2003 at 10:37:43AM -0800, Nate Lawson said words to the effect of; I have updated my patches for: dc pcn rl sf sis sk ste ti tl vr wb xl They have been compile tested but I only have an rl card so I'd appreciate feedback. Patches are at: