Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-16 Thread Andriy Gapon
I've discovered another issue with both the current code and the previous versions of the patch. So another version is at the same URL: http://people.freebsd.org/~avg/zfs-boot-gang.diff The problem was with gang blocks on a raidz vdev. zio_read_gang would pass a NULL bp to vdev_raidz_read, but

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-13 Thread Andriy Gapon
on 07/09/2011 19:35 Andriy Gapon said the following: on 02/09/2011 16:35 Andriy Gapon said the following: Then: - obtain this patch http://people.freebsd.org/~avg/zfstest.head.diff - cd sys/boot/zfs - apply the patch to zfstest.c - cc -I. -I../../cddl/boot/zfs zfstest.c -o zfstest - run the

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-11 Thread Andriy Gapon
on 10/09/2011 14:03 Peter Jeremy said the following: On 2011-Sep-10 12:46:50 +0300, Andriy Gapon a...@freebsd.org wrote: on 10/09/2011 11:07 Andriy Gapon said the following: Actually, removing either -mrtd _or_ -fno-unit-at-a-time produces the correct code. Puzzled. The problem is

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-11 Thread Andriy Gapon
on 11/09/2011 11:31 Andriy Gapon said the following: And I am actually wondering about -fno-unit-at-a-time option. In my opinion this is an anti-optimization option and it can actually increase a size of a final binary. In fact, it looks like the option was introduced to boot2 in r132870 in

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-11 Thread Peter Jeremy
On 2011-Sep-11 11:31:54 +0300, Andriy Gapon a...@freebsd.org wrote: And I am actually wondering about -fno-unit-at-a-time option. In my opinion this is an anti-optimization option and it can actually increase a size of a final binary. In fact, it looks like the option was introduced to boot2 in

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-11 Thread Nathan Whitehorn
On 09/11/11 13:31, Peter Jeremy wrote: On 2011-Sep-11 11:31:54 +0300, Andriy Gapona...@freebsd.org wrote: And I am actually wondering about -fno-unit-at-a-time option. In my opinion this is an anti-optimization option and it can actually increase a size of a final binary. In fact, it looks

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-11 Thread Scot Hetzel
On Sun, Sep 11, 2011 at 6:31 AM, Peter Jeremy peterjer...@acm.org wrote: In any case, size isn't an issue for any of gptboot, gptzfsboot or zfsboot (unlike boot2).  For that matter, why do we need both gptboot and gptzfsboot?  It would be more convenient to have a single GPT bootstrap that

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-10 Thread Andriy Gapon
on 07/09/2011 19:35 Andriy Gapon said the following: Thanks to a lot of excellent testing, debugging and analysis from Sebastian (which went behind the scenes) we now have this patch: http://people.freebsd.org/~avg/zfs-boot-gang.diff The patch introduces the following changes: - checksum

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-10 Thread Andriy Gapon
on 10/09/2011 10:32 Andriy Gapon said the following: I am now investigating what looks like a miscompilation of the code by *gcc* after applying the patch. It seems that -mrtd option is to blame. I have found an older discussion about the -mrtd option causing trouble with clang:

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-10 Thread Andriy Gapon
on 10/09/2011 11:07 Andriy Gapon said the following: Actually, removing either -mrtd _or_ -fno-unit-at-a-time produces the correct code. Puzzled. The problem is reproducible with base gcc and gcc42, it is not reproducible with gcc45, gcc46 and clang. -- Andriy Gapon

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-10 Thread Peter Jeremy
On 2011-Sep-10 12:46:50 +0300, Andriy Gapon a...@freebsd.org wrote: on 10/09/2011 11:07 Andriy Gapon said the following: Actually, removing either -mrtd _or_ -fno-unit-at-a-time produces the correct code. Puzzled. The problem is reproducible with base gcc and gcc42, it is not reproducible with

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-07 Thread Andriy Gapon
on 02/09/2011 16:35 Andriy Gapon said the following: Then: - obtain this patch http://people.freebsd.org/~avg/zfstest.head.diff - cd sys/boot/zfs - apply the patch to zfstest.c - cc -I. -I../../cddl/boot/zfs zfstest.c -o zfstest - run the resulting binary as root and provide your pool

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-07 Thread Peter Jeremy
On 2011-Sep-07 19:35:09 +0300, Andriy Gapon a...@freebsd.org wrote: Thanks to a lot of excellent testing, debugging and analysis from Sebastian (which went behind the scenes) we now have this patch: http://people.freebsd.org/~avg/zfs-boot-gang.diff ... If you use compression for a filesystem where

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-05 Thread Sebastian Chmielewski
On Fri, 02 Sep 2011 17:01:56 +0200 Henri Hennebert h...@restart.be wrote: I encounter the same problem. I reboot with mfsBSD and run zpool scrub without error. I reboot and get the same error - the error msg repeating 4 or 5 times. Do you have lzjb compression in your pool? My pool does

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-05 Thread Henri Hennebert
On 09/05/2011 19:51, Sebastian Chmielewski wrote: On Fri, 02 Sep 2011 17:01:56 +0200 Henri Henneberth...@restart.be wrote: I encounter the same problem. I reboot with mfsBSD and run zpool scrub without error. I reboot and get the same error - the error msg repeating 4 or 5 times. Do you

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-02 Thread Andriy Gapon
on 01/09/2011 23:36 Sebastian Chmielewski said the following: hi, I'm running FreeBSD-CURRENT r224522M installed on ZFS Root and GPT partitions and this setup is running fine. Today I've updated to r225312 and after rebooting I've got following error message from boot loader: ZFS: i/o

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-02 Thread Henri Hennebert
On 09/01/2011 22:36, Sebastian Chmielewski wrote: hi, I'm running FreeBSD-CURRENT r224522M installed on ZFS Root and GPT partitions and this setup is running fine. Today I've updated to r225312 and after rebooting I've got following error message from boot loader: ZFS: i/o error - all

ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-01 Thread Sebastian Chmielewski
hi, I'm running FreeBSD-CURRENT r224522M installed on ZFS Root and GPT partitions and this setup is running fine. Today I've updated to r225312 and after rebooting I've got following error message from boot loader: ZFS: i/o error - all block copies unavailable Then I did zfs rollback using

Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312

2011-09-01 Thread Sebastian Chmielewski
On Thu, 1 Sep 2011 22:36:46 +0200 Sebastian Chmielewski chmi...@o2.pl wrote: after rebooting I've got following error message from boot loader: ZFS: i/o error - all block copies unavailable I'm very puzzled with this, in theory 'make installkernel' shouldn't break boot process at this stage