Re: asio and kqueue (2nd trye) (was: RE: (boost::)asio and kqueue problem)

2016-10-14 Thread Scott Mitchell
Patch generally lgtm ... just 1 nit comment: + } else { + if (sbavail(&so->so_rcv) >= so->so_rcv.sb_lowat) + return 1; + } Collapse the else and the block inside to just make it an `else if` for less branching. On

Re: asio and kqueue (2nd trye) (was: RE: (boost::)asio and kqueue problem)

2016-10-14 Thread Konstantin Belousov
On Fri, Oct 14, 2016 at 09:21:52AM +, hartmut.bra...@dlr.de wrote: > Hi all, > > here is the 2nd try taking into account the comments I received. Since I'm > not familiar with the locking in the sockets area I ask somebody with that > knowledge to check it before I commit it. I have only st

asio and kqueue (2nd trye) (was: RE: (boost::)asio and kqueue problem)

2016-10-14 Thread Hartmut.Brandt
Hi all, here is the 2nd try taking into account the comments I received. Since I'm not familiar with the locking in the sockets area I ask somebody with that knowledge to check it before I commit it. Thanks, harti From: Scott Mitchell [mailto:scott.k.mit...@gmail.com] Sent: Friday, October