Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-10-07 Thread Craig Rodrigues
On Fri, Sep 30, 2011 at 2:12 PM, Jaakko Heinonen j...@freebsd.org wrote: Looks mostly OK to me. Why do you use printf() + exit() here and errx() in atacontrol? Is there reason to not use errx() also here? errx(3) adds a newline character to the output. Thus the latter '\n' is redundant.

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-30 Thread Jaakko Heinonen
On 2011-09-29, Craig Rodrigues wrote: On Wed, Sep 28, 2011 at 1:15 AM, Jaakko Heinonen j...@freebsd.org wrote: I think that using the FEATURE() macro and feature_present(3) might be more appropriate for this. Oh, OK. I was unfamiliar with these API's because they are new in FreeBSD 8.

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-29 Thread Craig Rodrigues
On Wed, Sep 28, 2011 at 1:15 AM, Jaakko Heinonen j...@freebsd.org wrote: I think that using the FEATURE() macro and feature_present(3) might be more appropriate for this. Thanks. -- Jaakko Oh, OK. I was unfamiliar with these API's because they are new in FreeBSD 8. :) How about the

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-29 Thread Arnaud Lacombe
Hi, On Thu, Sep 29, 2011 at 6:20 PM, Craig Rodrigues rodr...@crodrigues.org wrote: On Wed, Sep 28, 2011 at 1:15 AM, Jaakko Heinonen j...@freebsd.org wrote: I think that using the FEATURE() macro and feature_present(3) might be more appropriate for this. Thanks. -- Jaakko Oh, OK.  I was

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-28 Thread Jaakko Heinonen
On 2011-09-27, Craig Rodrigues wrote: I think we need something like the following patch. +#ifdef ATA_CAM +SYSCTL_INT(_hw_ata, OID_AUTO, ata_cam_enabled, + CTLFLAG_RD, ata_cam_enabled, 1, + ATA devices are accessed through the cam(4) driver); +#endif I think that using the

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-27 Thread Hartmann, O.
On 09/27/11 03:12, Eitan Adler wrote: The alternative is to fix burncd or backout the acd0 to cd0 change from 9.0 which may be the most desired solution because its obvious that no one researched the impact this change may have. This change may impact many ports that access cd/dvd drives for

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-27 Thread Craig Rodrigues
On Mon, Sep 26, 2011 at 9:10 PM, Garrett Cooper yaneg...@gmail.com wrote: Noting something in the documentation is fine. The point is that there's a lot of wasted electrons being tossed about about a fairly trivial issue: most of the apps that burn/use CDs were converted over to some logic

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-27 Thread Craig Rodrigues
On Mon, Sep 26, 2011 at 9:23 PM, Adrian Chadd adr...@freebsd.org wrote: .. and if someone would like to contribute patches to burncd to update it, I think there'd be at least one committer here who would be happy to help you get your changes into the tree. :-) Hi, I think we need something

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Fbsd8
ead...@freebsd.org wrote: Synopsis: 9.0 burncd error caused by change to cd0 from acd0 State-Changed-From-To: open-analyzed State-Changed-By: eadler State-Changed-When: Mon Sep 26 23:24:00 UTC 2011 State-Changed-Why: requires only a release notes entry; use cdrecord instead of burncd

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Eitan Adler
The alternative is to fix burncd or backout the acd0 to cd0 change from 9.0 which may be the most desired solution because its obvious that no one researched the impact this change may have. This change may impact many ports that access cd/dvd drives for read and write access. burncd may be a

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Glen Barber
On 9/26/11 8:59 PM, Fbsd8 wrote: ead...@freebsd.org wrote: Synopsis: 9.0 burncd error caused by change to cd0 from acd0 State-Changed-Why: requires only a release notes entry; use cdrecord instead of burncd The alternative is to fix burncd or backout the acd0 to cd0 change from 9.0 which

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Doug Barton
On 09/26/2011 17:59, Fbsd8 wrote: Your solution is very un-professional. Good thing we're all volunteers. :) What your solution purposes to do is do nothing. I think your judgment is flawed and a larger group of your peers need to review your judgment in this case. Ok, done. Eitan is

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Craig Rodrigues
On Mon, Sep 26, 2011 at 6:28 PM, Doug Barton do...@freebsd.org wrote: burncd has been part of the system utilities included in the basic release since release 4.0 and cdrecord is a port. The professional solution is to remove burncd from the 9.0 system release and add the cdrecord command to

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Doug Barton
On 09/26/2011 18:43, Craig Rodrigues wrote: On Mon, Sep 26, 2011 at 6:28 PM, Doug Barton do...@freebsd.org wrote: burncd has been part of the system utilities included in the basic release since release 4.0 and cdrecord is a port. The professional solution is to remove burncd from the 9.0

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Craig Rodrigues
On Mon, Sep 26, 2011 at 6:58 PM, Doug Barton do...@freebsd.org wrote: I have used burncd on many releases of FreeBSD, on many machines without problem.  I can see the fact that burncd suddenly failing to work on ATAPI hardware could annoy and confused end-users. It doesn't fail to work on

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Garrett Cooper
On Mon, 26 Sep 2011, Craig Rodrigues wrote: On Mon, Sep 26, 2011 at 6:58 PM, Doug Barton do...@freebsd.org wrote: I have used burncd on many releases of FreeBSD, on many machines without problem.  I can see the fact that burncd suddenly failing to work on ATAPI hardware could annoy and

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Craig Rodrigues
On Mon, Sep 26, 2011 at 8:30 PM, Garrett Cooper yaneg...@gmail.com wrote: ...        Please fix it and move on. Thanks, -Garrett $ usr.sbin/burncd/burncd -f /dev/cd0 blank burncd: device provided not an acd(4) device: /dev/cd0. Please verify that your kernel is built with acd(4) and the

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Garrett Cooper
On Mon, 26 Sep 2011, Craig Rodrigues wrote: On Mon, Sep 26, 2011 at 8:30 PM, Garrett Cooper yaneg...@gmail.com wrote: ...        Please fix it and move on. Thanks, -Garrett $ usr.sbin/burncd/burncd -f /dev/cd0 blank burncd: device provided not an acd(4) device: /dev/cd0. Please verify that

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-26 Thread Adrian Chadd
.. and if someone would like to contribute patches to burncd to update it, I think there'd be at least one committer here who would be happy to help you get your changes into the tree. :-) Adrian ___ freebsd-current@freebsd.org mailing list

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-25 Thread Fbsd8
Jaakko Heinonen wrote: On 2011-09-24, Joe Barbish wrote: It seems that in 9.0 the cd/dvd/drive is now given a dev name of cd0 where in all previous releases it was acd0. Tried to use the system burncd command in 9.0 and got this error msg burncd: ioctl(CDRIOCGETBLOCKSIZE): Inappropriate

Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

2011-09-25 Thread Eric Masson
Fbsd8 fb...@a1poweruser.com writes: Hi, Fixing burncd should be a priority It's not broken, so it doesn't need to be fixed. burncd has been designed to work with the old ata stack, when using new cam based ata stack, just use cdrecord. It deserves an entry in the release notes, nothing less,