Re: extattr_set_*() return type

2011-12-21 Thread John Baldwin
On Tuesday, December 20, 2011 5:18:58 pm m...@freebsd.org wrote: On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin j...@freebsd.org wrote: Hmm, if these functions are expected to operate like 'write(2)' and are supposed to return the number of bytes written, shouldn't their return value be

Re: extattr_set_*() return type

2011-12-21 Thread Robert N. M. Watson
On 21 Dec 2011, at 15:31, John Baldwin wrote: On Tuesday, December 20, 2011 5:18:58 pm m...@freebsd.org wrote: On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin j...@freebsd.org wrote: Hmm, if these functions are expected to operate like 'write(2)' and are supposed to return the number of bytes

Re: extattr_set_*() return type

2011-12-21 Thread Kostik Belousov
On Wed, Dec 21, 2011 at 10:31:11AM -0500, John Baldwin wrote: On Tuesday, December 20, 2011 5:18:58 pm m...@freebsd.org wrote: On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin j...@freebsd.org wrote: Hmm, if these functions are expected to operate like 'write(2)' and are supposed to return

Re: extattr_set_*() return type

2011-12-21 Thread John Baldwin
On Wednesday, December 21, 2011 11:13:10 am Kostik Belousov wrote: On Wed, Dec 21, 2011 at 10:31:11AM -0500, John Baldwin wrote: On Tuesday, December 20, 2011 5:18:58 pm m...@freebsd.org wrote: On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin j...@freebsd.org wrote: Hmm, if these functions

Re: extattr_set_*() return type

2011-12-21 Thread John Baldwin
On Wednesday, December 21, 2011 11:02:24 am Robert N. M. Watson wrote: On 21 Dec 2011, at 15:31, John Baldwin wrote: On Tuesday, December 20, 2011 5:18:58 pm m...@freebsd.org wrote: On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin j...@freebsd.org wrote: Hmm, if these functions are

Re: extattr_set_*() return type

2011-12-21 Thread Kostik Belousov
On Wed, Dec 21, 2011 at 12:25:18PM -0500, John Baldwin wrote: On Wednesday, December 21, 2011 11:13:10 am Kostik Belousov wrote: On Wed, Dec 21, 2011 at 10:31:11AM -0500, John Baldwin wrote: On Tuesday, December 20, 2011 5:18:58 pm m...@freebsd.org wrote: On Tue, Dec 20, 2011 at 1:49 PM,

Re: extattr_set_*() return type

2011-12-21 Thread John Baldwin
On Wednesday, December 21, 2011 3:28:42 pm Kostik Belousov wrote: On Wed, Dec 21, 2011 at 12:25:18PM -0500, John Baldwin wrote: On Wednesday, December 21, 2011 11:13:10 am Kostik Belousov wrote: On Wed, Dec 21, 2011 at 10:31:11AM -0500, John Baldwin wrote: On Tuesday, December 20, 2011

extattr_set_*() return type

2011-12-20 Thread John Baldwin
Hmm, if these functions are expected to operate like 'write(2)' and are supposed to return the number of bytes written, shouldn't their return value be 'ssize_t' instead of 'int'? It looks like the system calls themselves already do the right thing in setting td_retval[] (they assign a ssize_t

Re: extattr_set_*() return type

2011-12-20 Thread mdf
On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin j...@freebsd.org wrote: Hmm, if these functions are expected to operate like 'write(2)' and are supposed to return the number of bytes written, shouldn't their return value be 'ssize_t' instead of 'int'?  It looks like the system calls themselves