Re: knlist_empty locking fix

2012-01-27 Thread John Baldwin
On Friday, January 27, 2012 2:14:55 pm Doug Ambrisko wrote: > John Baldwin writes: > | On Friday, January 27, 2012 12:52:18 pm Kostik Belousov wrote: > | > On Fri, Jan 27, 2012 at 09:42:58AM -0800, Doug Ambrisko wrote: > | > > Andrew Boyer writes: > | > > | On Jan 27, 2012, at 12:15 PM, Doug Ambris

Re: knlist_empty locking fix

2012-01-27 Thread Doug Ambrisko
John Baldwin writes: | On Friday, January 27, 2012 12:52:18 pm Kostik Belousov wrote: | > On Fri, Jan 27, 2012 at 09:42:58AM -0800, Doug Ambrisko wrote: | > > Andrew Boyer writes: | > > | On Jan 27, 2012, at 12:15 PM, Doug Ambrisko wrote: | > > | | > > | > John Baldwin writes: | > > | > | Agreed,

Re: knlist_empty locking fix

2012-01-27 Thread John Baldwin
On Friday, January 27, 2012 12:52:18 pm Kostik Belousov wrote: > On Fri, Jan 27, 2012 at 09:42:58AM -0800, Doug Ambrisko wrote: > > Andrew Boyer writes: > > | On Jan 27, 2012, at 12:15 PM, Doug Ambrisko wrote: > > | > > | > John Baldwin writes: > > | > | Agreed, I think the missing locking should

Re: knlist_empty locking fix

2012-01-27 Thread Kostik Belousov
On Fri, Jan 27, 2012 at 09:42:58AM -0800, Doug Ambrisko wrote: > Andrew Boyer writes: > | On Jan 27, 2012, at 12:15 PM, Doug Ambrisko wrote: > | > | > John Baldwin writes: > | > | Agreed, I think the missing locking should just be added to the aio > code. > | > > | > Okay so then just: > | > >

Re: knlist_empty locking fix

2012-01-27 Thread Andrew Boyer
On Jan 27, 2012, at 12:15 PM, Doug Ambrisko wrote: > John Baldwin writes: > | Agreed, I think the missing locking should just be added to the aio code. > > Okay so then just: > > Index: vfs_aio.c > === > RCS file: /usr/local/cvsroot

Re: knlist_empty locking fix

2012-01-27 Thread Doug Ambrisko
Andrew Boyer writes: | On Jan 27, 2012, at 12:15 PM, Doug Ambrisko wrote: | | > John Baldwin writes: | > | Agreed, I think the missing locking should just be added to the aio code. | > | > Okay so then just: | > | > Index: vfs_aio.c | > ===

Re: knlist_empty locking fix

2012-01-27 Thread Doug Ambrisko
John Baldwin writes: | On Friday, January 27, 2012 3:56:56 am Kostik Belousov wrote: | > On Thu, Jan 26, 2012 at 01:03:26PM -0800, Doug Ambrisko wrote: | > > Ran into problems with running kqueue/aio with WITNESS etc. Sometimes | > > things are locked sometimes not. knlist_remove is called tellin

Re: knlist_empty locking fix

2012-01-27 Thread John Baldwin
On Friday, January 27, 2012 3:56:56 am Kostik Belousov wrote: > On Thu, Jan 26, 2012 at 01:03:26PM -0800, Doug Ambrisko wrote: > > Ran into problems with running kqueue/aio with WITNESS etc. Sometimes > > things are locked sometimes not. knlist_remove is called telling it > > whether it is locked

Re: knlist_empty locking fix

2012-01-27 Thread Kostik Belousov
On Thu, Jan 26, 2012 at 01:03:26PM -0800, Doug Ambrisko wrote: > Ran into problems with running kqueue/aio with WITNESS etc. Sometimes > things are locked sometimes not. knlist_remove is called telling it > whether it is locked or not ie: >extern voidknlist_remove(struct knlist *knl,

knlist_empty locking fix

2012-01-26 Thread Doug Ambrisko
Ran into problems with running kqueue/aio with WITNESS etc. Sometimes things are locked sometimes not. knlist_remove is called telling it whether it is locked or not ie: extern voidknlist_remove(struct knlist *knl, struct knote *kn, int islocked); so I changed: extern int