on 10/11/2010 20:45 Alan Cox said the following:
> Andriy Gapon wrote:
>> on 09/11/2010 10:02 Alan Cox said the following:
>>
>>> The kernel portion of the patch looks correct. If I were to make one
>>> stylistic
>>> suggestion, it would be to make the control flow of the outer and inner
>>> l
Andriy Gapon wrote:
on 09/11/2010 10:02 Alan Cox said the following:
The kernel portion of the patch looks correct. If I were to make one stylistic
suggestion, it would be to make the control flow of the outer and inner loops as
similar as possible, that is,
for (...
if ((pdp[i] &
on 09/11/2010 10:02 Alan Cox said the following:
> The kernel portion of the patch looks correct. If I were to make one
> stylistic
> suggestion, it would be to make the control flow of the outer and inner loops
> as
> similar as possible, that is,
>
>for (...
> if ((pdp[i] & PG_V) ==
Andriy Gapon wrote:
So, here is the next version of the patch:
http://people.freebsd.org/~avg/amd64-minidump.4.diff
Changes since the last version:
1. libkvm - try to support both the new and the previous formats/versions of
amd64 minidump. I am not entirely sure about style in which I handled
on 04/11/2010 08:05 Alan Cox said the following:
>
> There is actually a point to using PG_PS_FRAME. The PAT bit for a 2MB page
> mapping occupies a bit that is a part of the physical page number with
> PG_FRAME.
> I suspect that the same is true of 1GB page mappings, but I haven't double
> ch
Andriy Gapon wrote:
on 03/11/2010 20:44 Alan Cox said the following:
[snip]
Thank you for the confirmation!
Andriy Gapon wrote:
P.S. is there a macro for extracting frame address from PDPE?
To a lower level page table page or to a 1GB physical page? For the latter, you
can us
So, here is the next version of the patch:
http://people.freebsd.org/~avg/amd64-minidump.4.diff
Changes since the last version:
1. libkvm - try to support both the new and the previous formats/versions of
amd64 minidump. I am not entirely sure about style in which I handled handling
of version 1
on 03/11/2010 20:44 Alan Cox said the following:
[snip]
Thank you for the confirmation!
> Andriy Gapon wrote:
>> P.S. is there a macro for extracting frame address from PDPE?
> To a lower level page table page or to a 1GB physical page? For the latter,
> you
> can use PG_PS_FRAME.
To a 1GB pag
on 08/10/2010 10:46 Alan Cox said the following:
> Andriy Gapon wrote:
>> Here's an updated patch:
>> http://people.freebsd.org/~avg/amd64-minidump.3.diff
>
> The kernel part of the patch looks good. That said, I have one suggestion.
> The
> current generation of AMD and Intel processors has su
Andriy Gapon wrote:
on 01/10/2010 10:43 Andriy Gapon said the following:
The idea. We dump contiguously only pages with PDEs (which means both valid and
invalid PDEs), valid pages with PTEs are dumped the same way as data physical
pages (i.e. via dump_add_page, etc); no fake PTEs for 2MB pag
on 01/10/2010 10:43 Andriy Gapon said the following:
> The idea. We dump contiguously only pages with PDEs (which means both valid
> and
> invalid PDEs), valid pages with PTEs are dumped the same way as data physical
> pages (i.e. via dump_add_page, etc); no fake PTEs for 2MB pages.
> PDE area of
on 30/09/2010 01:26 Alan Cox said the following:
> On 9/29/2010 3:41 PM, Andriy Gapon wrote:
>> So perhaps we need to add another level of indirection?
>> I.e. first dump contiguous array of "pseudo-pde" entries that would point to
>> chunks of "pseudo-pte" entries, so that "pseudo-pte" entries co
On 9/29/2010 3:41 PM, Andriy Gapon wrote:
on 27/09/2010 20:54 Andriy Gapon said the following:
It seems that minidump on amd64 is always dumping at least about 1GB of data
regardless of actual memory size and usage and thus can be even larger than
regular dump.
Specifically, I suspect the foll
on 27/09/2010 20:54 Andriy Gapon said the following:
>
> It seems that minidump on amd64 is always dumping at least about 1GB of data
> regardless of actual memory size and usage and thus can be even larger than
> regular dump.
>
> Specifically, I suspect the following code:
> for (va = VM_MIN_KE
It seems that minidump on amd64 is always dumping at least about 1GB of data
regardless of actual memory size and usage and thus can be even larger than
regular dump.
Specifically, I suspect the following code:
for (va = VM_MIN_KERNEL_ADDRESS; va < MAX(KERNBASE + NKPT * NBPDR,
kernel_vm_end);
15 matches
Mail list logo
