Re: pfind_locked(pid) fails when in a jail?

2017-10-17 Thread Ian Lepore
On Tue, 2017-10-17 at 21:26 +, Rick Macklem wrote: > Mateusz Guzik wrote: > [lots of stuff snipped] > > > > I proposed registration of per-process callbacks, not filtering. > > The code would just walk the list/table/whatever and call everything on > > it - they asked for it. > Yep, this

Re: pfind_locked(pid) fails when in a jail?

2017-10-17 Thread Rick Macklem
Mateusz Guzik wrote: [lots of stuff snipped] > I proposed registration of per-process callbacks, not filtering. > The code would just walk the list/table/whatever and call everything on > it - they asked for it. Yep, this would work for the NFSv4 client. Way back when, all I did in OpenBSD was add

Re: pfind_locked(pid) fails when in a jail?

2017-10-17 Thread Ian Lepore
On Tue, 2017-10-17 at 00:08 +, Rick Macklem wrote: > [stuff snipped] > > > > > > > > > > > > > > > > pfind* does not do any filtering. > > > > Hmm, well I have no idea why the jailed mounts get looping in here then. > > > > > > > > > The real question though is why are you calling it

Re: pfind_locked(pid) fails when in a jail?

2017-10-16 Thread Rick Macklem
[stuff snipped] > > > > > pfind* does not do any filtering. > > Hmm, well I have no idea why the jailed mounts get looping in here then. > > The real question though is why are you calling it in the first place. The > > calls > > I grepped in nfscl_procdoesntexist are highly suspicious - there is

Re: pfind_locked(pid) fails when in a jail?

2017-10-16 Thread Ian Lepore
On Tue, 2017-10-17 at 00:38 +0200, Mateusz Guzik wrote: > On Tue, Oct 17, 2017 at 12:24 AM, Rick Macklem wrote: > > > > > Hi, > > > > A problem w.r.t. the NFSv4 client's renew thread (nfscl) running up a lot > > of CPU > > when the NFSv4 mount is in a jail has been

Re: pfind_locked(pid) fails when in a jail?

2017-10-16 Thread Mateusz Guzik
On Tue, Oct 17, 2017 at 12:24 AM, Rick Macklem wrote: > Hi, > > A problem w.r.t. the NFSv4 client's renew thread (nfscl) running up a lot > of CPU > when the NFSv4 mount is in a jail has been reported to the freebsd-stable@ > mailing list. > > I know nothing about jails,

pfind_locked(pid) fails when in a jail?

2017-10-16 Thread Rick Macklem
Hi, A problem w.r.t. the NFSv4 client's renew thread (nfscl) running up a lot of CPU when the NFSv4 mount is in a jail has been reported to the freebsd-stable@ mailing list. I know nothing about jails, but when looking at the code, the most obvious cause of this would be "pfind_locked(pid)"