Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Alexander Leidinger
Am 2023-09-10 18:53, schrieb Robert Clausecker: Hi Warner, Thank you for your response. Am Sun, Sep 10, 2023 at 09:53:03AM -0600 schrieb Warner Losh: On Sun, Sep 10, 2023, 7:36 AM Robert Clausecker wrote: > Hi Warner, > > I have pushed a fix. It should hopefully address those failing tests.

Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Robert Clausecker
Hi Warner, Thank you for your response. Am Sun, Sep 10, 2023 at 09:53:03AM -0600 schrieb Warner Losh: > On Sun, Sep 10, 2023, 7:36 AM Robert Clausecker wrote: > > > Hi Warner, > > > > I have pushed a fix. It should hopefully address those failing tests. > > The same issue should also affect me

Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Dag-Erling Smørgrav
Warner Losh writes: > As for memchr, > https://pubs.opengroup.org/onlinepubs/009696799/functions/memchr.html > has no such permission to examine 'the entire buffer at once' nor any > restirction > as to the length extending beyond the address space. I'm skeptical of your > reading > that it all

Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Warner Losh
On Sun, Sep 10, 2023, 7:36 AM Robert Clausecker wrote: > Hi Warner, > > I have pushed a fix. It should hopefully address those failing tests. > The same issue should also affect memcmp(), but unlike for memchr(), it is > illegal to pass a length to memcmp() that extends past the actual end of >

Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Robert Clausecker
Hi Warner, I have pushed a fix. It should hopefully address those failing tests. The same issue should also affect memcmp(), but unlike for memchr(), it is illegal to pass a length to memcmp() that extends past the actual end of the buffer as memcmp() is permitted to examine the whole buffer rega

Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Lorenzo Salvadore
--- Original Message --- On Sunday, September 10th, 2023 at 13:51, Warner Losh wrote: > > > On Sat, Sep 9, 2023, 10:51 PM Robert Clausecker wrote: > > > Greetings, > > > > I apologise for the inconvenience. The issue seems to boil down to > > various places calling > > > > memchr(b

Re: sed in CURRENT fails in textproc/jq

2023-09-10 Thread Warner Losh
On Sat, Sep 9, 2023, 10:51 PM Robert Clausecker wrote: > Greetings, > > I apologise for the inconvenience. The issue seems to boil down to > various places calling > > memchr(buf, c, SIZE_MAX); > > which causes an overflow when my newly written memchr() computes buf + > len to find the end o

Re: sed in CURRENT fails in textproc/jq

2023-09-09 Thread Robert Clausecker
Greetings, I apologise for the inconvenience. The issue seems to boil down to various places calling memchr(buf, c, SIZE_MAX); which causes an overflow when my newly written memchr() computes buf + len to find the end of the buffer. A patch to alleviate this issue can be found here:

Re: sed in CURRENT fails in textproc/jq

2023-09-09 Thread Dag-Erling Smørgrav
Antoine Brodin writes: > Yuri writes: > > Either something has changed in sed(1) in CURRENT, or sed just fails > > during the configure stage of textproc/jq: > > > > sed: No error: 0 > > checking for sys/cygwin.h... eval: ${+...}: Bad substitution > This seems to be a recent issue (less than 5 da

Re: sed in CURRENT fails in textproc/jq

2023-09-09 Thread Antoine Brodin
On Sat, Sep 9, 2023 at 6:47 AM Yuri wrote: > > Either something has changed in sed(1) in CURRENT, or sed just fails > during the configure stage of textproc/jq: > > sed: No error: 0 > checking for sys/cygwin.h... eval: ${+...}: Bad substitution > > > See the log: > https://pkg-status.freebsd.org/b

sed in CURRENT fails in textproc/jq

2023-09-08 Thread Yuri
Either something has changed in sed(1) in CURRENT, or sed just fails during the configure stage of textproc/jq: sed: No error: 0 checking for sys/cygwin.h... eval: ${+...}: Bad substitution See the log: https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/peb032111a352_s9c80d66ec1/l