swapoff code comitted.

2002-12-15 Thread Matthew Dillon
David Schultz's swapoff code has been comitted. It should be regarded as being highly experimental (and it still needs to be vetted for VM locking changes and other recent changes in -current). A considerable amount of testing has been done already but -current is a moving target.

Re: swapoff code comitted.

2002-12-15 Thread Christian Brueffer
On Sun, Dec 15, 2002 at 11:46:55AM -0800, Matthew Dillon wrote: > David Schultz's swapoff code has been comitted. It should be regarded > as being highly experimental (and it still needs to be vetted for > VM locking changes and other recent changes in -current). A considerable >

Re: swapoff code comitted.

2002-12-15 Thread Matthew Dillon
: :How about renaming swapon(8) into swapctl(8) after this function enhancemen= :t? :This name reflects it's purpose much better and would be consistent with the :other BSDs. : :- Christian I think that's an excellent idea. We would have to do some rewriting to add the expected options bu

Re: swapoff code comitted.

2002-12-15 Thread Christian Brueffer
On Sun, Dec 15, 2002 at 02:47:51PM -0800, Matthew Dillon wrote: > : > :How about renaming swapon(8) into swapctl(8) after this function enhancemen= > :t? > :This name reflects it's purpose much better and would be consistent with the > :other BSDs. > : > :- Christian > > I think that's an exce

Re: swapoff code comitted.

2002-12-16 Thread David Schultz
Thus spake Christian Brueffer <[EMAIL PROTECTED]>: > How about renaming swapon(8) into swapctl(8) after this function enhancement? > This name reflects it's purpose much better and would be consistent with the > other BSDs. It would be trivial to change the name, although I don't see what it buys

Re: swapoff code comitted.

2002-12-18 Thread Eirik Nygaard
On Sun, Dec 15, 2002 at 02:47:51PM -0800, Matthew Dillon wrote: > : > :How about renaming swapon(8) into swapctl(8) after this function > enhancemen= > :t? > :This name reflects it's purpose much better and would be consistent > with the > :other BSDs. > : > :- Christian > > I am not voluntee

Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
:I have made a small patch, added l, s and h switches to show :information about the swap devices. And the U switch to swapctl only :to remove all activated swap devices. :If anything else is needed let me know and I will add it. : :--=20 : :Eirik Nygaard <[EMAIL PROTECTED]> :PGP Key: 83C55EDE

Re: swapoff code comitted.

2002-12-18 Thread Eirik Nygaard
On Wed, Dec 18, 2002 at 11:18:24AM -0800, Matthew Dillon wrote: > > :I have made a small patch, added l, s and h switches to show > :information about the swap devices. And the U switch to swapctl only > :to remove all activated swap devices. > :If anything else is needed let me know and I will ad

Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
:Added the enum instead of is_swap* commands and changed from kvm to :sysctl to get the swap information. : :Eirik Nygaard <[EMAIL PROTECTED]> :PGP Key: 83C55EDE All right, I found a couple more bugs and fleshed it out a bit. You got your LINKS and MLINKS reversed and forgot a +=, you

patch #3 Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
Here's another update. I cleaned things up even more, add BLOCKSIZE support, and updated the manual page. It looks quite nice now. -Matt Index: Makefile === RCS file: /home/nc

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread Bruce Evans
On Wed, 18 Dec 2002, Matthew Dillon wrote: > Here's another update. I cleaned things up even more, add BLOCKSIZE > support, and updated the manual page. It looks quite nice now. I still dislike it. It starts by adding style bugs to the Makefile (changing "=" to "+=" for the initial ass

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread David Schultz
Looks good to me, modulo a few nits. I try not to nitpick, but I've mentioned a few of them below. (BDE does a better job of it than I do anyway. :-) The patch puts identical functionality in two places, so maybe it would make sense to rip support for -s out of pstat/swapinfo (and integrate 'ps

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
:Looks good to me, modulo a few nits. I try not to nitpick, but :I've mentioned a few of them below. (BDE does a better job of it :than I do anyway. :-) : :The patch puts identical functionality in two places, so maybe it :would make sense to rip support for -s out of pstat/swapinfo (and :integ

Re: patch #3 Re: swapoff code comitted.

2002-12-18 Thread Matthew Dillon
: :On Wed, 18 Dec 2002, Matthew Dillon wrote: : :> Here's another update. I cleaned things up even more, add BLOCKSIZE :> support, and updated the manual page. It looks quite nice now. : :I still dislike it. It starts by adding style bugs to the Makefile :(changing "=" to "+=" for the i

Re: patch #3 Re: swapoff code comitted.

2002-12-19 Thread David Schultz
Thus spake Matthew Dillon <[EMAIL PROTECTED]>: > :Looks good to me, modulo a few nits. I try not to nitpick, but > :I've mentioned a few of them below. (BDE does a better job of it > :than I do anyway. :-) > : > :The patch puts identical functionality in two places, so maybe it > :would make sen

Re: patch #3 Re: swapoff code comitted.

2002-12-28 Thread Matthew Dillon
The swapctl code has been comitted. Bruce, you never supplied feedback in regards to your original nits, but feel free to clean the code up now that it has been comitted. All other bullets have been taken care of. I'm still on the fence in regards to backporting it. I would

Re: patch #3 Re: swapoff code comitted.

2002-12-28 Thread Bruce Evans
[Reply to old mail] On Wed, 18 Dec 2002, Matthew Dillon wrote: > :Looks good to me, modulo a few nits. I try not to nitpick, but > :I've mentioned a few of them below. (BDE does a better job of it > :than I do anyway. :-) > : > :The patch puts identical functionality in two places, so maybe it

Re: patch #3 Re: swapoff code comitted.

2002-12-28 Thread Bruce Evans
On Sat, 28 Dec 2002, Matthew Dillon wrote: > The swapctl code has been comitted. Bruce, you never supplied feedback > in regards to your original nits, but feel free to clean the code up > now that it has been comitted. All other bullets have been taken care > of. I'm not sure i