Re: sys/Makefile .if defined(MODULES_WITH_WORLD)

2018-07-09 Thread Ian Lepore
On Mon, 2018-07-09 at 11:50 +0200, Julian H. Stacey wrote: > Hi current@ > src/sys/dev/amdsbwd/amdsbwd.c broke src/sys/modules > > Is it immediately intuitive & well known to developers working in > sys/dev > to enable MODULES_WITH_WORLD before a test make all before a commit ? > > Or what should

sys/Makefile .if defined(MODULES_WITH_WORLD)

2018-07-09 Thread Julian H. Stacey
Hi current@ src/sys/dev/amdsbwd/amdsbwd.c broke src/sys/modules Is it immediately intuitive & well known to developers working in sys/dev to enable MODULES_WITH_WORLD before a test make all before a commit ? Or what should we do to increase the liklehood of commiters catching modules/ errors befo