Re: svn commit: r340187 - head/sys/geom

2018-11-07 Thread Maxim Sobolev
Here are two other possible approaches to fix the issue in question without disrupting special "sector after the last one" handling logic. One patches DIOCGDELETE code to not accept requests clearly beyond the provider's media boundary and the other one extends g_delete_data() to convert bio_lengt

Off-by-1 error in the g_io_check()

2018-10-19 Thread Maxim Sobolev
Hi, I came across a bug that possibly affects all versions of FreeBSD since dawn of the GEOM. There seems to be off-by-one error in the g_io_check() allowing requests that just past the boundary of the device to be accepted. I was particularly looking at generating BIO_DELETE requests in the userla

Re: The geom_raid(8) is not load-balancing reads across all available subdisks

2017-04-20 Thread Maxim Sobolev
ich grave a significant > performance increase. > > See: https://svnweb.freebsd.org/base?view=revision&revision=256956 > > > On Tue, 18 Apr 2017 at 23:17, Maxim Sobolev wrote: > >> Hi, I've got curious as to why running the build on my machine on top of >> the R

The geom_raid(8) is not load-balancing reads across all available subdisks

2017-04-18 Thread Maxim Sobolev
Hi, I've got curious as to why running the build on my machine on top of the RAID1 volume seems to prefer loading one of the drives for reading. Digging into the code I found this: prio += (G_RAID_SUBDISK_S_ACTIVE - sd->sd_state) << 16; /* If disk head is precisely

Re: How to force GEOM to recalculate the free space after the disk is resized?

2016-07-08 Thread Maxim Sobolev
Smells like a bug in the geom_part where it supposed to re-read the partitions and update its internal structures. The reason why it works when you open dev/da1 for writing is because the geom_part provider that is attached to that disk is destroyed and created anew when you close the fd. -Maxim