Re: Memory leak on thread removal

2009-05-17 Thread Mikolaj Golub
On Tue, 12 May 2009 09:27:30 +0300 Mikolaj Golub wrote: MG> Hi, MG> The code below is compiled with -fopenmp and run on FreeBSD6/7 (i386, amd64): MG> #include MG> #include MG> int n = 4, m = 2; MG> int main () { MG> for (;;) { MG> int i; MG>

Re: C99: Suggestions for style(9)

2009-05-17 Thread Stanislav Sedov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 01 May 2009 08:12:29 -0600 (MDT) "M. Warner Losh" mentioned: > > This is a religious point, and we're dangerously close to saying my > religion is better than your religion. I don't like this part of the > proposal at all. I can see the va

Re: C99: Suggestions for style(9)

2009-05-17 Thread Stanislav Sedov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sat, 02 May 2009 09:27:51 +0200 Christoph Mallon mentioned: > I also have to object, that it leads to hunting for declarations. > Actually it usually reduces scrolling around in the code: Many variables > are only assigned once. A typical exampl

Re: C99: Suggestions for style(9)

2009-05-17 Thread Stanislav Sedov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 01 May 2009 14:02:50 +0200 Christoph Mallon mentioned: > > [Don't parenthesize return values] > >> Removed, because it does not improve maintainability in any way. > > > > This change could be made and tested mechanically. But there is > >

Re: C99: Suggestions for style(9)

2009-05-17 Thread Stanislav Sedov
On Fri, 01 May 2009 08:20:20 -0600 (MDT) "M. Warner Losh" mentioned: > > It is a debugging aid, but one of dubious value for a far more > fundamental reason: > > return; > > will break any macro. > You can use variadic marcos in this case if the piece of code debugged uses void retu

Re: C99: Suggestions for style(9)

2009-05-17 Thread Christoph Mallon
Stanislav Sedov schrieb: On Fri, 01 May 2009 08:20:20 -0600 (MDT) "M. Warner Losh" mentioned: It is a debugging aid, but one of dubious value for a far more fundamental reason: return; will break any macro. You can use variadic marcos in this case if the piece of code debugged

Re: C99: Suggestions for style(9)

2009-05-17 Thread Christoph Mallon
Stanislav Sedov schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 01 May 2009 14:02:50 +0200 Christoph Mallon mentioned: [Don't parenthesize return values] Removed, because it does not improve maintainability in any way. This change could be made and tested mechanically. But t

Re: Memory leak on thread removal

2009-05-17 Thread Mikolaj Golub
On Sat, 16 May 2009 20:24:09 +0200 Marius NĂ¼nnerich wrote: >> http://freshmeat.net/projects/lmdbg >> >> This is a small memory leak debugger. It does not provide all functionality >> you can find in more sophisticated tools but is lightweight, portable and >> simple in use. It was very usefu

Re: C99: Suggestions for style(9)

2009-05-17 Thread Stanislav Sedov
On Sun, 17 May 2009 14:36:03 +0200 Christoph Mallon mentioned: > > > Aliasing behavior is stritcly described in > > ISO C99 standard, so there's a good point to enforcing strict-aliasing clear > > code in our kernel. > If you like this addition because of this reason, I have to disappoint > you

Re: C99: Suggestions for style(9)

2009-05-17 Thread Christoph Mallon
Stanislav Sedov schrieb: On Sun, 17 May 2009 14:36:03 +0200 Christoph Mallon mentioned: Aliasing behavior is stritcly described in ISO C99 standard, so there's a good point to enforcing strict-aliasing clear code in our kernel. If you like this addition because of this reason, I have to disapp