Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Ed Schouten
Fixed in r223744. Thanks! -- Ed Schouten WWW: http://80386.nl/ pgpBp8MHciKH9.pgp Description: PGP signature

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Zhihao Yuan
Programmers always want to make things "cooler". Just leave the ->d_namlen there :) On Sun, Jul 3, 2011 at 2:49 PM, Ed Schouten wrote: > * Robert Millan , 20110702 16:56: >> Index: usr.sbin/config/main.c >> === >> --- usr.sbin/config

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Robert Millan
2011/7/3 Ed Schouten : > * Zhihao Yuan , 20110703 22:22: >> Programmers always want to make things "cooler". Just leave the >> ->d_namlen there :) > > Portability isn't achieved by adding #ifdefs, but by writing portable > code. ;-) I really don't mind either way. I hope you two can agree on what

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Ed Schouten
* Zhihao Yuan , 20110703 22:22: > Programmers always want to make things "cooler". Just leave the > ->d_namlen there :) Portability isn't achieved by adding #ifdefs, but by writing portable code. ;-) -- Ed Schouten WWW: http://80386.nl/ pgpbqUUDWhNbF.pgp Description: PGP signature

Re: [PATCH] build config(8) on GNU systems

2011-07-03 Thread Ed Schouten
* Robert Millan , 20110702 16:56: > Index: usr.sbin/config/main.c > === > --- usr.sbin/config/main.c(revision 223721) > +++ usr.sbin/config/main.c(working copy) > @@ -591,7 +591,11 @@ > if ((dirp = opendir(p)) == NULL) >

[PATCH] build config(8) on GNU systems

2011-07-02 Thread Robert Millan
Hi! Please consider this small patch to make config(8) buildable on GNU systems. Thanks -- Robert Millan Index: usr.sbin/config/main.c === --- usr.sbin/config/main.c (revision 223721) +++ usr.sbin/config/main.c (working c