Re: Bug FreeBSD 4.8 ATA driver

2003-08-29 Thread Dan Lukes
Mikulas Patocka wrote: I am reading FreeBSD ATA drivers because I want to use them as base for my ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, there is line if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) { Hm, it should be (IMHO) if (!((pci_read_co

Re: Bug FreeBSD 4.8 ATA driver

2003-08-28 Thread Mikulas Patocka
On Tue, 26 Aug 2003, Dan Lukes wrote: > Mikulas Patocka napsal/wrote, On 08/20/03 01:39: > > I am reading FreeBSD ATA drivers because I want to use them as base for my > > ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, > > there is line > > > > if (!((pci_read_config(paren

Re: Bug FreeBSD 4.8 ATA driver

2003-08-27 Thread soralx
> > I am reading FreeBSD ATA drivers because I want to use them as base for > > my ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, > > there is line > > > > if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) { > > > > if ch->unit is 1, config word is shifted by 25

Re: Bug FreeBSD 4.8 ATA driver

2003-08-27 Thread Dan Lukes
Mikulas Patocka napsal/wrote, On 08/20/03 01:39: I am reading FreeBSD ATA drivers because I want to use them as base for my ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, there is line if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) { if ch->unit is 1, config

Re: Bug FreeBSD 4.8 ATA driver

2003-08-27 Thread Dan Lukes
Mikulas Patocka napsal/wrote, On 08/20/03 01:39: I am reading FreeBSD ATA drivers because I want to use them as base for my ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, there is line if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) { if ch->unit is 1, config

Re: Bug FreeBSD 4.8 ATA driver

2003-08-19 Thread Mikulas Patocka
On Wed, 20 Aug 2003, Mikulas Patocka wrote: > Hi > > I am reading FreeBSD ATA drivers because I want to use them as base for my > ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, > there is line > > if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) { > > if ch->

Bug FreeBSD 4.8 ATA driver

2003-08-19 Thread Mikulas Patocka
Hi I am reading FreeBSD ATA drivers because I want to use them as base for my ATA driver and I found a total nonsence: in ata-dma.c in FreeBSD 4.8, there is line if (!((pci_read_config(parent,0x40,4)>>(ch->unit<<8))&0x4000)) { if ch->unit is 1, config word is shifted by 256 bytes, which gives un