Re: Fixing grep -D skip

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/18/13 08:39, John Baldwin wrote: > On Thursday, January 17, 2013 9:33:53 pm David Xu wrote: >> I am trying to fix a bug in GNU grep, the bug is if you want to >> skip FIFO file, it will not work, for example: >> >> grep -D skip aaa . >> >> i

Re: Fixing grep -D skip

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/18/13 08:39, John Baldwin wrote: I (disclaimer: not bsdgrep person) have just tested that bsdgrep handle this case just fine. The non-blocking part is required to make the code function, otherwise the system will block on open() if fifo don'

Re: Fixing grep -D skip

On Thursday, January 17, 2013 9:33:53 pm David Xu wrote: > I am trying to fix a bug in GNU grep, the bug is if you > want to skip FIFO file, it will not work, for example: > > grep -D skip aaa . > > it will be stucked on a FIFO file. > > Here is the patch: > http://people.freebsd.org/~davidxu/pa

Fixing grep -D skip

I am trying to fix a bug in GNU grep, the bug is if you want to skip FIFO file, it will not work, for example: grep -D skip aaa . it will be stucked on a FIFO file. Here is the patch: http://people.freebsd.org/~davidxu/patch/grep.c.diff2 Is it fine to be committed ? Regards, David Xu