Re: Error checking in ioctl(2)?

2010-04-22 Thread Garrett Cooper
On Thu, Apr 22, 2010 at 5:51 PM, Xin LI wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2010/04/22 17:45, Garrett Cooper wrote: >> On Thu, Apr 22, 2010 at 4:36 PM, Matthew Fleming >> wrote: Hi hackers,     I realize that this isn't 100% userland code, so the checks shoul

Re: Error checking in ioctl(2)?

2010-04-22 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2010/04/22 17:45, Garrett Cooper wrote: > On Thu, Apr 22, 2010 at 4:36 PM, Matthew Fleming > wrote: >>> Hi hackers, >>> I realize that this isn't 100% userland code, so the checks should >>> be minimalized, but when looking at the ioctl(2) sysc

Re: Error checking in ioctl(2)?

2010-04-22 Thread Garrett Cooper
On Thu, Apr 22, 2010 at 4:36 PM, Matthew Fleming wrote: >> Hi hackers, >>     I realize that this isn't 100% userland code, so the checks should >> be minimalized, but when looking at the ioctl(2) syscall code (at >> least I think it is... there's another dupe hanging around in >> sys/dev/hptmv/io

RE: Error checking in ioctl(2)?

2010-04-22 Thread Matthew Fleming
> Hi hackers, > I realize that this isn't 100% userland code, so the checks should > be minimalized, but when looking at the ioctl(2) syscall code (at > least I think it is... there's another dupe hanging around in > sys/dev/hptmv/ioctl.c), I had some questions related to the error > handling n