Re: has 'options LOCKF_DEBUG' ever worked? (w/ patch) (fwd)

2001-11-19 Thread Maxim Konovalov
Hello, Thank you Terry for your answer, I got your meaning. IMHO we can safely commit my patch meanwhile: http://news1.macomnet.ru/~maxim/p/kern_lockf.c.diff Committers? :-) On Fri, 16 Nov 2001, Terry Lambert wrote: Maxim Konovalov wrote: Alfred, John, thanks you very much for your

Re: has 'options LOCKF_DEBUG' ever worked? (w/ patch) (fwd)

2001-11-16 Thread Maxim Konovalov
Hello, On Thu, 15 Nov 2001, Alfred Perlstein wrote: Yes I saw this, I have no idea what 'JH' stands for either that's why I left it as is. The problem is that VTOI is ufs specific, this fix will break LOCKF_DEBUG for all other FS's other than UFS because it casts the vnode-data ptr to

Re: has 'options LOCKF_DEBUG' ever worked? (w/ patch) (fwd)

2001-11-16 Thread Terry Lambert
Maxim Konovalov wrote: Alfred, John, thanks you very much for your answers. I expected something similar. Btw are there any smart ways to find out does underlying FS support inode concept or not? Yes, I know about vnode.v_tag, but comparing it with VT_UFS/VT_NFS/VT_MFS etc does not look OK

Re: has 'options LOCKF_DEBUG' ever worked? (w/ patch) (fwd)

2001-11-15 Thread Alfred Perlstein
Yes I saw this, I have no idea what 'JH' stands for either that's why I left it as is. The problem is that VTOI is ufs specific, this fix will break LOCKF_DEBUG for all other FS's other than UFS because it casts the vnode-data ptr to struct inode *. So your fix is broken. Please just fix

RE: has 'options LOCKF_DEBUG' ever worked? (w/ patch) (fwd)

2001-11-15 Thread John Baldwin
On 15-Nov-01 Maxim Konovalov wrote: It panics because of if_inode is not initiliazed: /sys/kern/kern_lockf.c:1.25:153 /* lock-lf_inode = ip; */ /* XXX JH */ I have no idea what ``JH'' means, the comment appeared in 1.10. revision 1.10 date: 1997/02/10 02:09:36; author: dyson;