Re: SCSI_DELAY cleanup

2010-10-19 Thread Julian Elischer
On 10/19/10 5:39 PM, Warner Losh wrote: opt_scsi.h isn't needed by aha or ahb either, so it can be deleted entirely from their module makefiles: consider I write the original aha driver in 1991 and it is an ISA device, one wonders if there are any users of this any more.. Index: aha/Makefil

Re: SCSI_DELAY cleanup

2010-10-19 Thread Alexander Best
On Tue Oct 19 10, Warner Losh wrote: > opt_scsi.h isn't needed by aha or ahb either, so it can be deleted > entirely from their module makefiles: thanks. :) what about trb/Makefile? seems to build fine too without opt_scsi.h. > > Index: aha/Makefile > ===

Re: SCSI_DELAY cleanup

2010-10-19 Thread Warner Losh
opt_scsi.h isn't needed by aha or ahb either, so it can be deleted entirely from their module makefiles: Index: aha/Makefile === --- aha/Makefile(revision 214058) +++ aha/Makefile(working copy) @@ -4,11 +4,6 @@ KMOD

Re: SCSI_DELAY cleanup

2010-10-19 Thread Warner Losh
> also at some locations in the code SCSI_DELAY is being set to 15000. i believe > this is the case when certain drivers (cam, ahb, aha) get loaded as a kernel > module, but i'm not sure. it looks like this: > > .if !defined(KERNBUILDDIR) > opt_scsi.h: > echo "#define SCSI_DELAY 15000" > ${.

Re: SCSI_DELAY cleanup

2010-10-19 Thread John Baldwin
On Tuesday, October 19, 2010 3:14:46 pm Alexander Best wrote: > On Tue Oct 19 10, John Baldwin wrote: > > On Tuesday, October 19, 2010 10:31:10 am Alexander Best wrote: > > > On Tue Oct 19 10, Matthew Jacob wrote: > > > > It would be an effective behavioral change for those of us who remove > > >

Re: SCSI_DELAY cleanup

2010-10-19 Thread Alexander Best
On Tue Oct 19 10, John Baldwin wrote: > On Tuesday, October 19, 2010 10:31:10 am Alexander Best wrote: > > On Tue Oct 19 10, Matthew Jacob wrote: > > > It would be an effective behavioral change for those of us who remove > > > that line. > > > Personally, I think 5 seconds is too long- even 2 se

Re: SCSI_DELAY cleanup

2010-10-19 Thread John Baldwin
On Tuesday, October 19, 2010 10:31:10 am Alexander Best wrote: > On Tue Oct 19 10, Matthew Jacob wrote: > > It would be an effective behavioral change for those of us who remove > > that line. > > Personally, I think 5 seconds is too long- even 2 seconds is more than > > adequate even for modera

Re: SCSI_DELAY cleanup

2010-10-19 Thread Matthew Jacob
I'd go for the gusto in -current, but it's ok to be conservative too. On Tue Oct 19 10, Matthew Jacob wrote: It would be an effective behavioral change for those of us who remove that line. Personally, I think 5 seconds is too long- even 2 seconds is more than adequate even for moderately ol

Re: SCSI_DELAY cleanup

2010-10-19 Thread Alexander Best
On Tue Oct 19 10, Matthew Jacob wrote: > It would be an effective behavioral change for those of us who remove > that line. > Personally, I think 5 seconds is too long- even 2 seconds is more than > adequate even for moderately old 'other' hardware like scanners. > > For -current, why don't you

Re: SCSI_DELAY cleanup

2010-10-19 Thread Matthew Jacob
It would be an effective behavioral change for those of us who remove that line. Personally, I think 5 seconds is too long- even 2 seconds is more than adequate even for moderately old 'other' hardware like scanners. For -current, why don't you simply remove all of the config lines and leave

Re: SCSI_DELAY cleanup

2010-10-19 Thread Alexander Best
On Mon Oct 18 10, Matthew Jacob wrote: > What problem are you solving by this change? code cleanup. the scsi delay value currently defaults to 2000ms. however that doesn't make sense, since on almost all platforms it gets set to 5000ms in the default config. what's the purpose of having a defaul

Re: SCSI_DELAY cleanup

2010-10-18 Thread Matthew Jacob
What problem are you solving by this change? any thoughts on this patch? i noticed the "default" SCSI_DELAY value of 2000ms was only used in very few places so i thought it would make more sense making 5000ms the default and adding a few special cases where SCSI_DELAY can in fact be lowered do

SCSI_DELAY cleanup

2010-10-18 Thread Alexander Best
any thoughts on this patch? i noticed the "default" SCSI_DELAY value of 2000ms was only used in very few places so i thought it would make more sense making 5000ms the default and adding a few special cases where SCSI_DELAY can in fact be lowered down to 2000ms. cheers. alex -- a13x diff --git