Re: patch to remove random #define MIN/MAX implementations from around the kernel

2003-01-21 Thread Kris Kennaway
On Tue, Jan 21, 2003 at 08:02:59PM -0800, Matthew Dillon wrote: > :You shouldn't modify vendor code for minor purposes. > : > :Kris > > The vendor code in question has been modified *extensively* since > it was imported, (and of course I would give Darren a head's up in > regards to i

Re: patch to remove random #define MIN/MAX implementations from around the kernel

2003-01-21 Thread Matthew Dillon
:Didn't we explicitly make it like this? ie: you'd be backing out a :previous set of intentional commits by doing this... : :Cheers, :-Peter :-- :Peter Wemm - [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] I'm not aware of anything like that. The MIN code appears to be in rev 1.

Re: patch to remove random #define MIN/MAX implementations from around the kernel

2003-01-21 Thread Peter Wemm
Matthew Dillon wrote: > > :On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote: > :> This patch is going to go in on the weekend unless someone has any > :> worthwhile nits about it. It was submitted by Hiten Pandya. > : > :> Index: contrib/dev/oltr/if_oltr.c > : > :> Index: co

Re: patch to remove random #define MIN/MAX implementations from around the kernel

2003-01-21 Thread Matthew Dillon
:On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote: :> This patch is going to go in on the weekend unless someone has any :> worthwhile nits about it. It was submitted by Hiten Pandya. : :> Index: contrib/dev/oltr/if_oltr.c : :> Index: contrib/ipfilter/netinet/ip_proxy.c : :>

Re: patch to remove random #define MIN/MAX implementations from around the kernel

2003-01-21 Thread Kris Kennaway
On Tue, Jan 21, 2003 at 07:25:44PM -0800, Matthew Dillon wrote: > This patch is going to go in on the weekend unless someone has any > worthwhile nits about it. It was submitted by Hiten Pandya. > Index: contrib/dev/oltr/if_oltr.c > Index: contrib/ipfilter/netinet/ip_proxy.c > Index: ne

patch to remove random #define MIN/MAX implementations from around the kernel

2003-01-21 Thread Matthew Dillon
This patch is going to go in on the weekend unless someone has any worthwhile nits about it. It was submitted by Hiten Pandya. The patch basically removes random MIN/MAX implementations from 22 files in the kernel and modifies the one in sys/param.h (see the last part of the