Re: patch to remove random #define MIN/MAX implementations fromaround the kernel

2003-01-22 Thread Matthew Dillon
: :On Tue, 21 Jan 2003, Matthew Dillon wrote: :> This might be useful follow-up work. i.e. the idea of getting rid of :> the use of the MIN and MAX macros in the kernel altogether. Though I'm :> not sure I like the fact that 'min' and 'max' in sys/libkern.h refer to :> unsigned ints (it really s

Re: patch to remove random #define MIN/MAX implementations fromaround the kernel

2003-01-21 Thread Matthew N. Dodd
On Tue, 21 Jan 2003, Matthew Dillon wrote: > This might be useful follow-up work. i.e. the idea of getting rid of > the use of the MIN and MAX macros in the kernel altogether. Though I'm > not sure I like the fact that 'min' and 'max' in sys/libkern.h refer to > unsigned ints (it really should be

Re: patch to remove random #define MIN/MAX implementations fromaround the kernel

2003-01-21 Thread Matthew Dillon
:I'd like to see all of these changed to the inlines in sys/libkern.h since :the compiler will do type checking for us. : :This is a little more work which is why I didn't do it myself when I dealt :with the abs() stuff. : :Consider this my objection. : :I don't think that it really stands in the

Re: patch to remove random #define MIN/MAX implementations fromaround the kernel

2003-01-21 Thread Matthew N. Dodd
On Tue, 21 Jan 2003, Matthew Dillon wrote: > This patch is going to go in on the weekend unless someone has any > worthwhile nits about it. It was submitted by Hiten Pandya. > > The patch basically removes random MIN/MAX implementations from > 22 files in the kernel and modifies th