Re: please review: patch to retain device name for dumpdev.

2012-11-02 Thread Eric van Gyzen
On 11/01/2012 01:48, Alfred Perlstein wrote: /* Registration of dumpers */ int -set_dumper(struct dumperinfo *di) +set_dumper(struct dumperinfo *di, const char *devname) { if (di == NULL) { bzero(&dumper, sizeof dumper); +dumpdevname[0] = '\0'; return (0);

Re: please review: patch to retain device name for dumpdev.

2012-11-01 Thread Alfred Perlstein
On 11/1/12 1:06 AM, Poul-Henning Kamp wrote: In message <50921b44.20...@ixsystems.com>, Alfred Perlstein writes: Poul-Henning, what do you think? Is there a nicer way? Perhaps a way to include the "/dev/$device" I think there are private implemenations where dumpdev is a network thi

Re: please review: patch to retain device name for dumpdev.

2012-11-01 Thread Poul-Henning Kamp
In message <50921b44.20...@ixsystems.com>, Alfred Perlstein writes: >Poul-Henning, what do you think? Is there a nicer way? Perhaps a way >to include the "/dev/$device" I think there are private implemenations where dumpdev is a network thing, so too much magic string editing is proba

please review: patch to retain device name for dumpdev.

2012-11-01 Thread Alfred Perlstein
I've always wanted to be able to query the current dump device. This patch lets me do this. Poul-Henning, what do you think? Is there a nicer way? Perhaps a way to include the "/dev/$device" as the patch in its current form only stores "ada0p3". I think that is OK. Provide a device name i