[patch] setting/matching DSCP with ipfw

2013-03-14 Thread Alexander V. Chernikov
Hello list! This is the obvious thing which should be done at least 5 years ago. There are several PRs like kern/102471 and kern/121122 with similar functionality. Given patch adds setting DSCP support (O_SETDSCP) which works for both IPv4 and IPv6 packets. Fast checksum recalculation (RFC 1624)

Re: kern/121122: [ipfw] [patch] add support to ToS IP PRECEDENCE fields

2013-03-14 Thread melifaro
Synopsis: [ipfw] [patch] add support to ToS IP PRECEDENCE fields Responsible-Changed-From-To: freebsd-ipfw->melifaro Responsible-Changed-By: melifaro Responsible-Changed-When: Thu Mar 14 13:48:37 UTC 2013 Responsible-Changed-Why: Take. http://www.freebsd.org/cgi/query-pr.cgi?pr=121122 __

Re: kern/121122: [ipfw] [patch] add support to ToS IP PRECEDENCE fields

2013-03-14 Thread Eggert, Lars
Hi, interpreting these bits as a TOS field has been deprecated since RFC2474 was published in 1998. Since then, we've been having a DSCP codepoint and ECN bits in the IP header. It would be actively harmful to add TOS byte support 15 years after it was deprecated. Read http://en.wikipedia.org/

Re: [patch] setting/matching DSCP with ipfw

2013-03-14 Thread Marcelo Araujo
2013/3/14 Alexander V. Chernikov > Hello list! > > This is the obvious thing which should be done at least 5 years ago. > There are several PRs like kern/102471 and kern/121122 with similar > functionality. > > Given patch adds setting DSCP support (O_SETDSCP) which works for both > IPv4 and IPv6

Re: kern/121122: [ipfw] [patch] add support to ToS IP PRECEDENCE fields

2013-03-14 Thread Alexander V. Chernikov
On 14.03.2013 17:56, Eggert, Lars wrote: Hi, Hello. interpreting these bits as a TOS field has been deprecated since RFC2474 was published in 1998. Since then, we've been having a DSCP codepoint and ECN bits in the IP header. Yes. I'm going to commit DSCP-based approach, so I'm grabbing all

Re: kern/121122: [ipfw] [patch] add support to ToS IP PRECEDENCE fields

2013-03-14 Thread Eggert, Lars
I suspected that that was what's happening, but it wasn't obvious. Thanks for clarifying! Lars On Mar 14, 2013, at 10:29, Alexander V. Chernikov wrote: > On 14.03.2013 17:56, Eggert, Lars wrote: >> Hi, > Hello. >> >> interpreting these bits as a TOS field has been deprecated since RFC2474 was