Re: Comments Please

2002-10-12 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Luigi Rizzo <[EMAIL PROTECTED]> writes: : On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote: : ... : > : reveals the use of an explicit constant (6) in net/if_arp.h and : > : netinet/if_ether.c; there is more of the same in net/bridge

Re: Comments Please

2002-10-12 Thread Luigi Rizzo
On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote: ... > : reveals the use of an explicit constant (6) in net/if_arp.h and > : netinet/if_ether.c; there is more of the same in net/bridge.c > : (my fault), net/if_atmsubr.c, netinet/if_ether.c, netncp/ncp_subr.c > > atmsubr?

Re: Comments Please

2002-10-12 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Luigi Rizzo <[EMAIL PROTECTED]> writes: : On Sat, Oct 12, 2002 at 05:18:09PM -0600, M. Warner Losh wrote: : > OK. I'm not a network wonk, so I thought I'd run this by people : > here. What do people think. : : sounds ok -- removing explicit constants i

Re: Comments Please

2002-10-12 Thread Luigi Rizzo
On Sat, Oct 12, 2002 at 05:18:09PM -0600, M. Warner Losh wrote: > OK. I'm not a network wonk, so I thought I'd run this by people > here. What do people think. sounds ok -- removing explicit constants is always good. On passing: * While you are at it, grep etherbroadcastaddr sys/net*/

Comments Please

2002-10-12 Thread M. Warner Losh
OK. I'm not a network wonk, so I thought I'd run this by people here. What do people think. Warner --- //depot/user/imp/freebsd-imp/sys/net/if_ethersubr.c 2002/10/06 21:18:24 +++ //depot/user/imp/newcard/net/if_ethersubr.c 2002/10/11 22:58:57 @@ -124,7 +124,8 @@ static int ether_resolvemulti