Re: ADSL PPoA or RFC1483, any solutions ?

2003-10-03 Thread Bruce M Simpson
On Thu, Oct 02, 2003 at 09:53:08AM +0200, Harti Brandt wrote: > Does PPPoA really need signalling? I tried to find any pointers to PPPoA > specification, but this seems to be not easy to find. I was probably half asleep when I wrote that answer :) it's been a stressful week. I should correct mysel

Re: ng_ip_input use case

2003-10-03 Thread Vladimir B. Grebenschikov
В пт, 03.10.2003, в 03:09, Julian Elischer пишет: > > > I have no idea what it is used for.. similar effect can be made by > > > using the ng_iface node, but I think that they didn't want a separate > > > interface for each packet source.. > > > > > > I suggest we ask brooks..(cc'd). I could imag

Re: rtsock.c: eliminate masking of gotos, don't abuse M_RTABLE

2003-10-03 Thread Andre Oppermann
Mike Silbersack wrote: > > On Fri, 3 Oct 2003, Bruce M Simpson wrote: > > > Comments? > > > > BMS > > I think that anything to clean up the routing table is a good idea... > however, aren't there a few major non-committed patches to this area which > are almost ready? (Sam's locking, someone el

Re: rtsock.c: eliminate masking of gotos, don't abuse M_RTABLE

2003-10-03 Thread Bruce M Simpson
On Fri, Oct 03, 2003 at 11:00:10AM +0300, Ruslan Ermilov wrote: > I think these uncommitted patches will mostly affect route.c, while this > patch is for rtsock.c, the route(4) interface with the kernel, which is > unlikely to change a lot. Much-improved patch to cleanup rtsock.c at bde's prodding

Re: rtsock.c: eliminate masking of gotos, don't abuse M_RTABLE

2003-10-03 Thread Ruslan Ermilov
On Fri, Oct 03, 2003 at 02:40:22AM -0500, Mike Silbersack wrote: > > On Fri, 3 Oct 2003, Bruce M Simpson wrote: > > > Comments? > > > > BMS > > I think that anything to clean up the routing table is a good idea... > however, aren't there a few major non-committed patches to this area which > are

Re: rtsock.c: eliminate masking of gotos, don't abuse M_RTABLE

2003-10-03 Thread Mike Silbersack
On Fri, 3 Oct 2003, Bruce M Simpson wrote: > Comments? > > BMS I think that anything to clean up the routing table is a good idea... however, aren't there a few major non-committed patches to this area which are almost ready? (Sam's locking, someone else's moving cloned routes into a tcpstatcac

rtsock.c: eliminate masking of gotos, don't abuse M_RTABLE

2003-10-03 Thread Bruce M Simpson
Hi, Here's a diff to eliminate the senderr() macro from rtsock.c. This macro is masking goto statements, which is incredibly bad style, and makes it difficult to follow the flow of control in the file. This diff also stops rtsock.c from abusing the M_RTABLE malloc define for routing socket messag