[Differential] [Commented On] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-16 Thread mike-karels.net (Mike Karels)
mike-karels.net added a comment. Setting a retransmission timer on an ACK makes no sense; I don't think tcp_output will send an ACK on a retransmission timeout. Setting timers in the ENOBUFS case is at best a partial fix. If the ACK is lost locally, we know; if it is lost elsewhere, we

[Differential] [Commented On] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-16 Thread hiren (hiren panchasara)
hiren added a comment. In https://reviews.freebsd.org/D5872#127345, @jtl wrote: > In https://reviews.freebsd.org/D5872#127343, @mike-karels.net wrote: > > > If we get an ENOBUFS when sending data, we will already be running the retransmit timer. > > > Good point, but see below.